From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
mhiramat@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: kprobes: Remove redundant kprobe_step_ctx
Date: Tue, 10 Nov 2020 19:24:51 +0000 [thread overview]
Message-ID: <X6rpAw2NWxFtaq6a@trantor> (raw)
In-Reply-To: <20201103150151.GB5551@willie-the-truck>
On Tue, Nov 03, 2020 at 03:01:52PM +0000, Will Deacon wrote:
> On Tue, Nov 03, 2020 at 02:49:04PM +0100, Jean-Philippe Brucker wrote:
> > From: Masami Hiramatsu <mhiramat@kernel.org>
> >
> > The kprobe_step_ctx (kcb->ss_ctx) has ss_pending and match_addr, but
> > those are redundant because those can be replaced by KPROBE_HIT_SS and
> > &cur_kprobe->ainsn.api.insn[1] respectively.
> > To simplify the code, remove the kprobe_step_ctx.
> >
> > Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > arch/arm64/include/asm/kprobes.h | 7 ----
> > arch/arm64/kernel/probes/kprobes.c | 53 +++++++-----------------------
> > 2 files changed, 12 insertions(+), 48 deletions(-)
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Catalin should be able to queue this at -rc3, once the first patch has
> landed in mainline.
I queued it but couldn't convince "b4 ty" to reply to patch 2:
https://git.kernel.org/arm64/c/ba090f9cafd53dbabe0f0a8c4ccae44203d3731b
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-10 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:49 [PATCH v2 1/2] arm64: kprobes: Use BRK instead of single-step when executing instructions out-of-line Jean-Philippe Brucker
2020-11-03 13:49 ` [PATCH v2 2/2] arm64: kprobes: Remove redundant kprobe_step_ctx Jean-Philippe Brucker
2020-11-03 15:01 ` Will Deacon
2020-11-10 19:24 ` Catalin Marinas [this message]
2020-11-03 14:54 ` [PATCH v2 1/2] arm64: kprobes: Use BRK instead of single-step when executing instructions out-of-line Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X6rpAw2NWxFtaq6a@trantor \
--to=catalin.marinas@arm.com \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mhiramat@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).