From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD212C56201 for ; Tue, 10 Nov 2020 19:26:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 521F420665 for ; Tue, 10 Nov 2020 19:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bUQotS+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 521F420665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Q+/t9EyvdbgnB+q/Atp5yqVX6BvhDQ8BTc+ThlWKA0=; b=bUQotS+IUTdWCfQDLU3E494RW x4pHZSmokzAwlaPFA530e559ZoqSksrYh8emM1NjFCTmWSsgu/mi2jx7+GDNpY9hb67j7ROezumsm d6NJc3rrv665JpXiZvsrJol3Hij1lQpdXgnuiNaStGWpBNjFESDSM+KugomeYTjkU9+/qysG8xipM 1W7pBhHUt7fzNi5cLDqvMT7j0RvyFltwGJSURH4TRi0zWOu0qIBL/kPjwKL9EKJ7lCBIw6QhupLsz b+l9BgJcYhMw0x1hXEOIzRIVrchE74lExbkW+M/5dwGCu228jUdQybfokebUr+6oKrSxun7ED+fHA umfAhOC9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcZGE-0008Bp-3e; Tue, 10 Nov 2020 19:24:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcZGB-0008BD-34 for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 19:24:56 +0000 Received: from trantor (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79B942064B; Tue, 10 Nov 2020 19:24:53 +0000 (UTC) Date: Tue, 10 Nov 2020 19:24:51 +0000 From: Catalin Marinas To: Will Deacon Subject: Re: [PATCH v2 2/2] arm64: kprobes: Remove redundant kprobe_step_ctx Message-ID: References: <20201103134900.337243-1-jean-philippe@linaro.org> <20201103134900.337243-2-jean-philippe@linaro.org> <20201103150151.GB5551@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103150151.GB5551@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_142455_498802_C852A64F X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , mhiramat@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 03:01:52PM +0000, Will Deacon wrote: > On Tue, Nov 03, 2020 at 02:49:04PM +0100, Jean-Philippe Brucker wrote: > > From: Masami Hiramatsu > > > > The kprobe_step_ctx (kcb->ss_ctx) has ss_pending and match_addr, but > > those are redundant because those can be replaced by KPROBE_HIT_SS and > > &cur_kprobe->ainsn.api.insn[1] respectively. > > To simplify the code, remove the kprobe_step_ctx. > > > > Reviewed-by: Jean-Philippe Brucker > > Signed-off-by: Masami Hiramatsu > > --- > > arch/arm64/include/asm/kprobes.h | 7 ---- > > arch/arm64/kernel/probes/kprobes.c | 53 +++++++----------------------- > > 2 files changed, 12 insertions(+), 48 deletions(-) > > Acked-by: Will Deacon > > Catalin should be able to queue this at -rc3, once the first patch has > landed in mainline. I queued it but couldn't convince "b4 ty" to reply to patch 2: https://git.kernel.org/arm64/c/ba090f9cafd53dbabe0f0a8c4ccae44203d3731b -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel