From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2385BC56201 for ; Wed, 25 Nov 2020 20:24:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BE44207BB for ; Wed, 25 Nov 2020 20:24:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n+wwVvO3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p53ZlOFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BE44207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Oc/7Hwx6ma+sCAIQr+DlfyfHndRAeMy5c6LzDO4gnqE=; b=n+wwVvO32VIqzZab28cGhi/sk n3DFCDCRjLZpom4eqIEXqGCaL32tZ9NPDCHVfnBjFAEYV1hBw+Lof9cKjGekGu4cYIrzz83SkqD+x vVse9onBXhDb07Yn1kg09KheQvBJmLdRjPlN/60bbLaX1/hSypXsaAGW05/CqlsDZmirkvPlv30rO +d/mYz3tBJGjgzCfYmqNPdwXhOtRV8dwCkisgKm2cJmqaZDDJJv8z8jIGaY/+3ogjxPAiCZsYLI/y IEmsqx6Inn6aLq4l3NmOSniBvAXw71dGSIh2O1HIGFSinsFdhrMKa0DKc2dXb+Q5mSCAXkswgkLVT Th9X0Q83A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ki1K5-0004Z3-MJ; Wed, 25 Nov 2020 20:23:29 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ki1K2-0004YM-8U for linux-arm-kernel@lists.infradead.org; Wed, 25 Nov 2020 20:23:27 +0000 Received: by mail-wr1-x444.google.com with SMTP id s8so3167016wrw.10 for ; Wed, 25 Nov 2020 12:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HAsIgb91l988ziBcGNcrP49ar2rihRxhuQj3/0d8grk=; b=p53ZlOFh/RjRZUNp2qU+6lIyreVNSDStpLP0mIuq3mVv105aT+lzFR+q1GN5EwDdjk 7aoYSxYSO3CoPKCKXSdLrbG2qYYpaAyeXjaD1BfDZBQI5liVWnknqpLhSP+KXpBQXIxA HORF1DgX/run8oeKQmr04TuwXAuYkVi+1nvHzC/ABj2wGhLzIKp0g0CUGKx+Ph4nBXeR XK2WwNYtf6Hpyoslh2R0UPYZE/n1ZdQWw5XqUgEPMJbPjnyqV/u1SkmEAeJwdEAA8AYG vPMKqk/tLo7zbsyKX3UQ6awPGRq7T+R/s28YhQu4xXD0Z4DxHxxPaJcChRp/pe1VrMsz JtBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=HAsIgb91l988ziBcGNcrP49ar2rihRxhuQj3/0d8grk=; b=DZ/FIcSKXBdHkbB8mD5wjhG689JbGBqVbJm1AbZ3Fi9T35QsntBRvsgZkZMPO7dGQ/ UkJCLp7vBR8vjHTxOVZrQZqtG+kOX/oXBTRd+4eGrg9G+6dHvQGA2uZWv3UcgaHG/8NV iF6I0K0FrKqL/D9BokyKtu0c9MTp0NA8ARZtwT2sQXHidlQI0LqzDP92vluVFDO2vNM4 GMcrIIdDWj4atGLW19zbFy+bcfghNfR9cIKk8fH/JpWd1KAMsZtStO11OfEyShrwEbfY NxI66VR/EvM9mn+S7Krrc+OwC2AHIbxVxHhpZnFu1fi/HvkY6q7x62yUZ8o77eyRZACp W0eQ== X-Gm-Message-State: AOAM53306RCRUFU9IvTC4w37N15kOSwsGNIgUpBfamuy3LHaI2e4Q6fG HCGzNHBsVtYjjRLAJHhlf2c= X-Google-Smtp-Source: ABdhPJwjH5zp6AbULqjMLlgp2aiGxE2za6uirhO0+Z5fEqxh2RUfIUwMRwnR6DoWuXkzFWBBj2l4IA== X-Received: by 2002:adf:ecd0:: with SMTP id s16mr5851101wro.415.1606335805217; Wed, 25 Nov 2020 12:23:25 -0800 (PST) Received: from eldamar (80-218-24-251.dclient.hispeed.ch. [80.218.24.251]) by smtp.gmail.com with ESMTPSA id k81sm7559215wma.2.2020.11.25.12.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 12:23:24 -0800 (PST) Date: Wed, 25 Nov 2020 21:23:23 +0100 From: Salvatore Bonaccorso To: stable@vger.kernel.org Subject: Re: [PATCH 1/2] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata Message-ID: References: <20201122134339.GA6071@leoy-ThinkPad-X240s> <20201125201215.26455-1-carnil@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201125201215.26455-1-carnil@debian.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_152326_329176_24F9C4C2 X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Zhizhikin , Mathieu Poirier , Suzuki K Poulouse , Alexander Shishkin , coresight ml , Arnaldo Carvalho de Melo , Leo Yan , Namhyung Kim , Robert Walker , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 25, 2020 at 09:12:14PM +0100, Salvatore Bonaccorso wrote: > From: Leo Yan > > commit 95c6fe970a0160cb770c5dce9f80311b42d030c0 upstream. > > If packet processing wants to know the packet is bound with which ETM > version, it needs to access metadata to decide that based on metadata > magic number; but we cannot simply to use CPU logic ID number as index > to access metadata sequential array, especially when system have > hotplugged off CPUs, the metadata array are only allocated for online > CPUs but not offline CPUs, so the CPU logic number doesn't match with > its index in the array. > > This patch is to change tuple from traceID-CPU# to traceID-metadata, > thus it can use the tuple to retrieve metadata pointer according to > traceID. > > For safe accessing metadata fields, this patch provides helper function > cs_etm__get_cpu() which is used to return CPU number according to > traceID; cs_etm_decoder__buffer_packet() is the first consumer for this > helper function. > > Signed-off-by: Leo Yan > Reviewed-by: Mathieu Poirier > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Mike Leach > Cc: Namhyung Kim > Cc: Robert Walker > Cc: Suzuki K Poulouse > Cc: coresight ml > Cc: linux-arm-kernel@lists.infradead.org > Link: http://lkml.kernel.org/r/20190129122842.32041-6-leo.yan@linaro.org > Signed-off-by: Arnaldo Carvalho de Melo > [Salvatore Bonaccorso: Adjust for context changes in > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] > Signed-off-by: Salvatore Bonaccorso That's a fallout on my end. Should have said: This is for 4.19 specifically to be queued. Background: in https://lore.kernel.org/stable/20201014135627.GA3698844@kroah.com/ 168200b6d6ea0cb5765943ec5da5b8149701f36a was queued up for v4.19.y but the prerequeisite commit was not included and so resulted in build failures with gcc 8.3.0. The commit was later on reverted but in this thread it was asked to actually make it possible to compile the file as well with more recent gcc versions. Those two patches to be applied in 4.19.y only pick up a backport of the rerequisite commit 95c6fe970a0160cb770c5dce9f80311b42d030c0 (PATCH 1) followed up by the cherry-pick of 168200b6d6ea0cb5765943ec5da5b8149701f36a again. Regards, Salvatore _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel