From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] device: provide devm_krealloc_array()
Date: Sat, 14 Nov 2020 17:17:24 +0100 [thread overview]
Message-ID: <X7ADFLwEpUHkTiT+@kroah.com> (raw)
In-Reply-To: <20201114154641.0258f4ee@archlinux>
On Sat, Nov 14, 2020 at 03:46:41PM +0000, Jonathan Cameron wrote:
> On Mon, 2 Nov 2020 15:22:25 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > When allocating an array of elements, users should check for
> > multiplication overflow or preferably use one of the provided helpers
> > like: devm_kmalloc_array().
> >
> > This provides devm_krealloc_array() for users who want to reallocate
> > managed arrays.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> +CC Greg KH.
>
> As this is going into a very generic place I'd like a relevant ack.
> That file is a bit of a wild west for acks, but Greg seems most
> appropriate person.
>
> So Greg, any comments on this one?
As there is only 1 user of this function in the patch series, you don't
save any extra code space here, I don't think this is worth it.
We are seeing less and less gains from these new devm_* additions, and
only more confusion and problems with them. So perhaps don't add this?
I don't think it is needed.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-14 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 14:22 [PATCH v2 0/4] iio: adc: xilinx: use even more devres Bartosz Golaszewski
2020-11-02 14:22 ` [PATCH v2 1/4] device: provide devm_krealloc_array() Bartosz Golaszewski
2020-11-14 15:46 ` Jonathan Cameron
2020-11-14 16:17 ` Greg KH [this message]
2020-11-16 10:18 ` Bartosz Golaszewski
2020-11-23 11:38 ` Bartosz Golaszewski
2020-11-28 16:00 ` Jonathan Cameron
2020-11-02 14:22 ` [PATCH v2 2/4] iio: adc: xilinx: use helper variable for &pdev->dev Bartosz Golaszewski
2020-11-02 14:22 ` [PATCH v2 3/4] iio: adc: xilinx: use devm_krealloc_array() instead of kfree() + kcalloc() Bartosz Golaszewski
2020-11-02 14:22 ` [PATCH v2 4/4] iio: adc: xilinx: use more devres helpers and remove remove() Bartosz Golaszewski
2020-11-08 17:08 ` Jonathan Cameron
2020-11-09 10:52 ` Bartosz Golaszewski
2020-11-08 17:08 ` [PATCH v2 0/4] iio: adc: xilinx: use even more devres Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7ADFLwEpUHkTiT+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).