From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EB9C63777 for ; Fri, 20 Nov 2020 08:23:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24FB02078E for ; Fri, 20 Nov 2020 08:23:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UBvK2iqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24FB02078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HgvwqAZueoIGgQHeVJNvcfmY9rr+4x2Ko8fjcYTXIWE=; b=UBvK2iqw0aEMlFEoZ3zykTxVW oS3o4+G+qbZ7rqrT1stpsCXkFrQxUCsdNEwZ8JffX0TrMcietmFgzPilfHdtAxAyixTqjwIBlkMHb PQgFnAoN5Df8Bd0TQS5z4y635KY/zxS/dhWvn7cUHvq77SYFgb+/tL+1pu5lByR4PU5SHE1VcWMlQ yIMfTxC6uy1tjg9fTHcO6Qlybmchj8ijxvxBiCqtT5e9awPtp5QWHf/3tTcTga/whRSDSTvw+Dn/6 +J/dQXOZ9nrCa60w1Kg/3tUR6lILGuurGF9T45iHiHiGn3OOGOgXuCMOSGuGF17iUE8Ai1zH9btXs u66Ci0qnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg1h7-0006LC-98; Fri, 20 Nov 2020 08:23:01 +0000 Received: from mail-lf1-f68.google.com ([209.85.167.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg1h4-0006Jz-PV for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 08:22:59 +0000 Received: by mail-lf1-f68.google.com with SMTP id j205so12219960lfj.6 for ; Fri, 20 Nov 2020 00:22:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=igNyjk3ZPx8gip3TWBwYGkCHE1bwLNjhy25vHgmoofM=; b=pP6m5H2Pi6YMrqV6klsS13aCkCq9bvDUzWXDRk24D/+YufJoXKOAhmggP+vE75nKXH CcyDD2+ajWlLr7guwxaONHugld8DLzGTYzt2miyuvIP3bQrgSQJ4sldrmgDLIYKvRZO9 kLHn5TFKa0PrzHFNynWjtS8s2y5B945W6X3AkXRb8Fi44S4AM/oiYZ2dSkOB96XLAUs0 acuoVGSePSQMA7S6ZqMhhwXCDCCIrR5rWrr8I9cgL33qZGlf7DUGT69lADOip694VJr4 kjcMRN+VSFr18PruYvXEYP5TwenDoPfUuVTJbUsUW8rQwAJ/wzAyO7DZOsLsLhz9Qe7v anVA== X-Gm-Message-State: AOAM531kPA8q/u62NwOePOJSEPcvFPqKGI4fZVOmJzStm1jHUDeLDTQR p9nMj/aEoY+APnzeB1qAlaU= X-Google-Smtp-Source: ABdhPJzOp+eccDhMRSlMLj+WI/oOOIjtCIyDA73IFZ4z9h1b+/Wws70IvzKvmw3L9gkeUZvmlfMgEw== X-Received: by 2002:a19:e01b:: with SMTP id x27mr2881996lfg.510.1605860577080; Fri, 20 Nov 2020 00:22:57 -0800 (PST) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id v16sm220722ljj.0.2020.11.20.00.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 00:22:56 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1kg1h6-0006VH-Ax; Fri, 20 Nov 2020 09:23:00 +0100 Date: Fri, 20 Nov 2020 09:23:00 +0100 From: Johan Hovold To: Tian Tao Subject: Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ Message-ID: References: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_032258_918557_E39C5A27 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, manivannan.sadhasivam@linaro.org, jirislaby@kernel.org, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > > Signed-off-by: Tian Tao > --- > drivers/tty/serial/owl-uart.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c > index c149f8c3..472fdaf 100644 > --- a/drivers/tty/serial/owl-uart.c > +++ b/drivers/tty/serial/owl-uart.c > @@ -251,10 +251,9 @@ static void owl_uart_receive_chars(struct uart_port *port) > static irqreturn_t owl_uart_irq(int irq, void *dev_id) > { > struct uart_port *port = dev_id; > - unsigned long flags; > u32 stat; > > - spin_lock_irqsave(&port->lock, flags); > + spin_lock(&port->lock); Same thing here; this will break with forced irq threading (i.e. "threadirqs") since the console code can still end up being called from interrupt context. > stat = owl_uart_read(port, OWL_UART_STAT); > > @@ -268,7 +267,7 @@ static irqreturn_t owl_uart_irq(int irq, void *dev_id) > stat |= OWL_UART_STAT_RIP | OWL_UART_STAT_TIP; > owl_uart_write(port, stat, OWL_UART_STAT); > > - spin_unlock_irqrestore(&port->lock, flags); > + spin_unlock(&port->lock); > > return IRQ_HANDLED; > } Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel