From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE3AC64E7C for ; Wed, 2 Dec 2020 13:51:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC21E2173E for ; Wed, 2 Dec 2020 13:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC21E2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G0z1IdTeFz2UTxx//W0HAIrArNhXDO/sXO2iXH8+dAQ=; b=B3NQFFLrMuIo4erb7bOILE5Ws CwofUTZ6zgoK04RamEsN3aJvHXz52ClcGSgFk+RbFosZsVrQHdm0ApooNk0F4GG2UXH5cLsmfcuCU yesuj+FnnkPBj+oufW2cmIp0ehOrHQfwVSG0dGDmP8zHvEGn33l+uTLewuXg3QYvS7yDl5lPIXOhc 41T7ZQ1csqZSXGcX7lzBxHsJy0lVnQFna5rK1BDUbXkcp1IomlL7FfU8deI2ETQSw1+cVHoPLbvbF tLajmyYqyISyinPeqxWNCbr1yCRAPwJmQRQFMNNdaCUicdFNsP7rtbZZeatQFnipfepcBac+G7lXR Yha1BFO7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSWV-0002pS-7n; Wed, 02 Dec 2020 13:50:23 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSWR-0002nq-Qm for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 13:50:21 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 34B0C40008; Wed, 2 Dec 2020 13:50:13 +0000 (UTC) Date: Wed, 2 Dec 2020 14:50:13 +0100 From: Paul Kocialkowski To: Sakari Ailus Subject: Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor Message-ID: References: <20201128143350.531460-1-paul.kocialkowski@bootlin.com> <20201128143350.531460-3-paul.kocialkowski@bootlin.com> <20201130092802.GU3940@paasikivi.fi.intel.com> <20201130135331.GW3940@paasikivi.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20201130135331.GW3940@paasikivi.fi.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_085019_992230_79C5EA47 X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============7272224580462341328==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7272224580462341328== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fmR9vRP8nP8AbyZi" Content-Disposition: inline --fmR9vRP8nP8AbyZi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sakari, On Mon 30 Nov 20, 15:53, Sakari Ailus wrote: > Hi Paul, >=20 > On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote: > > Hi Sakari, > >=20 > > On Mon 30 Nov 20, 11:28, Sakari Ailus wrote: > > > Hi Paul, > > >=20 > > > Thanks for the update. I have a few comments on the driver, too. > >=20 > > Thanks for the review! > >=20 > > [...] > >=20 > > > > + ret =3D ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG, > > > > + OV5648_GAIN_BLUE_MAN_L(blue_balance)); > > >=20 > > > return ... > > >=20 > > > Same below (and above). > >=20 > > Well I don't think that makes any functional difference, right? > > My personal preference is to have explicit checks even at the end of fu= nctions > > for symetry and alignment with other blocks. > >=20 > > If it's okay, it'd like to keep it as-is. But if that's against kernel = coding > > style guidelines, I won't argue more. >=20 > Please do change them. >=20 > It's useless code, repeated at the end of a number of functions in this > driver. I wouldn't mind otherwise, but people do take examples from > existing drivers so such patterns tend to repeat in other places. I don't agree that it's useless but I will do as you ask. Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --fmR9vRP8nP8AbyZi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl/Hm5UACgkQ3cLmz3+f v9E2EAf+PzCeUWZ/MOgG6YssuCqygeIecYxuz2zJlBZn0Q40RW/DEIRr0oU43sDh UspNn5HnQFqHYq1Q4n4ENt6LC81OSwayA1rkgcBnf7bXHp82cHhUZXJo6hI8VxMG DT8npmAPy/UTxbZqkoK+tzuH01QJ/GISjBMuXUiK86yz93yeC5UOu81RCsEpmt5r p4n1ZJgj2c7klrKxGugiHzBqEyXiY9Tp/Jj3aY3gl4oEa2ANqqeyBfN7Uq4bbY/B /Gkwbod7LwNWECN09aTxxKlpFzlYGJzH7DxGb7+4EP8IvBcR1w0gTfuqVrWFpH4J moVHdzcRiGP6rOyvIwOw8yYdq24SGA== =wQ41 -----END PGP SIGNATURE----- --fmR9vRP8nP8AbyZi-- --===============7272224580462341328== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7272224580462341328==--