From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD91C64E7C for ; Wed, 2 Dec 2020 15:04:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4324221EB for ; Wed, 2 Dec 2020 15:04:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4324221EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Ex0j0s+VV+VXf+eEsYx+JWn6ohEIg1HhpVZVioeOrY=; b=U4lkQhgXWYsd/zh6/QPVf1EHK 1ThUEE3dM96PJgwR8kj6ufnCTW50upcUYwqeX0sm4TvS5hmqSEN3N7+jfONhNhxqT41bgeF479b9v Kv88vw/KJyWA+/4V8d073y/iRK8gi4HqgG+Zt9+xqNb2NDlmfvwD7eGWWAYBtB5xzr/NA5J3ORCGW j3LiYqXG0sLQXOKh+qgyUpkGhwpX1re1mt9vdWrpFT+u021KTqwhA7uOX9I3LrZ+3m1+v/ioCql2i sQK29DONC1B/V+XmqsJminzste1AK4Y3pqR6Ofu4x2PdRp6UOoedILHgFDDkvUNOHZLOgi8KmwU8M TuRpB7pXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkTeB-00063A-MP; Wed, 02 Dec 2020 15:02:24 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkTe8-00062I-4k for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 15:02:22 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id CEC1E6000C; Wed, 2 Dec 2020 15:02:09 +0000 (UTC) Date: Wed, 2 Dec 2020 16:02:09 +0100 From: Paul Kocialkowski To: Maxime Ripard Subject: Re: [PATCH v2 09/19] ARM: dts: sunxi: h3/h5: Add CSI controller port for parallel input Message-ID: References: <20201128142839.517949-1-paul.kocialkowski@bootlin.com> <20201128142839.517949-10-paul.kocialkowski@bootlin.com> <20201201121405.at4pwxon56ecwrx6@gilmour> MIME-Version: 1.0 In-Reply-To: <20201201121405.at4pwxon56ecwrx6@gilmour> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_100220_378590_8C86E5CF X-CRM114-Status: GOOD ( 24.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dafna Hirschfeld , linux-doc@vger.kernel.org, linux-sunxi@googlegroups.com, Thomas Petazzoni , kevin.lhopital@hotmail.com, devel@driverdev.osuosl.org, Jonathan Corbet , Kishon Vijay Abraham I , Chen-Yu Tsai , Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Sakari Ailus , Helen Koike , Rob Herring , Yong Deng , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Vinod Koul , Philipp Zabel Content-Type: multipart/mixed; boundary="===============9194668063730330777==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9194668063730330777== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rGPkz4GDdv/zCi05" Content-Disposition: inline --rGPkz4GDdv/zCi05 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue 01 Dec 20, 13:14, Maxime Ripard wrote: > On Sat, Nov 28, 2020 at 03:28:29PM +0100, Paul Kocialkowski wrote: > > Since the CSI controller binding is getting a bit more complex due > > to the addition of MIPI CSI-2 bridge support, make the ports node > > explicit with the parallel port. > >=20 > > This way, it's clear that the controller only supports parallel > > interface input and there's no confusion about the port number. > >=20 > > Signed-off-by: Paul Kocialkowski > > --- > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sun= xi-h3-h5.dtsi > > index 9be13378d4df..02b698cace6a 100644 > > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > @@ -803,6 +803,15 @@ csi: camera@1cb0000 { > > pinctrl-names =3D "default"; > > pinctrl-0 =3D <&csi_pins>; > > status =3D "disabled"; > > + > > + ports { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + csi_in_parallel: port@0 { > > + reg =3D <0>; > > + }; > > + }; > > }; >=20 > This will create a DTC warning, since port@0 is the only node, and is > equivalent to port I'm not seeing the warning when running dtbs_check. More generally, why is it a problem that there's only one node defined? One issue that I did see is that the port node doesn't have an endpoint here, so I will remove the requirement to have an endpoint in the bindings documentation to allow this kind of definition. Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --rGPkz4GDdv/zCi05 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl/HrHEACgkQ3cLmz3+f v9ErpAgAl7uJWiiZLPZchWKL6k5dL9UqFnjiKHTANDFz4zNTRp/o32qFhs/5b/dS YmQq0RsO+cyvnDxYlcRd1a49EhTeI08dsZtMrAzeLGqrOmxwBNEoJiNASEDRodFP MogKS9JER+A8zl3msQDPCDlBRTVwQrQaDbpHBKoF6qQTbWWuG+2/AY/LCr6DFY2X GoR7hXqjiJkIzc+49SC2C3mnycLETpJAf7mY3mQkTHdbuKqJCyjglrCPtvLvzxLU U5bzjNMc/Lm7X1NP1aOMCHhSJ0yE6/vewMKkceTfm4AUvS48fz2/s78AU2n4rD/U ETFlPrmf9vkxA732GCZiTvH9OQWHTA== =PFfC -----END PGP SIGNATURE----- --rGPkz4GDdv/zCi05-- --===============9194668063730330777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9194668063730330777==--