From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 909BDC433FE for ; Thu, 3 Dec 2020 19:37:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DADD207A9 for ; Thu, 3 Dec 2020 19:37:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DADD207A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p51K01dNELKrEOm0v2598xXZ322YrceYGwKsnEtTsXU=; b=K/cQSOkksqii4EH0CgDWOoRWH wol9xApnyYh2ruRlZI0VcSjg/LOrYKg3qvotrPnEvnIE692hbiImXKT+sOyr3GpUC0rLRI7O2pBt0 xDiqPLovRfUCtztkTHLmXhsvYB35OLNAgLjlLChwsFjtuq7sRBsXiUnZy91qUfUniJAQ+NFz/xkE5 2hQz+afw09mU0cwBUnaf7A5NaS4Dgay2bSbNDGnSgPW/UUGs6Is3XqwfHv0BT5whnsXvWrejDUnDR m9glmEkc9WVzcKbt66EVLC/bdOgYAfGI6JBP8chb3bq0JMdn/YvHSLSF7jSthNlj2dfwk1fuJM74+ 2HMUQ4H8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkuOv-0002Le-Kj; Thu, 03 Dec 2020 19:36:25 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkuOt-0002LJ-6Q for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 19:36:24 +0000 Received: by mail-pg1-x541.google.com with SMTP id t37so2030576pga.7 for ; Thu, 03 Dec 2020 11:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6eF0QAIv1/KV66bOz8yibVCv90a/ydrrt73kEf7iSL0=; b=XiG4CJIwwDFhuy/CwzksffK4iSUbGJsiF9xFlB3WPBKUSTNqFN1dROzJRaXSk3Mt1I maHF7w9nVaKKiDUR87XP+CeoW1cg9mNwuuQuaBSJNBNo61PfYSQHt+wwe1FZylCK4ms3 WcBdBqbwzFS7xSF4EajV5PryEhg/N1UWJrZlEKHrLcZbK71PsUMYYkYzJI7l+vbSHjvr uJ/hFO+v0fZgpH5gvMRg4csxWjUwwluut4EraZz6md3zUAUl0TKAoSUW6I1UHqgJZPyX AzxopWChGHk6EouWsVU3rzG9g24DjQGM57/c8kaK1ko1b/ChJ9MDKHmQVqhw/aSYxuWQ BSwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6eF0QAIv1/KV66bOz8yibVCv90a/ydrrt73kEf7iSL0=; b=A0xICD0uJ5uzTu8s4nNOL4oIO7tUaoFxM9NfMwdAalYId/LKqJo+V+UtgdT+ogjzlC Cpp58zLf0FVYM50QjFMqs6gcKerJoW5migoOlb8jriWXoCC/Mt7hV7EAmbRJ4Jrb04vw K/X/6xkD13g8nQ74GG+Wz31pnUZ9y5UUfAkF6JL25p6xrb3FkmR2dkfeoX7tklp6ACb3 /yVoht7yQ/VSWPqLHGmpoM43Is+KNs9unH4KLuQYXTcYriIPksvRZ44rvRt/TXYPLlSL 09pmGVuhmPvOzvaKd7wYHij9nq1hS1tFq5qYiGjPmFivTtsyoUq0tyjddnIWATmc34So RIhw== X-Gm-Message-State: AOAM53103m7C3X+JM0EVSisLCAsd/sBYkesA8FcZE6FrxvACTFnmEuLt D1hpSklJRKVhliGoavScD3c= X-Google-Smtp-Source: ABdhPJxQ69cqa+vTX02ABVOcpHMNCayrSfyBWmKagfJRt8wTHCp1IiB1wF3KUV3C2WVR1dW1MaAA1A== X-Received: by 2002:a62:8247:0:b029:19d:b276:96fb with SMTP id w68-20020a6282470000b029019db27696fbmr428918pfd.8.1607024180754; Thu, 03 Dec 2020 11:36:20 -0800 (PST) Received: from google.com ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id jz7sm185228pjb.14.2020.12.03.11.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 11:36:19 -0800 (PST) Date: Thu, 3 Dec 2020 11:36:16 -0800 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 4/5] amba: Make the remove callback return void Message-ID: References: <20201124133139.3072124-1-uwe@kleine-koenig.org> <20201124133139.3072124-5-uwe@kleine-koenig.org> <20201203130141.ys2s7aaltyzkdena@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201203130141.ys2s7aaltyzkdena@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_143623_259237_1B55A6BB X-CRM114-Status: GOOD ( 22.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , David Airlie , Linus Walleij , Alexandre Belloni , Jaroslav Kysela , Eric Anholt , Jiri Slaby , Rob Herring , Herbert Xu , Russell King , Krzysztof Kozlowski , Alexander Shishkin , Guenter Roeck , kernel@pengutronix.de, Arnd Bergmann , Alex Williamson , Mark Brown , Matt Mackall , Dan Williams , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Cornelia Huck , Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Daniel Vetter Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-K=F6nig wrote: > Hello, > = > [This is a resend because somehow my MUA failed to parse the To: list > and dropped it without me noticing it. Sorry to those who got it twice > now.] > = > On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > > = > > All amba drivers return 0 in their remove callback. Together with the > > driver core ignoring the return value anyhow, it doesn't make sense to > > return a value here. > > = > > Change the remove prototype to return void, which makes it explicit that > > returning an error value doesn't work as expected. This simplifies chan= ging > > the core remove callback to return void, too. > > = > > Reviewed-by: Ulf Hansson > > Reviewed-by: Arnd Bergmann > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > drivers/amba/bus.c | 5 ++--- > > drivers/char/hw_random/nomadik-rng.c | 3 +-- > > drivers/dma/pl330.c | 3 +-- > > drivers/gpu/drm/pl111/pl111_drv.c | 4 +--- > > drivers/hwtracing/coresight/coresight-catu.c | 3 +-- > > drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +--- > > drivers/hwtracing/coresight/coresight-cti-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etb10.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-funnel.c | 4 ++-- > > drivers/hwtracing/coresight/coresight-replicator.c | 4 ++-- > > drivers/hwtracing/coresight/coresight-stm.c | 4 +--- > > drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-tpiu.c | 4 +--- > > drivers/i2c/busses/i2c-nomadik.c | 4 +--- > > drivers/input/serio/ambakmi.c | 3 +-- Acked-by: Dmitry Torokhov Thanks. -- = Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel