From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3FEC433FE for ; Sat, 5 Dec 2020 00:27:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B134322D6E for ; Sat, 5 Dec 2020 00:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B134322D6E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L4AL9h8bG0R/1RJnyF9IHP2Te23wyzbWJu04nq+mz44=; b=F37fnbTNxnX9LGfLSCb12Q4sR KGfJEPwIY5uwOncFr/uuxi468vMp/74z3ATSC/uUK0fDgz8uxyyXUzDeV9OAjagztM6HE6kMJry7m fEQ3x9LKOj7w/h6uM8pc6qVROZ7/Lqybui+ZLcNoGZgYZXuPmCmeXJbjzwst0rnc+d0DKts6PUD3H zBHDxIJvr980eNGo/CW/NY2T+tr2FeHoF8U00R4IU2Lsff9Ah/txLF2BSRzSSnVrxjGXUrfvAP5rM U4ZMtnytoRrO4k562EFNchLl2tjoEzQNRsjtSrVG36t6zS1IvBSHIgLzIinbm3cFLed+Y0C++uVZ/ nvGHTvMlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klLOx-00084w-D2; Sat, 05 Dec 2020 00:26:15 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klLOu-00084M-2M for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 00:26:13 +0000 Received: by mail-oi1-x242.google.com with SMTP id d27so685478oic.0 for ; Fri, 04 Dec 2020 16:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qOGIn6XgIjkM7jRRGqXrjtA4GUnaVDyVp5HpjIpLBeQ=; b=cspoud3vzZ21kG9yq7HVX14L34/4y0sCDfxSomzTpfqz0uDLEsUBY4YOMDCtRRp3N1 r9KOpbpiILwKjd20qFbK08ymxr6RU6Ea8Q03AKwhoMUx2kvlXTzhjef9rAaJJDgOEKZ1 l8+ZMS9f3WNriFCGFf4IXG/jbu1dCWHK3v2UIlxEgyLB4F0ipahdJ9HP0opCJOhQeMFq qa2Hftj8LuD6/9usXLXcL6Ee97bv3EzSQovbj9KI1QvlJ4A35CSxbh6/+zlivadP/9cs vCN8V1kK9zEY84k/+klNF6uQ47Nd8op5S1fGFbjW4wDB/Hp8LcTNqz7ODiqb6Wnm/emt XR/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qOGIn6XgIjkM7jRRGqXrjtA4GUnaVDyVp5HpjIpLBeQ=; b=K6xCmhpveJJOfOTSHaOaITWwmFlxmiKMtPk5cE+k4/RL9q4+qBAGlb9p18/KTWQ3Ir zH5OrGlBk8U7wGCL0OW51u7lyVTpwOxL8x+X6AkHQEry5m7yJpa7OqpEi51SZwuJTf7L nYLTIkVvGtn3ZqZxyOexDJURinmi3e/Fcr7Yjpg1S4HGAaDENrS3Fh5/eaV407J6uqU7 j4buaTE705i4NikgpchrQ2vTlJzxVgGaGo9cfCJv61stb5spCbXTcnAmDfbvzUxSzBAV Z0JricjLvk8m9FMsLnwGK+pxrmcn0Jd0vqptzwuvkBlhRSM+f1/hAVhksaVBii/zPFYr xpLA== X-Gm-Message-State: AOAM532m8Pp1Bnjce2eyXmmc6b7ECcHb2oyDNvwvOSFs4hcIeXofS8/c GKDFrQwcKDvzhvihrQbGUpCC2A== X-Google-Smtp-Source: ABdhPJyMefuSvFZG9IsAQncafN3zL56HOZm/awMd79vg1THW6ginWeewzZoZQ/jHvS9NBMwc5lpq9A== X-Received: by 2002:aca:f089:: with SMTP id o131mr5098170oih.88.1607127970239; Fri, 04 Dec 2020 16:26:10 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r7sm1018595oih.21.2020.12.04.16.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 16:26:09 -0800 (PST) Date: Fri, 4 Dec 2020 18:26:07 -0600 From: Bjorn Andersson To: "Peng Fan (OSS)" Subject: Re: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message Message-ID: References: <20201204074036.23870-1-peng.fan@oss.nxp.com> <20201204074036.23870-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201204074036.23870-4-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_192612_222995_957C641B X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, Peng Fan , Richard Zhu , mathieu.poirier@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 04 Dec 01:40 CST 2020, Peng Fan (OSS) wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Acked-by: Richard Zhu > Reviewed-by: Mathieu Poirier > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index d1abb253b499..aa5fbd0c7768 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -270,7 +270,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "devm_ioremap failed\n"); I would prefer if this was expanded to a proper sentence, and I really like the second part of the commit message to be included in the change. So something like: dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); And similarly below if mapping a memory-region fails. Thanks, Bjorn > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel