From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31ABC4361A for ; Sat, 5 Dec 2020 09:07:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C60222D72 for ; Sat, 5 Dec 2020 09:07:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C60222D72 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dominikbrodowski.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UxQPJQTwyZ1LF0ds8PKAnJVu5Qe8xc0Si6tq/hxdojg=; b=odjIqpJ3VNsIXf7pEdBIBdS6l u6UeLRNRbHyKQhrCnRM6xAS27WrKTAbMSCyzDU6dxIsUKmQ+J6+BGFmfCL/8TET4edguFEiZgC2TZ az2Vv8vH5XPtwnNQl1UPxeaiRD5SqBo1x8/UHlPbeNto0QZsZ2nvIsEDsR4300WAphUUK1mtC3JeE WUi/cRt6LqiCO+C2VJxb+JX2ryH4kET5imjY0BuQ95f1MYwNNbcult2lfNaoZogM3msjY3+p5vIAY pVwuTyaumbmw+yVGOM3aaeIMN/g9eFn4OA6tj5seVd2itAt1ndpCRJ+Y/lpaC7/IB0xqKKUM+z+QW 438iO3ehg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klTVb-0000DH-Sa; Sat, 05 Dec 2020 09:05:40 +0000 Received: from isilmar-4.linta.de ([136.243.71.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klTVX-0000Bb-2W for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 09:05:36 +0000 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.2.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 55F72201111; Sat, 5 Dec 2020 09:05:30 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id 1107F20EBD; Sat, 5 Dec 2020 09:26:28 +0100 (CET) Date: Sat, 5 Dec 2020 09:26:27 +0100 From: Dominik Brodowski To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_040535_266200_A3EEDC63 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Dmitry Torokhov , Russell King , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Thu, Nov 26, 2020 at 12:47:24PM +0100 schrieb Uwe Kleine-K=F6nig: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. To simplify the quest to > make this function return void, let struct sa1111_driver::remove return > void, too. All users already unconditionally return 0, this commit makes > it obvious that returning an error code is a bad idea and ensures future > users behave accordingly. > = > Signed-off-by: Uwe Kleine-K=F6nig For the PCMCIA-related change, FWIW, Acked-by: Dominik Brodowski Thanks, Dominik _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel