From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C67C4361B for ; Thu, 10 Dec 2020 19:40:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90D5323D23 for ; Thu, 10 Dec 2020 19:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90D5323D23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4q+H9Sfp9jHT9AXBaH6+8ZXfQpfGE7TNZHjEXmj/vzE=; b=JVGT0K1HmICO5kH+Vl6bAchr5 mLNGE5NCGr+uHSpeotVZSThOkCxOagIJHpfKDvvsfYpWxnZXr4e0dg3fdbgeTMbT+DbWudWO5FiYp r4PE8TRZkzW9kPW16U1nuHqDJoSlOdlQDjRutEdRqa8nV+cR6DHYd4gkUMk1tlsnGp3COBfprHm7i hieqXcSZ1qigc2nA02c/VGXIjYZ/vagW0vszUce0mX6B5i5J9ZtBkgSsRf3B4sy/vmtm1ppDnP+fb A8H2DPuKBv/smF5ZRfkr8N2e8abj+8oJb0tRy4Fq1LwQlTlSvJPkE3CdTn//JFv+eiNRAnI7kelck ieV5Q149g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knRlr-0007at-I1; Thu, 10 Dec 2020 19:38:35 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knRlo-0007aa-Kd for linux-arm-kernel@lists.infradead.org; Thu, 10 Dec 2020 19:38:34 +0000 Received: by mail-ot1-x343.google.com with SMTP id h18so6017355otq.12 for ; Thu, 10 Dec 2020 11:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=itNVUe4nGhfaxDAAXMUA2TabJXDE3vbfjIiEoiVPXxw=; b=vpR6XPSqBdyBfXiAaSrqxp+Tk+SAKz0wwetdlF2d5h9jkwKvaE2+sOKvL1IaxiNZDf Rs5NdbT/Gmrsy52K0wO2qWnsphoESL5QwqxkhjlG6WKu+I3J0ELgZBpk4HQKsPTJ0dIa ycQLbjOM1qclObmIAlQDjSbo5kptFGIRxkDlyXmmImSsAEXylGWs4bbiCII33gaJZT43 T/0gRfS379Hf9+OkcswkRqzwnDzQeFez6BimVUgrUvTipis+wZV5EGecaL+sCS4Rvvxq +4b8JPuWbfwVSGok0fYqaeq9JqDcO+RcHdhBfk2YNeykBwaJRFXlInm/CPmOxp8ZfHO0 h1Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=itNVUe4nGhfaxDAAXMUA2TabJXDE3vbfjIiEoiVPXxw=; b=ACaWF4gNq/adFXlC2TevP+EMV8ttgO++koQZ9vOFVz4HcGcJ6UImohdc9ceAwjdHBH TlZcSBQnRCkjf4gGYcEnk+STFqOHiR6V8zALCr7ShMDS4PJbRhAtY+YTk72iAtooeWfr BKy/8UWqe41M8dbjCJ4dR3jZagzT+qhcftC8CNgU901y1mzskGd+cu28JNzubTTqnvdQ kQVef/Ufz7GaJ+LtTcneU37Qy+bsSVlBnB3o7u7n2XbseSWakOooMxDTpF05k4PJ64S1 0p0g78U+44PfZvOph/PJbPeqLPnZa8AV6y9Xy0zVbRXl6uLjEexI5+9eu2F/GDJMVTE8 km9Q== X-Gm-Message-State: AOAM5331h2801+AVJ/Hcc9urJXFbBsDpohNVzhp/uLzhzvFfTna4PGZL EymZmo57QuUfKR9eKYDTov/RpQ== X-Google-Smtp-Source: ABdhPJx/+oZpq0qsI+U7TCEox81OmhGbzuOMUFhf/Vw4FviGqxKeQuW5Pjtk5L/wK2MxTcOaFl2zmg== X-Received: by 2002:a05:6830:1ac3:: with SMTP id r3mr1532705otc.363.1607629110781; Thu, 10 Dec 2020 11:38:30 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t72sm1204141oie.47.2020.12.10.11.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 11:38:30 -0800 (PST) Date: Thu, 10 Dec 2020 13:38:28 -0600 From: Bjorn Andersson To: Zhaoyu Liu Subject: Re: [PATCH v2] pinctrl: remove empty lines in pinctrl subsystem Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_143833_042253_22B85157 X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, geert+renesas@glider.be, linus.walleij@linaro.org, stefan@agner.ch, manivannan.sadhasivam@linaro.org, festevam@gmail.com, gregory.clement@bootlin.com, ludovic.desroches@microchip.com, agross@kernel.org, linux-imx@nxp.com, sebastian.hesselbarth@gmail.com, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, patrice.chotard@st.com, kernel@pengutronix.de, shawnguo@kernel.org, afaerber@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 10 Dec 11:35 CST 2020, Zhaoyu Liu wrote: > Remove all empty lines at the end of functions in pinctrl subsystem, > make the code neat. > Target files: grep -nwR -B1 ^} drivers/pinctrl/* | grep '[0-9]-$' | less Wouldn't this be a reasonable thing to teach checkpatch about? > > Reviewed-by: Linus Walleij > Reviewed-by: Andy Shevchenko Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Zhaoyu Liu > --- > Changelog: > v2: > - Fixed the same problem in all files in pinctrl subsystem. > v1: > - Remove the blank line in pinctrl_register(). > --- > drivers/pinctrl/actions/pinctrl-owl.c | 1 - > drivers/pinctrl/core.c | 1 - > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 - > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 1 - > drivers/pinctrl/pinctrl-at91.c | 1 - > drivers/pinctrl/pinctrl-st.c | 1 - > drivers/pinctrl/pinctrl-sx150x.c | 1 - > drivers/pinctrl/qcom/pinctrl-sdm845.c | 1 - > drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 1 - > drivers/pinctrl/renesas/pfc-r8a77950.c | 1 - > drivers/pinctrl/renesas/pfc-r8a77951.c | 3 --- > drivers/pinctrl/renesas/pfc-r8a7796.c | 1 - > drivers/pinctrl/renesas/pfc-r8a77965.c | 1 - > 13 files changed, 15 deletions(-) > > diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c > index 903a4baf3846..c8b3e396ea27 100644 > --- a/drivers/pinctrl/actions/pinctrl-owl.c > +++ b/drivers/pinctrl/actions/pinctrl-owl.c > @@ -444,7 +444,6 @@ static int owl_group_config_get(struct pinctrl_dev *pctrldev, > *config = pinconf_to_config_packed(param, arg); > > return ret; > - > } > > static int owl_group_config_set(struct pinctrl_dev *pctrldev, > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > index 3663d87f51a0..1f944685047b 100644 > --- a/drivers/pinctrl/core.c > +++ b/drivers/pinctrl/core.c > @@ -2115,7 +2115,6 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc, > return ERR_PTR(error); > > return pctldev; > - > } > EXPORT_SYMBOL_GPL(pinctrl_register); > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c > index 08d110078c43..70186448d2f4 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c > @@ -290,7 +290,6 @@ static const struct pinctrl_ops imx1_pctrl_ops = { > .pin_dbg_show = imx1_pin_dbg_show, > .dt_node_to_map = imx1_dt_node_to_map, > .dt_free_map = imx1_dt_free_map, > - > }; > > static int imx1_pmx_set(struct pinctrl_dev *pctldev, unsigned selector, > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index 68894e9e05d2..5a68e242f6b3 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -188,7 +188,6 @@ static struct armada_37xx_pin_group armada_37xx_nb_groups[] = { > PIN_GRP_GPIO_2("led1_od", 12, 1, BIT(21), BIT(21), 0, "led"), > PIN_GRP_GPIO_2("led2_od", 13, 1, BIT(22), BIT(22), 0, "led"), > PIN_GRP_GPIO_2("led3_od", 14, 1, BIT(23), BIT(23), 0, "led"), > - > }; > > static struct armada_37xx_pin_group armada_37xx_sb_groups[] = { > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index 72edc675431c..9015486e38c1 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -733,7 +733,6 @@ static const struct at91_pinctrl_mux_ops sam9x60_ops = { > .get_slewrate = at91_mux_sam9x60_get_slewrate, > .set_slewrate = at91_mux_sam9x60_set_slewrate, > .irq_type = alt_gpio_irq_type, > - > }; > > static struct at91_pinctrl_mux_ops sama5d3_ops = { > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 7b8c7a0b13de..43d9e6c7fd81 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -541,7 +541,6 @@ static void st_pinconf_set_retime_packed(struct st_pinctrl *info, > st_regmap_field_bit_set_clear_pin(rt_p->delay_0, delay & 0x1, pin); > /* 2 bit delay, msb */ > st_regmap_field_bit_set_clear_pin(rt_p->delay_1, delay & 0x2, pin); > - > } > > static void st_pinconf_set_retime_dedicated(struct st_pinctrl *info, > diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c > index c110f780407b..484a3b9e875c 100644 > --- a/drivers/pinctrl/pinctrl-sx150x.c > +++ b/drivers/pinctrl/pinctrl-sx150x.c > @@ -443,7 +443,6 @@ static void sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, > sx150x_gpio_oscio_set(pctl, value); > else > __sx150x_gpio_set(pctl, offset, value); > - > } > > static void sx150x_gpio_set_multiple(struct gpio_chip *chip, > diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c > index 2834d2c1338c..c51793f6546f 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c > +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c > @@ -1310,7 +1310,6 @@ static const struct msm_pinctrl_soc_data sdm845_pinctrl = { > .ngpios = 151, > .wakeirq_map = sdm845_pdc_map, > .nwakeirq_map = ARRAY_SIZE(sdm845_pdc_map), > - > }; > > static const struct msm_pinctrl_soc_data sdm845_acpi_pinctrl = { > diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > index 681d8dcf37e3..92e7f2602847 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c > @@ -617,7 +617,6 @@ static void pm8xxx_mpp_dbg_show_one(struct seq_file *s, > } > break; > } > - > } > > static void pm8xxx_mpp_dbg_show(struct seq_file *s, struct gpio_chip *chip) > diff --git a/drivers/pinctrl/renesas/pfc-r8a77950.c b/drivers/pinctrl/renesas/pfc-r8a77950.c > index 04812e62f3a4..9d89da2319e5 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a77950.c > +++ b/drivers/pinctrl/renesas/pfc-r8a77950.c > @@ -1668,7 +1668,6 @@ static const unsigned int avb_mii_pins[] = { > PIN_AVB_RX_CTL, PIN_AVB_RXC, PIN_AVB_RD0, > PIN_AVB_RD1, PIN_AVB_RD2, PIN_AVB_RD3, > PIN_AVB_TXCREFCLK, > - > }; > static const unsigned int avb_mii_mux[] = { > AVB_TX_CTL_MARK, AVB_TXC_MARK, AVB_TD0_MARK, > diff --git a/drivers/pinctrl/renesas/pfc-r8a77951.c b/drivers/pinctrl/renesas/pfc-r8a77951.c > index a94ebe0bf5d0..919120b4adf3 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a77951.c > +++ b/drivers/pinctrl/renesas/pfc-r8a77951.c > @@ -1727,7 +1727,6 @@ static const unsigned int avb_mii_pins[] = { > PIN_AVB_RX_CTL, PIN_AVB_RXC, PIN_AVB_RD0, > PIN_AVB_RD1, PIN_AVB_RD2, PIN_AVB_RD3, > PIN_AVB_TXCREFCLK, > - > }; > static const unsigned int avb_mii_mux[] = { > AVB_TX_CTL_MARK, AVB_TXC_MARK, AVB_TD0_MARK, > @@ -4515,7 +4514,6 @@ static const struct { > SH_PFC_PIN_GROUP(drif3_data0_b), > SH_PFC_PIN_GROUP(drif3_data1_b), > } > - > }; > > static const char * const audio_clk_groups[] = { > @@ -5104,7 +5102,6 @@ static const struct { > SH_PFC_FUNCTION(drif2), > SH_PFC_FUNCTION(drif3), > } > - > }; > > static const struct pinmux_cfg_reg pinmux_config_regs[] = { > diff --git a/drivers/pinctrl/renesas/pfc-r8a7796.c b/drivers/pinctrl/renesas/pfc-r8a7796.c > index 55f0344a3d3e..904c78c6c638 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a7796.c > +++ b/drivers/pinctrl/renesas/pfc-r8a7796.c > @@ -1731,7 +1731,6 @@ static const unsigned int avb_mii_pins[] = { > PIN_AVB_RX_CTL, PIN_AVB_RXC, PIN_AVB_RD0, > PIN_AVB_RD1, PIN_AVB_RD2, PIN_AVB_RD3, > PIN_AVB_TXCREFCLK, > - > }; > static const unsigned int avb_mii_mux[] = { > AVB_TX_CTL_MARK, AVB_TXC_MARK, AVB_TD0_MARK, > diff --git a/drivers/pinctrl/renesas/pfc-r8a77965.c b/drivers/pinctrl/renesas/pfc-r8a77965.c > index 7a50b9b69a7d..7db2b7f2ff67 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a77965.c > +++ b/drivers/pinctrl/renesas/pfc-r8a77965.c > @@ -1736,7 +1736,6 @@ static const unsigned int avb_mii_pins[] = { > PIN_AVB_RX_CTL, PIN_AVB_RXC, PIN_AVB_RD0, > PIN_AVB_RD1, PIN_AVB_RD2, PIN_AVB_RD3, > PIN_AVB_TXCREFCLK, > - > }; > static const unsigned int avb_mii_mux[] = { > AVB_TX_CTL_MARK, AVB_TXC_MARK, AVB_TD0_MARK, > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel