From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F2FC4361B for ; Wed, 16 Dec 2020 20:59:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 133A7230FF for ; Wed, 16 Dec 2020 20:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 133A7230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZzgOj1iCckj4k/JzZyYg/rPFX4mlL0NNDtedXcwa/qY=; b=ZZKibXpaItOJE+EsP2RxaUBPq 8g9/Cm93rxB0D5VKUKRxSwJFOnvRM0FUuWCcWKitgeXbQHctMJcgyI7UakixeKZFmtDogVduPaTPR OipDRAmk89TaqXgIal7zXr8PIyWwoeSsmJqbspLrqwfZkmpCLLPdb+8l32Ng/cX2bXlcfd6bmUMd/ l90vvShX799pRHJ9S9MfXb2h9DKzZ8KyQZ1exX55/DVKJDk42Xm8WGbVJPMk0dq83Z/DH003Tf/yE 1Lw+qMyY4//k3I1uPY8aQVE/HalGQx6oii9vS2j70baWZjo+niQMbOiXAvEAFjkb12kBcyPPiMgLe QF8cT7C0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpdrl-0000qF-4D; Wed, 16 Dec 2020 20:57:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpdri-0000pf-Ph for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 20:57:43 +0000 Date: Wed, 16 Dec 2020 12:57:40 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608152261; bh=viofYwz833+SXySywARvfU6DoIA9TUTOn97MKwUYtnE=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=BI887NRgaOuR+iwG6q094fMoxRDnUezJlQMZlS7fuKeNTqbigsW8DYVLUd2z/r6Y/ TuoSa9YSnP/v7+wJrIa0UU4PqHqhfActK7EvH56gfKJ6LCaXtplQYAKuoEDuFFjGU1 X2LkrfxwXzRMC/VHH6jB1hThcS1keWOlpj3Lmr/nkQ94ab6w/rVo82wvQun7c7KX9C 4WwJ4Z0Ex/R+07z18N7bEgjcOWBYT+Hd0UGFs8PmUPOGwiikOYhpzDHFUb3pX+WhVb 9m4u/RYO5Vr6dlbb9SOtrtgl7ilPNj0IH+jsffBPzb1V85w7Fy0OB6aHN4u3aoEmJg m+ofeKgybtLfQ== From: Eric Biggers To: linux-crypto@vger.kernel.org Subject: Re: [PATCH 5/5] crypto: arm/blake2b - add NEON-optimized BLAKE2b implementation Message-ID: References: <20201215234708.105527-1-ebiggers@kernel.org> <20201215234708.105527-6-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201215234708.105527-6-ebiggers@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_155742_909642_8BC1EF1A X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A . Donenfeld" , Herbert Xu , David Sterba , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 15, 2020 at 03:47:08PM -0800, Eric Biggers wrote: > +// Execute one round of BLAKE2b by updating the state matrix v[0..15] in the > +// NEON registers q0-q7. The message block is in q8..q15. The stack pointer > +// points to a 32-byte aligned buffer containing a copy of q8 and q9, so that > +// they can be reloaded if q8 and q9 are used as temporary registers. The macro > +// arguments s0-s15 give the order in which the message words are used in this > +// round. 'final' is "true" if this is the final round, i.e. round 12 of 12. > +.macro _blake2b_round s0, s1, s2, s3, s4, s5, s6, s7, \ > + s8, s9, s10, s11, s12, s13, s14, s15, final="false" [...] > + // Reloading q8-q9 can be skipped on the final round. > +.if \final != "true" > + vld1.8 {q8-q9}, [sp, :256] > +.endif > +.endm [...] > + _blake2b_round 14, 10, 4, 8, 9, 15, 13, 6, \ > + 1, 12, 0, 2, 11, 7, 5, 3, "true" Apparently using the strings "true" and "false" here sometimes causes a build error where they get treated as symbols (https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/2JPD4H3VFBSKWPUCPEPRAXBVMSR2UCQI/), though somehow it worked fine for me. I'll change this to use 1 and 0 instead. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel