From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D58C2BBD4 for ; Thu, 17 Dec 2020 22:35:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77536238A0 for ; Thu, 17 Dec 2020 22:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77536238A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S2ar7lXm8wu1Xks69hMKHTzuD9VQDvQWIzUtPV86XZw=; b=A2Kfn6oPX1u+WnxcM94b/aLoeF qPG15H4JWK2KeF0pnRYz04yWsYanVULMp4eXZBqVLTNP7mPLqUvhOPbqNBO9VwJXkexj2i6Op0uQU ytamYdth6qM3XSnCZQLQa66Jja1jMkotVbzESpCUuMNgEfEIwlBx6eNelYzwPvw9VwG/QpDdznGl7 WkluDdqHGTjpbo06PFgDMym7jEl6I9kDqFt3yPuhZMY022rMdPrEc42+7PWYUUQq3uoLaHuHbMjJe JXVl6tDmEj1rPb81VNG+H+ai5Efmr5rU1jfN+88r6nJzYa2HGi3K4sfZSMstkJRWtOlNtndxvubBx 1sGKpB3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kq1qU-0003oE-MG; Thu, 17 Dec 2020 22:34:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kq1qS-0003ns-5I for linux-arm-kernel@lists.infradead.org; Thu, 17 Dec 2020 22:34:00 +0000 Date: Thu, 17 Dec 2020 14:33:57 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608244439; bh=5M7rj1meNyW9IwwIxUZlzTnOJb4jcvakJ8gveMSjQQA=; h=From:To:Subject:References:In-Reply-To:From; b=t+uD4tVZRFXWawZeOpgFW5v+YEhufgYEgYc4cktCu0Yd4H+mu4D2vv7oC6opmtGQs TxfNXYoC7rtZ9ObjZQwJoXUZ1Shj6bVs69ucJgDT5x+YaIcZjcgmULcoeuVqVEWF8z f1bptHF4qjKAICZK+kNT8k6z1qXD/y1izdBn6bYMbbxMbERF3MZkYZT0pacLaRnWrD IvrF4QKSHyVNWtaOHQB1wsb3GVWT0z+rRLxNGo1BsbM2l9k/nO0YPg+MfS82r6vAnQ nyOHaub2pWXPAZiKfe9Cu9rHXSWHrhUA2kGYPuDFHLvnn0VGoxaP76F2Yv5Cunq7wZ uFmlzQ21ufPMg== From: Eric Biggers To: dsterba@suse.cz, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Herbert Xu , David Sterba , "Jason A . Donenfeld" , Paul Crowley Subject: Re: [PATCH 3/5] crypto: blake2b - export helpers for optimized implementations Message-ID: References: <20201215234708.105527-1-ebiggers@kernel.org> <20201215234708.105527-4-ebiggers@kernel.org> <20201217171540.GU6430@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201217171540.GU6430@suse.cz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201217_173400_349661_658FD41C X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 17, 2020 at 06:15:40PM +0100, David Sterba wrote: > On Tue, Dec 15, 2020 at 03:47:06PM -0800, Eric Biggers wrote: > > From: Eric Biggers > > > > In preparation for adding architecture-specific implementations of > > BLAKE2b, create a header that contains common > > constants, structs, and helper functions for BLAKE2b. > > > > Furthermore, export the BLAKE2b generic setkey(), init(), update(), and > > final() functions, and add functions __crypto_blake2b_update() and > > __crypto_blake2b_final() which take a pointer to a > > blake2b_compress_blocks_t function. > > > > This way, optimized implementations of BLAKE2b only have to provide an > > implementation of blake2b_compress_blocks_t. (This is modeled on how > > the nhpoly1305 implementations work. Also, the prototype of > > blake2b_compress_blocks_t is meant to be similar to that of > > blake2s_compress_arch().) > > > > Signed-off-by: Eric Biggers > > Reviewed-by: David Sterba I ended up making some changes to this patch in v2, to keep things consistent with what I decided to do for BLAKE2s, so I didn't add your Reviewed-by to this patch. If you could review the new version too that would be great -- thanks! - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel