From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54BB5C64ED8 for ; Mon, 27 Feb 2023 21:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mdQcZ8TbgXahE+bDz4hfYTQiMGC6A8S65wPWYrv7pdE=; b=zyDvMUfC2ZvmCM xoD2CXicQYej5mKO90zDCRPKz5wtbvI89b7FBCa7pMO2LnM89Q9ctFxmEhodVGPzIhF5TboBzaSMK eUxP9ZXn6kqbzGJ7f0zq6wy9m3MGD0EVd7TJKS4U91K8DncsQcWIbjhyoXW0CpP3+IHih2tBDuVPf NNuKzPPjBAyE7Uu8QiTCWjsNTvS+LCPTsCWBRKgxmbOtsyvs/Hl2BJRxHmVyji9dy+sRg9//+7kLE n2I/qFF93NOa85Iysp5IG1m2aXHyBDFADE28kfG2Sp+1TWK+isYPARJn/HOSnapIp5CAvUSbPTN+Q Pp0ioYnM8QLVcP2660Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWkbT-00BEqQ-0D; Mon, 27 Feb 2023 21:00:11 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWkbP-00BEpR-PL for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 21:00:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yxNQq6iAQdNqxHxg6xpTtkOHUc+Bubub8MOHjovJQps=; b=qyVfgukQMEl2DxmqtcwlmlPvAS zB0a5j0IaU+dxaa+FZ/IrkDC1aspPRZqLBVqU/IRHkrXqonSnmBFUMTmdh2tcYPrQSuypIAHnm0b1 5nq6HJBj0bHs+FMmFAGL7rFgfDSjnVnNau1zD4uX6PoNp/gn/PZqO9OJ+Q+t9IOSEgdIzGVjlnExq ivSxHAYdsaCHjb7xSXNSR5lKVZta2YosZU6uAKuG9E5SaeJyLyY0zgYZqWg4R35ZetWFvFy6ffs/f fxJv1XsiUiYUHph/6lWq07apbkvD7+RNGehLp3qdjHr8/OXCMR2nnTUD4VA1sa5QNJq1aXf7S0Q6j qzusSVVg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39650) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pWkbF-0003hx-So; Mon, 27 Feb 2023 20:59:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pWkbD-0001zh-G7; Mon, 27 Feb 2023 20:59:55 +0000 Date: Mon, 27 Feb 2023 20:59:55 +0000 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Larry Finger , Arnd Bergmann , Dominik Brodowski , linux-kernel@vger.kernel.org, Bjorn Helgaas , Florian Fainelli , Hartley Sweeten , Ian Abbott , Jakub Kicinski , Kevin Cernekee , Lukas Wunner , Manuel Lauss , Oliver Hartkopp , Olof Johansson , Robert Jarzmik , YOKOTA Hiroshi , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, Netdev Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus Message-ID: References: <20230227133457.431729-1-arnd@kernel.org> <3d8f28d7-78df-5276-612c-85b5262a987a@lwfinger.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_130007_846173_0BC2A60B X-CRM114-Status: GOOD ( 22.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 27, 2023 at 09:38:54PM +0100, Arnd Bergmann wrote: > On Mon, Feb 27, 2023, at 21:23, Larry Finger wrote: > > On 2/27/23 07:34, Arnd Bergmann wrote: > > > > > Your patch set also breaks my PowerBook G4. The output of 'lspci -nn | grep > > Network' shows the following before your patch is applied: > > > > 0001:10:12.0 Network controller [0280]: Broadcom Inc. and subsidiaries BCM4306 > > 802.11b/g Wireless LAN Controller [14e4:4320] (rev 03) > > 0001:11:00.0 Network controller [0280]: Broadcom Inc. and subsidiaries BCM4318 > > [AirForce One 54g] 802.11g Wireless LAN Controller [14e4:4318] (rev 02) > > > > The first of these is broken and built into the laptop. The second is plugged > > into a PCMCIA slot, and uses yenta-socket as a driver. > > > > When your patches are applied, the second entry vanishes. > > > > Yes, this hardware is ancient, but I would prefer having this wifi interface > > work. I can provide any output you need. > > Is this the Cardbus or the PCMCIA version of the BCM4306 device? As far > as I understand this particular chip can be wired up either way inside > of the card, and the PowerBook G4 supports both types of devices. > > If it's the PCMCIA version, then dropping support for it was the idea > of the patch series that we can debate, but if it was the Cardbus version > that broke, then this was likely a bug I introduced by accident. If it shows up as a PCI device, it will be cardbus, not 16-bit ISA. PCMCIA cards don't show up in lspci. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel