From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E4BDC05027 for ; Mon, 20 Feb 2023 10:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h/E8ClsJoX5KX6dC8RooMCcQCJMYXHnxOqdRsM8UXt0=; b=dAuMnF3oLOPyMp g0sRKGDyF0dhlc6zsUeBAwCvXEyPbjQ2I0S+Se5F90S7KAqZvSHKhsFLGB6A/A88Z0VufCByWb2wO CdlAMDrKuiKZiRrZf6XEtGEZxgc2SWJbtxLrtIaNS9fet0UKjgCQWxalQLqSxBOs6FQVtruXkAlfE TpSPmn5uZsWgHOXNZsW5iV4Vz7+4/QdR69PPOV0cxSiONVjALxHpx0DpBeESAZT8G7hAXR73tOJVN 1n4wWFHi7pz5dwYUbfsl9m+m22z9M8HPtkiXxJNxpx+Xm0EJ6drDh0B6pd93lwhe5tXchHYeK0fB5 0weJFqP2OwyXTEKzmH3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU31p-003aEb-KM; Mon, 20 Feb 2023 10:04:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU31k-003aE0-D6 for linux-arm-kernel@lists.infradead.org; Mon, 20 Feb 2023 10:04:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0335715BF; Mon, 20 Feb 2023 02:04:43 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.15.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 028983F703; Mon, 20 Feb 2023 02:03:58 -0800 (PST) Date: Mon, 20 Feb 2023 10:02:57 +0000 From: Mark Rutland To: Sangmoon Kim Cc: Catalin Marinas , Will Deacon , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: pass ESR_ELx to die() of cfi_handler Message-ID: References: <20230220073441.2753-1-sangmoon.kim@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230220073441.2753-1-sangmoon.kim@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_020408_573619_9FB7316A X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 20, 2023 at 04:34:41PM +0900, Sangmoon Kim wrote: > Commit 0f2cb928a154 ("arm64: consistently pass ESR_ELx to die()") caused > all callers to pass the ESR_ELx value to die(). > > For consistency, this patch also adds esr to die() call of cfi_handler. > Also, when CFI error occurs, die handlers can use ESR_ELx value. > > Signed-off-by: Sangmoon Kim Consistently reporting the ESR value makes sense to me, so: Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 0ccc063daccb..4a623e2e982b 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -990,7 +990,7 @@ static int cfi_handler(struct pt_regs *regs, unsigned long esr) > > switch (report_cfi_failure(regs, regs->pc, &target, type)) { > case BUG_TRAP_TYPE_BUG: > - die("Oops - CFI", regs, 0); > + die("Oops - CFI", regs, esr); > break; > > case BUG_TRAP_TYPE_WARN: > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel