From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A781C64EC4 for ; Mon, 20 Feb 2023 17:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3nraxGWWh3LGQMtiivhgd3BSHZuKHI/siwsgdrTzZ/k=; b=CqGN46DFMiVsko 0mzJA933nygY8Q6544yEqg3t8jAkIoSxCd2Jo6opbO0+cunzy5Pq8FMmsqWYvIWZUJALDnErZ2S9n fSSlEHWu55NOetwu06bndAwaMgzidGOfo9y5H8fEKLNwTcDpSh2VvBWIz8u7b/dM0nbjR08Pb8raj UINE94QduYr8gTJhqgJ4l1JpkCI5pM3B14E5o5QHWqi3ZcLx4jNhvsKMQsCweCctZlAegVJGq83bi zHMLejTXaWmktHXq/Oa0Q7tzIo1hWhHnG1C6DPS6XhUe63NWgERzynbpIs6gEj0Yr74G65/2noyK8 5efe39js1NJaU78Spn8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUAID-0056fZ-UG; Mon, 20 Feb 2023 17:49:38 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUAIA-0056dj-Ul; Mon, 20 Feb 2023 17:49:36 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pUAHy-00031I-00; Mon, 20 Feb 2023 18:49:22 +0100 Date: Mon, 20 Feb 2023 17:49:14 +0000 From: Daniel Golle To: Rob Herring Cc: Florian Fainelli , Eric Dumazet , Matthias Brugger , AngeloGioacchino Del Regno , Jianhui Zhao , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Sean Wang , "David S. Miller" , Mark Lee , Jakub Kicinski , =?iso-8859-1?Q?Bj=F8rn?= Mork , Vladimir Oltean , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Felix Fietkau , Russell King , Landen Chao , Rob Herring , Heiner Kallweit , John Crispin , Paolo Abeni , DENG Qingfang , Lorenzo Bianconi , Andrew Lunn , linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 03/12] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema Message-ID: References: <03f9d40849dd2d563a93b27732a7b5d7dd1defc5.1676910958.git.daniel@makrotopia.org> <167691325732.3971281.4378006887073697625.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167691325732.3971281.4378006887073697625.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_094935_024979_E5C932B1 X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Mon, Feb 20, 2023 at 11:15:53AM -0600, Rob Herring wrote: > > On Mon, 20 Feb 2023 16:41:16 +0000, Daniel Golle wrote: > > Convert mediatek,sgmiiisys bindings to DT schema format. > > Add maintainer Matthias Brugger, no maintainers were listed in the > > original documentation. > > As this node is also referenced by the Ethernet controller and used > > as SGMII PCS add this fact to the description. > > Move the file to Documentation/devicetree/bindings/pcs/ which seems more > > appropriate given that the great majority of registers are related to > > SGMII PCS functionality and only one register represents clock bits. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Daniel Golle > > --- > > .../arm/mediatek/mediatek,sgmiisys.txt | 25 ---------- > > .../bindings/net/pcs/mediatek,sgmiisys.yaml | 49 +++++++++++++++++++ > > 2 files changed, 49 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > > create mode 100644 Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/net/pcs/mediatek,sgmiisys.yaml# I simply didn't even consider that moving the file to its correct location may cause this kind of havoc. Please apologize, I'm quite new to this whole dt-schema game and still learning... > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/03f9d40849dd2d563a93b27732a7b5d7dd1defc5.1676910958.git.daniel@makrotopia.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I've fixed the wrong path now also within mediatek,sgmiisys.yaml itself. Result: [daniel@box linux.git]$ make dt_binding_check DT_SCHEMA_FILES=mediatek,sgmiisys HOSTCC scripts/dtc/util.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTCC scripts/dtc/checks.o HOSTLD scripts/dtc/dtc HOSTCC scripts/dtc/libfdt/fdt.o HOSTCC scripts/dtc/libfdt/fdt_ro.o HOSTCC scripts/dtc/libfdt/fdt_wip.o HOSTCC scripts/dtc/libfdt/fdt_sw.o HOSTCC scripts/dtc/libfdt/fdt_rw.o HOSTCC scripts/dtc/libfdt/fdt_strerror.o HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o HOSTCC scripts/dtc/libfdt/fdt_addresses.o HOSTCC scripts/dtc/libfdt/fdt_overlay.o HOSTCC scripts/dtc/fdtoverlay.o HOSTLD scripts/dtc/fdtoverlay LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.example.dts DTC_CHK Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.example.dtb I'll wait for more potentials comments on the series and re-submit tomorrow. Thank you! Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel