linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: spitz: include header defining input event codes
@ 2023-02-21 21:59 Dmitry Torokhov
  2023-02-23  9:09 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2023-02-21 21:59 UTC (permalink / raw)
  To: Daniel Mack, Haojian Zhuang, Robert Jarzmik
  Cc: Russell King, Arnd Bergmann, linux-arm-kernel, linux-kernel

The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_*
defines, but does not include the relevant header directly and instead
relies on other headers to include it indirectly. With the upcoming
cleanup of matrix_keypad.h this indirection is now broken and we should
include the relevant header directly.

Reported: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

If there are no objections to this patch I would like to get it through
my tree. Thanks!

 arch/arm/mach-pxa/spitz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 9964729cd428..75634ef6688d 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -25,6 +25,7 @@
 #include <linux/spi/pxa2xx_spi.h>
 #include <linux/mtd/sharpsl.h>
 #include <linux/mtd/physmap.h>
+#include <linux/input-event-codes.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/regulator/machine.h>
 #include <linux/io.h>
-- 
2.39.2.637.g21b0678d19-goog


-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: spitz: include header defining input event codes
  2023-02-21 21:59 [PATCH] ARM: spitz: include header defining input event codes Dmitry Torokhov
@ 2023-02-23  9:09 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2023-02-23  9:09 UTC (permalink / raw)
  To: Dmitry Torokhov, Daniel Mack, Haojian Zhuang, Robert Jarzmik
  Cc: Russell King, linux-arm-kernel, linux-kernel

On Tue, Feb 21, 2023, at 22:59, Dmitry Torokhov wrote:
> The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_*
> defines, but does not include the relevant header directly and instead
> relies on other headers to include it indirectly. With the upcoming
> cleanup of matrix_keypad.h this indirection is now broken and we should
> include the relevant header directly.
>
> Reported: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> If there are no objections to this patch I would like to get it through
> my tree. Thanks!

Yes, that's fine,

Acked-by: Arnd Bergmann <arnd@arndb.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-23  9:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-21 21:59 [PATCH] ARM: spitz: include header defining input event codes Dmitry Torokhov
2023-02-23  9:09 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).