From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E6E7C61DA4 for ; Wed, 22 Feb 2023 10:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lHtEk4AuMMA7TsCrMZ9RmRkQ4zqAfAtRIVbZXjDd+9M=; b=txKeelN35UDQu789Cpy5Fixuhp Bk1V24BZIHbUoW7mHas5Mv2aPyxtqsvAhRFx/HXZSJWQ7+DSedVyhdSKMnZYtL5Dpwpq5A6p2JdDq QNcg5pVnKbMJtEUINdI38fZAcWWxmYj4FnZimCbxEZa2O9ibyu81wZKX5NTyBQEtj0jSOK+ywju1W tmHtLfjTCH3l6RBBdEYkDpT3Lw8HPo+qWmjP0DDuno3DiCVN+cqw2Oy+95qYOHeTcl2qU9ZZzVmyK XUezqZwr8ItV7uAbX9zFebuCgATJxJiRRrVG9K9LSolEsjWFc6Sm7JrORezcNeVjS6YthuxqnHb5H ZuGD0BcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUmQ0-00BxGW-Rd; Wed, 22 Feb 2023 10:32:13 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUluF-00Bh08-7X for linux-arm-kernel@lists.infradead.org; Wed, 22 Feb 2023 09:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1677059963; x=1708595963; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N2hk9GlJCT2NgITlKoyZMXhacfZJstXnR+eEKJSowwk=; b=NyKjH4Zj+G+ryDlGcoqbxorxNvX/qEe76XiNOPKk6kKy5APl9Xtefw+0 5vOG7CDFUs3yhhKvFLAt6Te90F16C0PsqnC7/FgZVDOYy7u4sgzdLjVS5 /BU6+KccS+cCktS4YDznl6+W2M7P+7n78wfJocyPzKd+A3ZvGvUwRaH2U 3slTpG7BdCK+M9zs+PSREa7w8E68ta5CBXVFRiNYi5deSdtQM9IjOkSod /9qo67CopZKnmapEoRClHhsN8lAtEgSKXjNaM36tlpuHJ9/Ao00r2+n+c t9+M2RvXqxX1t6y3v2giO/saWyeHac3FFCFfz33Ep8vXLIY9a8kSNqRqR w==; X-IronPort-AV: E=Sophos;i="5.97,318,1669100400"; d="asc'?scan'208";a="138447304" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Feb 2023 02:59:19 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 02:59:17 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 02:59:14 -0700 Date: Wed, 22 Feb 2023 09:58:48 +0000 From: Conor Dooley To: Sakari Ailus CC: shravan kumar , , , , , , , , , , , , , , , Jacopo Mondi , Prakash Battu Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode Message-ID: References: <20230208050915.1958183-1-shravan.chippa@microchip.com> <20230208050915.1958183-4-shravan.chippa@microchip.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230222_015923_390302_430C1806 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0044889238014629289==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0044889238014629289== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6BcYyEiurpuctdJY" Content-Disposition: inline --6BcYyEiurpuctdJY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote: > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote: > > From: Shravan Chippa > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev= *sd, > > struct v4l2_subdev_format fmt =3D { 0 }; > > =20 > > fmt.which =3D sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_= ACTIVE; > > - imx334_fill_pad_format(imx334, &supported_mode, &fmt); > > + imx334_fill_pad_format(imx334, &supported_modes[0], &fmt); >=20 > Now that there are multiple modes supported, this would appear to get the > width, height as well as the other fields (apart from mbus code) from the > first mode. Is this statement supposed to be a request to change something, or just a throwaway comment? It's a little hard for me to understand your intention here, sorry. > > =20 > > return imx334_set_pad_format(sd, sd_state, &fmt); > > } > > =20 --6BcYyEiurpuctdJY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY/XnWAAKCRB4tDGHoIJi 0pMEAQDF93yO1Y4hUi+49FMYt5ZCrzx5No5+sGSuHEFB/uLh+wEAnElojzoqotU6 PpeozsTZGz3d6VWaC32WOscjSMhGFgk= =UzAQ -----END PGP SIGNATURE----- --6BcYyEiurpuctdJY-- --===============0044889238014629289== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0044889238014629289==--