From: Catalin Marinas <catalin.marinas@arm.com>
To: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org
Subject: Re: Cortex A15: Errata 798181: Moving a virtual page that is being accessed by an active process can lead to unexpected behavior
Date: Wed, 22 Feb 2023 12:07:59 +0000 [thread overview]
Message-ID: <Y/YFn+yQTMSOX1jx@arm.com> (raw)
In-Reply-To: <60195c8c-8efd-e31b-0da2-ab40b13f5fe5@nokia.com>
On Wed, Feb 22, 2023 at 10:07:23AM +0100, Matija Glavinic Pecotic wrote:
> I have noticed that we are using local_flush_tlb_kernel_range
> in couple of places while errata from subject is applied in
> flush_tlb_kernel_range. We have local_flush_tlb_kernel in:
>
> section_update
> __set_fixmap
> set_top_pte
> #define arch_kmap_local_post_map local_flush_tlb_kernel_page
> - arch_kmap_local_post_map is further used around kmap
>
> I would like to double check this is safe. From errata itself,
> I cannot make up whether it depends to context, I have impression
> it doesnt, and one should apply it even in e.g. when map/unmap
> is done in interrupt.
>
> I hope you still remember this topic. Would you please be able
> to help to clarify whether applying it depends to context?
IIRC this erratum is problematic only when there are concurrent CPUs
still accessing the mapping being modified. That's usually when touching
user pages (e.g. for migration, write-back) and the kernel either goes
through a break-before-make sequence or changes the PTE permissions. I
don't think any of the functions you mentioned fall into this category
(of concurrent accesses to the VA being unmapped).
I found the erratum on page 28 in this document:
https://documentation-service.arm.com/static/5fb64a3bd77dd807b9a80852
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-22 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 9:07 Cortex A15: Errata 798181: Moving a virtual page that is being accessed by an active process can lead to unexpected behavior Matija Glavinic Pecotic
2023-02-22 12:07 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/YFn+yQTMSOX1jx@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=matija.glavinic-pecotic.ext@nokia.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).