From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB78BC61DA4 for ; Thu, 23 Feb 2023 12:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tPe6p8RF0rdqApxgZEvALTQmZI6yrEDaQnFHJAlzWno=; b=iLECUVSgBt66Yd avoLp0T4MqmL0G3HE1sig1SqusC2r7i9YZpH6uJBF7Z2GtJZOEDxIpJXVSUMzHA03b7lxUGUgnwvU xTGKmWr3TIkxcv9htGOVJcsKoTpzZcsVjvOcc9eRDT5CIE+gqaZBQkXvlsNGY4vetVXuU37VMR/Jl +HQiMeN/OYg8sEEO1fL8kQlKXWXISEdtE6IKdQi2NNaPTZNb/+bOYdQ9Qcrkx/oTk/9H3pTJxAIQS sOD3vOq9Gzbl+AvMaFkI72na5xyMFy+yN9pPHTK/tNo8sMShVJrRM6flz3UsCVgAt6zCg5re+/wkw vZFY7Jlv1RbivjAfXQzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVAig-00GIbb-Lz; Thu, 23 Feb 2023 12:29:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVAic-00GIZE-Ux for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 12:29:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17919C14; Thu, 23 Feb 2023 04:29:36 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6155E3F881; Thu, 23 Feb 2023 04:28:52 -0800 (PST) Date: Thu, 23 Feb 2023 12:28:46 +0000 From: Cristian Marussi To: Dan Carpenter Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: return a literal instead of a variable Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_042903_084174_C35189C1 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 22, 2023 at 06:17:06PM +0300, Dan Carpenter wrote: > In this context "return scmi_dev;" and "return NULL;" are equivalent > but it is more readable to return a literal. > > Signed-off-by: Dan Carpenter > --- > drivers/firmware/arm_scmi/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c > index 73140b854b31..ac306ca48b07 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -436,7 +436,7 @@ struct scmi_device *scmi_device_create(struct device_node *np, > /* Nothing to do. */ > if (!phead) { > mutex_unlock(&scmi_requested_devices_mtx); > - return scmi_dev; > + return NULL; > } > > /* Walk the list of requested devices for protocol and create them */ LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel