From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DAA3C64ED8 for ; Mon, 27 Feb 2023 12:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WOQFWXLC+fYKlBIxgE5Gk+LV8XHlGoSebsi6huXecJQ=; b=T5BDpkl/sK8oCW WcUxIzhEHDjiEX1RVTRyavwA2a+RvmFarrYy6qZlC+1bykZAPxKJApFOJxXc942pdkVqke2I70ftv 1yTW0E67jKc3mL26oTO+MQbg+1SKiiaOejanLq1g/Y2Fy/c9mfN+nrzKEZp+aSi++nEX44ojzdnYr fx/7st/+Dm7GkbCuYTVtgsyVhLT/MCTENX9AiVlCyF6LFQa1pkKfUBSrnsR+6x69krCBtyvTTqduR I02spjW7GU1zP/tGD/R7q2bT7LxKEd5KA//rUjvunhp+hBmPaydi57yWj4SlKnXitiJh/FES8h8wS jWfP04oJinM0MYumyoGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWcKh-009YgO-ST; Mon, 27 Feb 2023 12:10:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWcKd-009Yfa-Vd for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 12:10:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C82B1C14; Mon, 27 Feb 2023 04:10:55 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.17.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 869693F67D; Mon, 27 Feb 2023 04:10:11 -0800 (PST) Date: Mon, 27 Feb 2023 12:10:05 +0000 From: Mark Rutland To: Florian Fainelli Cc: Marc Zyngier , linux-arm-kernel , Catalin Marinas , rostedt@goodmis.org, Stefan Wahren Subject: Re: Misaligned patch-site bcm2836_arm_irqchip_handle_irq+0x0/0x88 Message-ID: References: <2d9284c3-3805-402b-5423-520ced56d047@gmail.com> <87a612do8x.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_041016_085966_9B82188E X-CRM114-Status: GOOD ( 23.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 27, 2023 at 11:32:22AM +0000, Mark Rutland wrote: > Hi Florian, > > On Sat, Feb 25, 2023 at 07:26:50AM -0800, Florian Fainelli wrote: > > On 2/25/2023 2:37 AM, Marc Zyngier wrote: > > > On Fri, 24 Feb 2023 23:39:24 +0000, > > > Florian Fainelli wrote: > > > > > > > > Hello, > > > > > > > > You will find a complete boot log [1] below that shows the failure as > > > > well as the configuration file [2], however I am hitting what you see > > > > below as of v6.2-10217-ga93e884edf61. Have not tried linux-next yet, > > > > so if this is a known issue, please ignore :) > > > > > > > > This is seen with on a Raspberry pi 4B running in AArch64 mode. > > > > > > > > [1]: https://gist.github.com/b1a977b5fea837d180ccb800f091218a > > > > [2]: https://gist.github.com/64cf18b6ee770d58f64371e1db01afb9 > > > > > > From the config file: > > > > > > CONFIG_ARM=y > > > > > > Can you please provide the config file for the build you're seeing > > > this on? > > > > Yes, sorry about that, here is the 64-bit configuration: > > > > https://gist.github.com/4eb83740c25b10f75b54560f8c8febb1 > > I think the problem here is: > > CONFIG_CC_OPTIMIZE_FOR_SIZE=y > > ... since GCC is known to ignore function alignment when -Os is passed. > > We can have DYNANMIC_FTRACE_WITH_CALL_OPS depend on > !CONFIG_CC_OPTIMIZE_FOR_SIZE to prevent that. I've sent out a patch updating arm64's Kconfig to handle this, which should appear at: https://lore.kernel.org/linux-arm-kernel/20230227115819.365630-1-mark.rutland@arm.com ... once lore next updates. In local testing with GCC 11.3.0 and CONFIG_CC_OPTIMIZE_FOR_SIZE=y that did the right thing and disabled CONFIG_DYNAMIC_FTRACE_WITH_CALL_OPS (and consequently removed the warning). Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel