From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6E58C636D4 for ; Wed, 15 Feb 2023 21:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=To+q24taIni5TcU7Ha+kGnCcovWSq2qAOiCkjYsIjjw=; b=Z+gPj+Q4/t5Yxd QY++zoVDyuh95lBSn5LCYTRbXjLJ+4sFedIvzSYZInyPSqnlvv6FYxNzBPU7mvsINZBv6yLdFl12g VlzXPDXIX2OfINVw2oJIUyD2P5NSp3IRZoLhIQkolb50rVh2mlC7zzIXbmey9XZfCN361WCPNw+Db LPIe9g2ZuvxoHK9lpy2qvN0Y/vi3ChO9tVNB0aMc+bd3yoPhdczF2wXTyukDMXkLqY4WmcVUYA1zc 0Mp294D1zsayVXx8LqpGNCK4LPgmcq0r8FrTin1T+nHGhQofmKN/ikh7FdGuphYzW9IX2UPpU9Cww sjQBrvAXdo+F+JSeCJ1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSPDB-007WMP-Ir; Wed, 15 Feb 2023 21:21:09 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSPBM-007VMS-5o; Wed, 15 Feb 2023 21:19:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s06QXZD2epJvazS97JjdTPMJBT7sTvjcgysko1ATtgA=; b=NMcuXd8Ik0RHOiEU2KR8jg9qf2 VHxQ8HugeYVJCssmdeMYaossBfogChl4HasI/+CTFM93kEbkatfZHenGbL/nNl6SmNG+c7uOZLOrh nEZo+gL0enL1Zly6rasRchDwcMPQeW81zcn831RFSy2c3aWqedpeB0OMmL+t83h88gJKOgC84p+Oi bW3vRiZ9qSlD0kJ50ciAQIZtFRq4MagEOLsxlF+o2MSgEb5jZaNj3Chlwlz2Qy2SruCLkcOKhuVIl FV4HqljJsGsImRw1Kpspold5GzkPQchuiQKmcJq4iHCPe72wWK8B1KDfVlrtX1PaKJOisQaJ52C5S jrW6MyRA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55894) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pSPBG-0007Gq-Ka; Wed, 15 Feb 2023 21:19:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pSPBF-0005D3-Db; Wed, 15 Feb 2023 21:19:09 +0000 Date: Wed, 15 Feb 2023 21:19:09 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v7 00/12] net: ethernet: mtk_eth_soc: various enhancements Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_131916_270366_F6645B86 X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, Please don't be so quick to send the next revision as soon as you receive comments on a series - as has just been demonstrated, I've replied to Rob's comment about moving the binding to clocks which I don't agree with having read the documentation. Posting a new series so quickly cuts off any hope of a sensible discussion, and leads to people having to scramble to say "no, we're still discussing the previous series" to possibly prevent netdev applying the patches before the discussion has reached a conclusion. Thanks. On Wed, Feb 15, 2023 at 08:59:37PM +0000, Daniel Golle wrote: > This series brings a variety of fixes and enhancements for mtk_eth_soc, > adds support for the MT7981 SoC and facilitates sharing the SGMII PCS > code between mtk_eth_soc and mt7530. > > Note that this series depends on commit 697c3892d825 > ("regmap: apply reg_base and reg_downshift for single register ops") to > not break mt7530 pcs register access. > > The whole series has been tested on MT7622+MT7531 (BPi-R64), > MT7623+MT7530 (BPi-R2) and MT7981+GPY211 (GL.iNet GL-MT3000). > > Changes since v6: > * label MAC MCR bit 12 in 08/12, MediaTek replied explaining its function > * move mediatek,sgmiisys bindings to > Documentation/devicetree/bindings/clock > > Changes since v5: > * drop dev pointer also from struct mtk_sgmii, pass it as function > paramter instead > * address comments left for dt-bindings > * minor improvements to commit messages > > Changes since v4: > * remove unused dev pointer in struct pcs_mtk_lynxi > * squash link timer check into correct follow-up patch > > Changes since v3: > * remove unused #define's > * use BMCR_* instead of #define'ing our own constants > * return before changing registers in case of invalid link timer > > Changes since v2: > * improve dt-bindings, convert sgmisys bindings to dt-schema yaml > * fix typo > > Changes since v1: > * apply reverse xmas tree everywhere > * improve commit descriptions > * add dt binding documentation > * various small changes addressing all comments received for v1 > > > Daniel Golle (12): > net: ethernet: mtk_eth_soc: add support for MT7981 SoC > dt-bindings: net: mediatek,net: add mt7981-eth binding > dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema > dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC > net: ethernet: mtk_eth_soc: set MDIO bus clock frequency > net: ethernet: mtk_eth_soc: reset PCS state > net: ethernet: mtk_eth_soc: only write values if needed > net: ethernet: mtk_eth_soc: fix RX data corruption issue > net: ethernet: mtk_eth_soc: ppe: add support for flow accounting > net: pcs: add driver for MediaTek SGMII PCS > net: ethernet: mtk_eth_soc: switch to external PCS driver > net: dsa: mt7530: use external PCS driver > > .../arm/mediatek/mediatek,sgmiisys.txt | 27 -- > .../bindings/clock/mediatek,sgmiisys.yaml | 55 ++++ > .../devicetree/bindings/net/mediatek,net.yaml | 52 ++- > MAINTAINERS | 7 + > drivers/net/dsa/Kconfig | 1 + > drivers/net/dsa/mt7530.c | 277 ++++------------ > drivers/net/dsa/mt7530.h | 47 +-- > drivers/net/ethernet/mediatek/Kconfig | 2 + > drivers/net/ethernet/mediatek/mtk_eth_path.c | 14 +- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 67 +++- > drivers/net/ethernet/mediatek/mtk_eth_soc.h | 105 +++--- > drivers/net/ethernet/mediatek/mtk_ppe.c | 114 ++++++- > drivers/net/ethernet/mediatek/mtk_ppe.h | 25 +- > .../net/ethernet/mediatek/mtk_ppe_debugfs.c | 9 +- > .../net/ethernet/mediatek/mtk_ppe_offload.c | 8 + > drivers/net/ethernet/mediatek/mtk_ppe_regs.h | 14 + > drivers/net/ethernet/mediatek/mtk_sgmii.c | 192 ++--------- > drivers/net/pcs/Kconfig | 7 + > drivers/net/pcs/Makefile | 1 + > drivers/net/pcs/pcs-mtk-lynxi.c | 303 ++++++++++++++++++ > include/linux/pcs/pcs-mtk-lynxi.h | 13 + > 21 files changed, 802 insertions(+), 538 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,sgmiisys.yaml > create mode 100644 drivers/net/pcs/pcs-mtk-lynxi.c > create mode 100644 include/linux/pcs/pcs-mtk-lynxi.h > > > base-commit: 9d9019bcea1aac7eed64a1a4966282b6b7b141c8 > -- > 2.39.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel