From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A57B9C636CC for ; Thu, 16 Feb 2023 18:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iSfLEAYtMtb+BzmKoK8aBMHhfBQAFo0eV2+RA/K07UI=; b=K2+EWHyo5c58Dh 4kM39mY3kFyxqq2j2uEVKE6vCntm+N+YRJlgP6blRGxwER3FDD66kI6nRWlfvtqRIYIICO9+JTNds PIMwk/q3jxjypFBJIsAI6yZCCkv9QAgqQGhgBAZv52a8BrI3GadhxSbsIbY5ZrpLung9CtFm+MH56 s0wDnT15+PQS2ytBSVIXWjCfIhjMkc9uIqe7vDuR3chRPxDAEXvTDSbPZ22m2ScAfvW3sYtmNyt+6 SOG7AW0FOpPaxeAzjDXftdejap01BnNN/+91BUGecWF2LZdOJrBNI6mL6UPLQOci+PIEbnkvtFxsJ NvKfUCyj4zA/dQiQD5fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSjNH-00BaVK-8G; Thu, 16 Feb 2023 18:52:55 +0000 Received: from out-250.mta0.migadu.com ([91.218.175.250]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSjND-00BaTQ-0z for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 18:52:52 +0000 Date: Thu, 16 Feb 2023 18:52:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1676573564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5lPRC8tmGimX6FoQOFDeJ1uZHoOJugMk+ARxbS2GtZQ=; b=l+yv2brXXB4KEmbfMLFMyYWIY03iFg1/9qdwMkykUes07nXneAy4rNHQaMdlvCX5KBOfDp BRUL8yID+Jbu/Oo0W0OKCBiS4NBxOwgyozdCBSgVZrLBBzZoPH/ep8BXCuF04LV9LfiamD h0VESjw0hblh1ivqU6vArCnVSRfERrQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: James Morse Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier Subject: Re: [RFC PATCH 0/3] arm64: errata: Disable FWB on parts with non-ARM interconnects Message-ID: References: <20230216182201.1705406-1-james.morse@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230216182201.1705406-1-james.morse@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_105251_524568_36BA0BA5 X-CRM114-Status: GOOD ( 22.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On Thu, Feb 16, 2023 at 06:21:58PM +0000, James Morse wrote: > Hello! > > When stage1 translation is disabled, the SCTRL_E1.I bit controls the > attributes used for instruction fetch, one of the options results in a > non-cacheable access. A whole host of CPUs missed the FWB override > in this case, meaning a KVM guest could fetch stale/junk data instead of > instructions. > > The workaround is to disable FWB, and do the required cache maintenance > instead. > > The good news is, this isn't a problem for systems using Arm's > interconnect IP. The bad news is: linux can't know this. Arm knows of > at least one platform that is affected by this erratum. > > > This series adds support for the 'Errata Management Firmware Interface', [0] > and queries that to determine if the CPU is affected or not. > > Unfortunately, no-one has firmware that supports this new interface yet, > and the least surprising thing to do is to enable the workaround by default, > meaning FWB is disabled on all these cores, even for unaffected platforms. > Platforms that are not-affected can either take a firmware-update to support > the interface, or if the kernel they run will only run on hardware that is > unaffected, disable the workaround at build time. Wait, what? Is there a legitimate concern that affected systems are in the wild today, or is there enough time for affected platforms to go and implement the necessary firmware interface? Requiring correctly implemented systems to explicitly opt-out seems like quite a lot more work (w/ low likelihood) than having the one known platform go about this the right way. I'm rather troubled by the idea of enabling this by default on systems that use these cores unless there really is no opportunity to course-correct. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel