From: Wolfram Sang <wsa@kernel.org>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "Verdun, Jean-Marie" <verdun@hpe.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"joel@jms.id.au" <joel@jms.id.au>
Subject: Re: [PATCH v4 1/5] i2c: hpe: Add GXP SoC I2C Controller
Date: Thu, 16 Feb 2023 21:47:33 +0100 [thread overview]
Message-ID: <Y+6WZT4KtqQ2Wg9o@ninjato> (raw)
In-Reply-To: <63020BDF-DD97-4828-B464-8DFF94A2B794@hpe.com>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
Hi Nick,
> I will work on the defines and get rid of all the magic values.
Cool, thank you!
> Unfortunately, there is no public spec available currently.
> Hopefully, we will have one someday though.
Then, the #defines are even more helpful!
> > drivers/i2c/busses/i2c-gxp.c: In function ‘gxp_i2c_probe’:
> > drivers/i2c/busses/i2c-gxp.c:533:28: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> > 533 | drvdata->engine = ((u32)drvdata->base & 0xf00) >> 8;
>
> I am currently unable to reproduce this error. I even set W=2.
Interesting. I have this version:
gcc (Debian 10.2.1-6) 10.2.1 20210110
> Would replacing (u32) with (unsigned long) resolve it?
Or size_t.
Happy hacking,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 18:44 [PATCH v4 0/5] ARM: Add GXP I2C Support nick.hawkins
2023-01-25 18:44 ` [PATCH v4 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins
2023-02-15 20:29 ` Wolfram Sang
2023-02-16 20:02 ` Hawkins, Nick
2023-02-16 20:47 ` Wolfram Sang [this message]
2023-01-25 18:44 ` [PATCH v4 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins
2023-01-25 21:18 ` Rob Herring
2023-01-25 21:31 ` Hawkins, Nick
2023-01-26 13:38 ` Rob Herring
2023-01-25 18:44 ` [PATCH v4 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins
2023-01-25 18:44 ` [PATCH v4 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins
2023-01-25 18:44 ` [PATCH v4 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins
2023-01-28 18:38 ` Wolfram Sang
2023-02-07 21:53 ` Hawkins, Nick
2023-02-15 19:26 ` Hawkins, Nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+6WZT4KtqQ2Wg9o@ninjato \
--to=wsa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox