From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FB3CC05027 for ; Fri, 17 Feb 2023 09:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+vjUWcmEP6JYaD7wO5/6WViU9QszRiwbyGzxSSD/6Z4=; b=D/0r6Hr3QUqejd mWnskEciKjYk57VG+7rHhScwOP6K8pzFWYzerAiv3mLywkfiju7v+D/lfqAZeJbXPCELjfg/Z28UK T+WddzqyI3UydZvaX7sOabEE/Eb8bhNcwUzbAJSBb+UmNPzlhn2bhPkuU98RjtiG3d7XwyWHeCc1n 8vtE/RfZ6TqNZEPXac17Hsww1IiCd7xNX1knfgSeeIVWsGHINkT9EUpDG70LdccXOnf/B/08aadwR Usl6ZEnfDZwnMd8ywETnE9VY1KnniF2L/HEmpRKGUqg5cATYNiX0rY6XYX9EXSC/88M7CJBjIabvC lFjPzkxSFNHaKr9b3+JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSwbw-00DOIg-Hk; Fri, 17 Feb 2023 09:00:56 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSvUz-00D9nS-Kg for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 07:49:43 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 202B880C1; Fri, 17 Feb 2023 07:49:39 +0000 (UTC) Date: Fri, 17 Feb 2023 09:49:37 +0200 From: Tony Lindgren To: Linus Walleij Cc: Mun Yew Tham , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , Alban Bedel , Orson Zhai , Baolin Wang , Chunyan Zhang , Jay Fang , Daniel Palmer , Romain Perier , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , William Breathitt Gray , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-omap@vger.kernel.org, Marc Zyngier Subject: Re: [PATCH 15/17] gpio: omap: Convert to immutable irq_chip Message-ID: References: <20230215-immutable-chips-v1-0-51a8f224a5d0@linaro.org> <20230215-immutable-chips-v1-15-51a8f224a5d0@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230215-immutable-chips-v1-15-51a8f224a5d0@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_234941_753808_5E1AE177 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Linus Walleij [230216 09:38]: > Convert the driver to immutable irq-chip with a bit of > intuition. > > This driver require some special care: .irq_ack() was copied > from dummy_irq_chip where it was defined as noop. This only > makes sense if using handle_edge_irq() that will unconditionally > call .irq_ack() to avoid a crash, but this driver is not ever > using handle_edge_irq() so just avoid assigning .irq_ack(). > > A separate chip had to be created for the non-wakeup instance. Nice, works for me. BTW, I still see these warnings remaining on boot: gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation. Seems like we might be able to get rid of those too now or are there still some dependencies with /sys/class/gpio for example? Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel