From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F0ECC636CC for ; Mon, 6 Feb 2023 00:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nrncnB2lbqINa6y24rryiQyfY/G8Eu+0VmezJZg6fyU=; b=H7+TgvppuVcfKX PFNZ9URDnWxvU7GeDfAcaem5hb9ZooJwty8P3C7S7FoKb0pvg9tnem8ix4ps63PFkCfCiRAsCJegs 4qzkPOpaybZe6MEMgsa0gb/B/9iDNWsieCOLn6tgRSghC67NmaTa37TESUsszq7Uj2mQXwUgtj8O2 3NbqyrZdowBpfQqznmwzohm5C/u7jrXM1fYyEN/QGvW6Biy/z2domfdiV6H9EDEoAiek8djbChqqd Stk2yLj8s37mBCYQqEK/2sBRHsXjDr3Od0sbL6WuJm+8gzYzR9s/REBJWzalU3OaTXWuRi0JcTBI0 izCPcsonEB8kJNl3SgXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOp66-0072E4-6v; Mon, 06 Feb 2023 00:11:02 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOp64-0072Dg-Ow for linux-arm-kernel@bombadil.infradead.org; Mon, 06 Feb 2023 00:11:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rGSaCbdLvJLIXU4diqo8Az/pvlwzPHqyC8mVLdkgmVs=; b=wQwn+cTYGhjeIQzkhRGa2nUWly qYw+9p/37SKqb+atz8pOYcdUXhEpdCm4hpif6nv5xWdmZ4IPvrilZjWRNA+Wqtf/vuG9djjBMGX4t Daee7IzYAIZh6dMwqOftfSAlIXLk6lFLaaX6VHpRGZ207Xf/lA1BV651u4V5zIA1QLMikOzYRHNmf b0usFOi4WDyAPKftj5wTS/OyxHd+7t9ljT2PfT/Upl4noMYHLabBTRNnrOqjV09ETRIliFyCIx1r2 kmVArxQgmKVg1Htm1C5fQPwobTOoR1LC+GbwKJBLA+qJck/Ede5ly6QoUBmLkL6dKtZlKHj60xTcr VUCWbhOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOp5x-00GJrn-6g; Mon, 06 Feb 2023 00:10:53 +0000 Date: Mon, 6 Feb 2023 00:10:53 +0000 From: Matthew Wilcox To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Message-ID: References: <20230205231704.909536-1-peterx@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230205231704.909536-1-peterx@redhat.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 05, 2023 at 06:17:01PM -0500, Peter Xu wrote: > I noticed a few collision usage on VM_FAULT_* definition in the page fault > path on arm/arm64/s390 where the VM_FAULT_* can overlap with the generic > definition of vm_fault_reason. > > The major overlapped part being VM_FAULT_HINDEX_MASK which is used only by > the hugetlb hwpoisoning. > > I'm not sure whether any of them can have a real impact, but that does not > look like to be expected. I didn't copy stable, if anyone thinks it should > please shoot. Nor did I test them in any form - I just changed the > allocations from top bits and added a comment for each of them. This seems like a bad way to do it. Why not just put these VM_FAULT_* definitions in linux/mm_types.h? Then we'll see them when adding new VM_FAULT codes. Sure, they won't be used by every architecture, but so what? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel