From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 957B8C636D6 for ; Mon, 6 Feb 2023 03:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PdQz0RwcpU1ASLIcM0x9i9xvf3mXrzyxzmiCFpuUKcA=; b=KUiKq+jXhzXqmW JL4m/0vklVgbsiA5K9yvx4FBBjqeNSd+OLQeouWMlWTpY2UX410R+2dcYDKcSz/aJi9f/lsT0klcy vyk39dZPCFGQENVwe4oI6ugvWjiBFfzYlkCsKJefM8CyXn+I0oIAdND2lEOOIdKxgq+coI2CHCXrZ bM96VQ9FACn4pBMQ/ekkGy9LByCvAyhCnT5n6gH1XleagtD+cyVs/aoXvoUCJVBUDdzuekqDT2Kub dVA+LIkXlcJCZrOV/m8xmMBsI4rwqD8xQTIxyMFAFUSWhEzS2AQfCFgKZIBIU36Z5NNyHLCMMiuO5 wb1eAPSsp7Gtw53Y8sOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOs1g-007G92-SF; Mon, 06 Feb 2023 03:18:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOs1c-007G7q-Vl for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 03:18:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675653514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HUnXR7sTsl7YLdib1oIsNCKOxnTEFsrq4tcNXVLT5m4=; b=fsVeQD5HhgDtw0OANPTWFjLM19HiDP6eXKL4vunRkM50YKlk4Se603vfacpQQ/TmPolqDf 7liXh6ZDSiv6H/oDyY4s0xCTT6PrstSHqG/qN6xdbz7b0lQkFSyVI5h84jEuEVwf3Nqj5n jI9eDDsJmexHI+CzZbbQxwCCqDW6UjQ= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-557-tiEKz8rDPy-x4IY-t5JUkg-1; Sun, 05 Feb 2023 22:18:32 -0500 X-MC-Unique: tiEKz8rDPy-x4IY-t5JUkg-1 Received: by mail-qk1-f198.google.com with SMTP id x12-20020a05620a258c00b007051ae500a2so7052139qko.15 for ; Sun, 05 Feb 2023 19:18:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HUnXR7sTsl7YLdib1oIsNCKOxnTEFsrq4tcNXVLT5m4=; b=RSjKfDystFelJktl6dXbzcSBo7IRgv5/LyUBkHiJX9RSfYLHiS7yAkUFTDfzK/ImjH LGjMEdjGSiQQyi3rIJM7W/qAhS6+38Kyhi+jSAFSkANlmU/EEPIj+KFD5zeYuhP0utkw iGf+6Z9N7r/3u3ybZGPk5jqhCzRxVYnOxQqEpnCw8wAmb1xY2iiAs1cirMLK5m8kAL6S PX7QwNAs8nAyQ5ZCsJo4Z8+gD+jZymon+WvCCVZoPZINapXzUgYQkO2S3Hfj6LKQmI7K MXD4ZIIflb3kJBil8wwm0yp92NJyMsuq0ImLuRHTAjJeOe75AzgnNH+adypnOxtYtvfB tRsw== X-Gm-Message-State: AO0yUKUKTh4QwQW086zLuN6IP28bN20U4RjuzlOEfjt6MM70KHl92VMw GAn/NoJhKr/q44iKKX3WkKA/ttTU+Vx+ptcPbaeypTlQF5PaCPvLOm9QW5SgFRiqRusqgg3l+J2 FUt+cCLCBUkZHIDJX+E/GxJ9NUbhQFfuWG3I= X-Received: by 2002:a05:622a:17c4:b0:3b8:5199:f841 with SMTP id u4-20020a05622a17c400b003b85199f841mr33929528qtk.0.1675653512189; Sun, 05 Feb 2023 19:18:32 -0800 (PST) X-Google-Smtp-Source: AK7set/cpAGW2ESxNhYZ0jEVuvvuRs8ZuhdHof+3DnmWont85g1bLMGsUjVwGkO9KhDgbxDFzB1GTQ== X-Received: by 2002:a05:622a:17c4:b0:3b8:5199:f841 with SMTP id u4-20020a05622a17c400b003b85199f841mr33929514qtk.0.1675653511960; Sun, 05 Feb 2023 19:18:31 -0800 (PST) Received: from xz-m1.local (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id b6-20020a379906000000b007186c9e167esm6574425qke.52.2023.02.05.19.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 19:18:31 -0800 (PST) Date: Sun, 5 Feb 2023 22:18:30 -0500 From: Peter Xu To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Message-ID: References: <20230205231704.909536-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230205_191837_157381_551FC7FD X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 02:51:18AM +0000, Matthew Wilcox wrote: > That wasn't what I meant. I meant putting VM_FAULT_BADMAP and > VM_FAULT_SIGSEGV in mm_types.h. Not having "Here is a range of reserved > arch private ones". VM_FAULT_SIGSEGV is there already; I assume you meant adding them all directly into vm_fault_reason. Then I don't think it's a good idea.. Currently vm_fault_reason is a clear interface for handle_mm_fault() for not only arch pffault handlers but also soft faults like GUP. If handle_mm_fault() doesn't return VM_FAULT_BADMAP at all, I don't think we should have it as public API at all. When arch1 people reading the VM_FAULT_ documents, it shouldn't care about some fault reason that only happens with arch2. Gup shouldn't care about it either. Logically a new page fault handler should handle all the retval of vm_fault_reason afaiu. That shouldn't include e.g. VM_FAULT_BADMAP either. Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel