From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E255C636CD for ; Tue, 7 Feb 2023 10:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=81Hc4Wo7E0RWpVj12SWqNaZPgGcuWudAB3fBppstTG4=; b=aMJaHF1cvbnMho yQQ66L7XImv+s9zYjQj8cCuQsdyjv5u2/2kOrxuH85kV5DGa3DVMYm4R4pKUq1UuPWwUpTlslyyB9 sUtyoV29n2kQgjq+uW4MqFTMeXN6cdUhTSxE2qoiIgvyC4x1FkaWNwMlr02BXwzjWyBJhutITcHSW bXCd8cLkobu/NijjS+4baXZaWPrjDjt6e4K62aMbedFY/3w4+jettezjYLzhQ5Fjfg5qAlyXAC74W pk/PFmhqH61r/YrCaP1FhONNIVz+2j2CviQBi/SYGYN88ydeWE8TR4umcERQDa7/PzArTAq1vqikT qoEfWIaf1JIGt/xP0MkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPL6M-00BgGU-3z; Tue, 07 Feb 2023 10:21:26 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPL6I-00BgEz-EF; Tue, 07 Feb 2023 10:21:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675765282; x=1707301282; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y2U9WIJPBm0L0FSDgjHarSz3qorOt0PpIQPRP0xPIhs=; b=cT+UQbxMbnlkoMWpfRGW8e53J8GAowVo4CfiygBTtK2fEp1WC6e1ZzfZ JtOz9DHWpBZgou+A0OYxYfGTIFiGRXP/HLtG5goan5HXpW3Mn1NWgqyaD X4ywu+UDldW3pXXmMlUeiTEaTYOUguHaGFyzw5r5/j+AvwitOhW7C+F8o Zz7Pgo+oEv/q5WS957cMQovh1dXfiFx46tSXrawmTIAkiwXmDlweE6yOa J9OqfUe9zhUrWm9tA7yoGrURRnO14SVrifsbCgrJzobpsq/PTysQjncyt cmME2UkY/4q4xpIEhl/IvQpcelquUKOHqSFDJKWiFKsmuU7B0m3WSFb7+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="328112315" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="328112315" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 02:21:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="697227157" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="697227157" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 07 Feb 2023 02:21:04 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPL5v-003Z31-2O; Tue, 07 Feb 2023 12:20:59 +0200 Date: Tue, 7 Feb 2023 12:20:59 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Abel Vesa , Alexander Stein , Tony Lindgren , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , Vladimir Oltean , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 04/12] gpiolib: Clear the gpio_device's fwnode initialized flag before adding Message-ID: References: <20230207014207.1678715-1-saravanak@google.com> <20230207014207.1678715-5-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230207014207.1678715-5-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_022122_602175_F0175820 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 05:41:56PM -0800, Saravana Kannan wrote: > Registering an irqdomain sets the flag for the fwnode. But having the > flag set when a device is added is interpreted by fw_devlink to mean the > device has already been initialized and will never probe. This prevents > fw_devlink from creating device links with the gpio_device as a > supplier. So, clear the flag before adding the device. ... > + if (gdev->dev.fwnode && !gdev->dev.fwnode->dev) > + fwnode_dev_initialized(gdev->dev.fwnode, false); Please, do not dereference fwnode from struct device. We have dev_fwnode() for that. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel