From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C704AC636CD for ; Tue, 7 Feb 2023 10:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OQ5Dm4oWedtm/JTZwA8oz0Sj3JaEJW5QNfX1SOGlAu8=; b=fjVeHpbf/xFsy7 dz4Dlo+g3mQcuWz+ZntMh5MAq+eEVdBwukXq180iVxjXcsIlWgYKSk2e+H7dL3ZelYI2MFSeCzxed yO4sEntBARrtd+sflVF6WjT2iViUT8QIT4C7rwCSnLc8kRaYOivI+GHq8i21x80CX1PEqKmrFbwPE IMJb35NyoxX9lzEm0zjerq/Efgy5w82NF0zxr25CSq7tZkm2qFgie7lGPUS6qYdDIU9MZg+2aw2Ml zh3YPE6fiavPEjkLFo302R2QEw9p1pOG0eUXZH/6dExDuiEx/PKDQqLJU/+/fLSMfPx+QZol9T8kH ZWdHYEjG6gluJyg6I1tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPLDW-00Bhse-B9; Tue, 07 Feb 2023 10:28:50 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPLDS-00Bhre-NP; Tue, 07 Feb 2023 10:28:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675765726; x=1707301726; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qFKo6P9N6kXoK08jHrxIsWsAo99hMsJ26Xtn6cj93Is=; b=hWLT3hR4T6IdjfVKyjCXuOZru6N1cDz4WFG6kkvniWYSK5vv4I837e3j yHT870hXyr6L9tx0EVHgFjA95uN3TXYHPWHuoTOJcoEvfAYuMD4u84Z5M RNwAUO8qh5vsaZd+0FqS2PnWlAHkVgfktdSWfszLBaeJnSImp84rNlVb9 qJQgwzM54ZUpB6Ex7AfdNkQ8gj5Z7LbjFCWSqsJQwPS6SERqW5wjAvWWt j3rhzukVjW5bSYiDuV3PGQzPBOYch6aiLL3OmdTi1E9gjzULI0N8DxrTh 1pk08QQfvWRaxZ9Ywq2c/9wNX80dHQsx4QVy4N3RsSlrIUa+M0wCoiyQw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="356841103" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="356841103" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 02:28:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="616762031" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="616762031" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 07 Feb 2023 02:28:32 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPLD9-003ZAe-19; Tue, 07 Feb 2023 12:28:27 +0200 Date: Tue, 7 Feb 2023 12:28:27 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Abel Vesa , Alexander Stein , Tony Lindgren , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , Vladimir Oltean , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 04/12] gpiolib: Clear the gpio_device's fwnode initialized flag before adding Message-ID: References: <20230207014207.1678715-1-saravanak@google.com> <20230207014207.1678715-5-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_022846_792090_AB795240 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 07, 2023 at 12:20:59PM +0200, Andy Shevchenko wrote: > On Mon, Feb 06, 2023 at 05:41:56PM -0800, Saravana Kannan wrote: > > Registering an irqdomain sets the flag for the fwnode. But having the > > flag set when a device is added is interpreted by fw_devlink to mean the > > device has already been initialized and will never probe. This prevents > > fw_devlink from creating device links with the gpio_device as a > > supplier. So, clear the flag before adding the device. ... > > + if (gdev->dev.fwnode && !gdev->dev.fwnode->dev) > > + fwnode_dev_initialized(gdev->dev.fwnode, false); > > Please, do not dereference fwnode from struct device. We have dev_fwnode() > for that. Note, with that fixed you may add my Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel