From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F04C636D3 for ; Tue, 7 Feb 2023 18:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IjsRZhR6AC3c4tZrjA/NEi5sKfXge4snk/Bda3i6AB0=; b=Tt4kC3BOM3OwLm 6cbeWmDsoVDQLtOaRo6Yb3hBlg6eL9S3Hmi9ByTNsro+RnUNjndMojIYnqIpARBPLwCtBNA4gEIfx EtLrxTG6Zrj0whUx4DqiwTfUd5kkMefEJsVOQTqlBNmQ5pnTuD4pai1fMjMTSGz53I6SfQJTjNnOi WxwY2X2ITQIqnXUQrSzL/SjfwHEJpQ5dkG1USKevJO5GTh1MnD1ee2xIOJQBHvA7eWSVGC92dQWBd rmYpZX0niScrFV2xTXH5y9TjOqWhKjqVtcZqp0xIZwVuYLrNyCFcohCi2F7i/8BMEB1ndpo7DAkuU yHyTEGVtPocelCmvEaew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPSHT-00D02q-OV; Tue, 07 Feb 2023 18:01:23 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPSHO-00D01p-Sp; Tue, 07 Feb 2023 18:01:20 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pPSH8-0003tU-00; Tue, 07 Feb 2023 19:01:02 +0100 Date: Tue, 7 Feb 2023 18:00:59 +0000 From: Daniel Golle To: Krzysztof Kozlowski Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v2 03/11] dt-bindings: arm: mediatek: add 'mediatek,pn_swap' property Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_100118_953967_D1B50ABA X-CRM114-Status: GOOD ( 24.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Tue, Feb 07, 2023 at 06:38:23PM +0100, Krzysztof Kozlowski wrote: > On 07/02/2023 15:19, Daniel Golle wrote: > > Add documentation for the newly introduced 'mediatek,pn_swap' property > > to mediatek,sgmiisys.txt. > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > > Signed-off-by: Daniel Golle > > --- > > .../devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > > index d2c24c277514..b38dd0fde21d 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > > @@ -14,6 +14,10 @@ Required Properties: > > - "mediatek,mt7986-sgmiisys_1", "syscon" > > - #clock-cells: Must be 1 > > > > +Optional Properties: > > + > > +- mediatek,pn_swap: Invert polarity of the SGMII data lanes. > > No: > 1. No new properties for TXT bindings, So I'll have to convert the bindings to YAML, right? > 2. Underscore is not allowed. Ack, will change the name of the property. > 3. Does not look like property of this node. This is a clock controller > or system controller, not SGMII/phy etc. The register range referred to by this node *does* represent also an SGMII phy. These sgmiisys nodes also carry the 'syscon' compatible, and are referenced in the node of the Ethernet core, and then used by drivers/net/ethernet/mediatek/mtk_sgmii.c using syscon_node_to_regmap. (This is the current situation already, and not related to the patchset now adding only a new property to support hardware which needs that) So: Should I introduce a new binding for the same compatible strings related to the SGMII PHY features? Or is it fine in this case to add this property to the existing binding? Thank you in advance for your advise! Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel