From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAFAEC05027 for ; Wed, 8 Feb 2023 13:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6l+NoOpNOlw4kjJqy1ZgMuDZYKT7cNcYACOSlQm6GRo=; b=DF10ggF+MNURcW 4sg+NhEVrog8LdR0RqOj/7cb7zoppsphHjaFy0+l0QasD7SkK2B9M8QSWDCIeW1yREJbtlGHuyQsm MtYlK62vl2Xin6vOM06cgMb+atEl+6upIxXvjMmW0X6XeRGKG9kAMQMu+/Hn+qt/YKP+cB3LWgASH qNCt1cDBKQwV95aoopEyKTM7Szr0gQ1oz8uGotAmPpS2VdeuE0m3PObPTBfgk9CRmBt21YSRekWoE IBPrWzY9GS+PNLfskWZqY2p8V05TKLscR/FLW2T2YzRQLeeoDBbi8uWm6fNNWBF64mXtuXQw/lhN2 R+djS+dWq0GBHMEENzMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPkfV-00Fn7t-4u; Wed, 08 Feb 2023 13:39:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPkfT-00Fn70-EA for linux-arm-kernel@bombadil.infradead.org; Wed, 08 Feb 2023 13:39:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=89txdDaejNpE0nxwj6ais3h9KNm3TEbqakDWeLbiCRY=; b=GpecFV0WIuH0awJgblwguk++s1 7HFzmBFnft1UBOAxF0SydS4EUqPbZunSFcd7iJInQcDYY2KXr0VBJLWnskI2Wsfjtzhag2YCLuPYZ pP/B3mor0WDbUAqiA9kvcQyav7Q8yesthowJjWr39qZOiJ11WFhxr4Pq67dHxUT1XbA5BxxR8N2cu R06RRvkxkJ5D1COq6UeztCjNlauknXyTGAVsSoRNLdtyJWejsup6zyYl90E8m4vSQe0GjZE7essEd mXd1tlff72oXcJlpmk2JE/XdhD+b0KL5TE7WwsQ3CjpA4psZzjs21CMxqedpU2oJR12IbLIXvcWPC FFjJMXPg==; Received: from [187.19.237.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pPken-007Q3L-3A; Wed, 08 Feb 2023 13:38:42 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 9A2A5405BE; Wed, 8 Feb 2023 10:39:16 -0300 (-03) Date: Wed, 8 Feb 2023 10:39:16 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Yicong Yang , linux-arm-kernel@lists.infradead.org, yangyicong@hisilicon.com, linuxarm@huawei.com, prime.zeng@hisilicon.com, mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, yao.jin@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix auto-complete on aarch64 Message-ID: References: <20230207035057.43394-1-yangyicong@huawei.com> <0ded9983-8a37-d6c9-3de8-cbde6a4ce1e7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0ded9983-8a37-d6c9-3de8-cbde6a4ce1e7@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Feb 08, 2023 at 10:35:17AM +0000, James Clark escreveu: > > > On 07/02/2023 03:50, Yicong Yang wrote: > > From: Yicong Yang > > > > On aarch64 CPU related events are not under event_source/devices/cpu/events, > > they're under event_source/devices/armv8_pmuv3_0/events on my machine. > > Using current auto-complete script will generate below error: > > > > [root@localhost bin]# perf stat -e > > ls: cannot access '/sys/bus/event_source/devices/cpu/events': No such file or directory > > > > Fix this by not test /sys/bus/event_source/devices/cpu/events on aarch64 > > machine. > > > > Fixes: 74cd5815d9af ("perf tool: Improve bash command line auto-complete for multiple events with comma") > > Signed-off-by: Yicong Yang > > --- > > tools/perf/perf-completion.sh | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > Reviewed-by: James Clark Thanks, applied. - Arnaldo > > diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh > > index fdf75d45efff..978249d7868c 100644 > > --- a/tools/perf/perf-completion.sh > > +++ b/tools/perf/perf-completion.sh > > @@ -165,7 +165,12 @@ __perf_main () > > > > local cur1=${COMP_WORDS[COMP_CWORD]} > > local raw_evts=$($cmd list --raw-dump) > > - local arr s tmp result > > + local arr s tmp result cpu_evts > > + > > + # aarch64 doesn't have /sys/bus/event_source/devices/cpu/events > > + if [[ `uname -m` != aarch64 ]]; then > > + cpu_evts=$(ls /sys/bus/event_source/devices/cpu/events) > > + fi > > > > if [[ "$cur1" == */* && ${cur1#*/} =~ ^[A-Z] ]]; then > > OLD_IFS="$IFS" > > @@ -183,9 +188,9 @@ __perf_main () > > fi > > done > > > > - evts=${result}" "$(ls /sys/bus/event_source/devices/cpu/events) > > + evts=${result}" "${cpu_evts} > > else > > - evts=${raw_evts}" "$(ls /sys/bus/event_source/devices/cpu/events) > > + evts=${raw_evts}" "${cpu_evts} > > fi > > > > if [[ "$cur1" == , ]]; then -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel