From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84683C636CC for ; Wed, 8 Feb 2023 18:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FxNe7KbpDPSuEfZgmRrlWyVj9DUNip5aueGwS21eTK8=; b=u5+vAZbxGw7uVA W9jLUAZJyXcHQ9BIn6Q7GGqcEV6MMyHXGKoW95CEuBKGmCCyM0B/nOtAgWqx9wVbMnibFe5H//kQ1 TMpibl4L7kfJQMy828GLWtwtIxG7Ni936F3zfO2uZEr301kLHaDzOvysDQ0BQeb9fJ8n6W+x7caNb 0aemIhcPh3av0d+b0pRZdWrqKISG0nRBjK1EMFBt+6GNo4jHqQIdrMcHnz/N4m1KgAeOAsJXV+sa3 qNfSNH0GwrvFa3uRF7NAjmZn53FVil9QRjrht9deTUD3kHPkhZFu7rsS097/aKPqS0jncNbPIyIPp vi1JQn6ocDHri/SNWsqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPolz-00GXxC-RU; Wed, 08 Feb 2023 18:02:23 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPolw-00GXvI-OF for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 18:02:22 +0000 Received: by mail-wr1-x434.google.com with SMTP id e3so857043wrs.10 for ; Wed, 08 Feb 2023 10:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X7v96oVAyAQBz01xG5dPcw5TgpCX8c/Q/mzF1lq3fls=; b=JSDjd4NjgrHKtKRst4hPuvGeqhv3Ifdam+ydF66GdBY2o1JwQB227Ux5hF9yAJnSdK bC/sHd9PuY+1SyHl+L+j9HqfSzCq5PL0wofKxfQbDeUmx2OvAKVWis2E6mhLBSLLErjk ujFZBGiK2yHUXawLCYGUiF/s8MWRNlqqYl55zylEdmIn2lLpb0m0Y0XP6dEbT1bw/11P TgSTKZLI4Zp+lO+ZHaIl+7dzoSYqGNlVNhXLtDk/gnkPxIOJmVrowyhCeF1xymON/aq1 XmMK9AOBL96DheyA2mBqTFdVlxSFKsqxHzHNU+UBW+S2CTDOAXaj78qU9P1PkCfbYmm5 5VBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X7v96oVAyAQBz01xG5dPcw5TgpCX8c/Q/mzF1lq3fls=; b=LUAtmIAPRrjqDuDpDqDT21TSUlZW6RrGAJI/zUbhdilDFqgPqxl9TtCkLqwpUO6WXj RImzd5UwU1vk9HBdA/Gm68R+yEN5Yw0n+xcxqh3jLuk1k/oZgPczolYcR4vO+foJMF42 1u4djYdapxV/qTYC9Wi5S3kwcX4TfTu5wh414HAr+Ry3T+GNPaKgTnLf2C72V4LGuXZk n/YZO/EUmniWyA1JVvQeK9e4CQlUo8JF9M5rY6COt9k7TJVZuPyS0GxnpeMxqsjQoZlq jAiGsX7VlFiFLtnX8Sf9yXWQgvdf1CiwC3BJglVYoz2ccBTwc9p94NhFInqhC53ZjWq9 Aycg== X-Gm-Message-State: AO0yUKWcrht1nzIzj8g0U6XdmooJp532fHj7ryyWKeGlp1wLWAAqYEXw bezoaut70m8NE8irI/Wm3Vbf8A== X-Google-Smtp-Source: AK7set9Pjmyi9t3GhUz0tafPGUxnCQlCQNX1EdDzGdiVW7+aDmg9A9r+drJbsTm198Kj45dKYH4K7w== X-Received: by 2002:adf:fcc8:0:b0:2c3:cf13:d11 with SMTP id f8-20020adffcc8000000b002c3cf130d11mr7601005wrs.33.1675879335485; Wed, 08 Feb 2023 10:02:15 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id o7-20020a05600002c700b002be5bdbe40csm15273523wry.27.2023.02.08.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 10:02:15 -0800 (PST) Date: Wed, 8 Feb 2023 18:02:09 +0000 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev Subject: Re: [RFC PATCH 09/45] KVM: arm64: pkvm: Add pkvm_create_hyp_device_mapping() Message-ID: References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-10-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_100220_806025_5E61AF95 X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 07, 2023 at 12:22:13PM +0000, Mostafa Saleh wrote: > > +/* Map the MMIO region into the hypervisor and remove it from host */ > > +int pkvm_create_hyp_device_mapping(u64 base, u64 size, void __iomem *haddr) > > +{ > > + int ret; > > + > > + ret = __pkvm_create_private_mapping(base, size, PAGE_HYP_DEVICE, haddr); > > + if (ret) > > + return ret; > > + > > + /* lock not needed during setup */ > > + ret = host_stage2_set_owner_locked(base, size, PKVM_ID_HYP); > > + if (ret) > > + return ret; > > + > > Do we need to unmap in case of errors from host_stage2_set_owner_locked? I don't think so because this function is meant for hyp setup only, so any error causes a complete teardown of both hyp and host page tables I wondered about adding a BUG_ON() here if the function is not used during setup, but maybe improving the comment would be good enough. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel