From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 841A1C05027 for ; Thu, 9 Feb 2023 13:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chYT9AyW/qO5nPa1iPtwVWcy534ynzu8JthkdT4vn3M=; b=zat+v3xaOh9H7a +MrE7SBXCg9NCxoMCufzzCDQ8EdotZsa4NXxdR/YP7VpmivggTw3sZJkkodX5+/Gfc5wfSaVHCFp2 7kNaoEo02FnPHU3dFkP0OS2dZie0yXQIVHeO062i6bsMiHwPFysiLVt68F5bgbPNuaMSMSaatylT/ HAGvzo8SwRxU79l+wqwZjIpji/YpRmphOBvG7zrhDXsfEWi4d/d5td/DVdHFdRNooBhUzZ6B6QFDb r1svrwCFltSmhVvgr/BkAeR59LUaVTFPGNdqZFlMzs2eXBUQlAPd7/adswSfuvbGKEWMsPFpWOUmo Ncy1J3vagnwFuTqTQ5Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ6h4-001cSB-AD; Thu, 09 Feb 2023 13:10:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ6gy-001cQf-0v; Thu, 09 Feb 2023 13:10:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF89961A51; Thu, 9 Feb 2023 13:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACE6DC433D2; Thu, 9 Feb 2023 13:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675948222; bh=4SUmqquqGXJoK6fqr+/rMnpLfSjMEDdKWErLzFfQiqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbxJAcxIY5aZSy8WxcV0uALiZbcIvWCMEUPDCaMmQmTjiQVyI8lF/94iQfqQkdCZM PZdv9ca/F5KivfuWiigTuT1SG4/YCVTOKKrjerMnwjdv13ix9huD/Qek9w27t8GKxv /0flF45ld1/3Dwvmb59C8wusQ0kkPeVcdiTwazc73m56FwcDU+91btuUha2TNEBd17 sIBgdMUx69bJVjv8jLvPynF3Q0q+WWsdyDNFUw9M4nydY7VZwZ9zLcAjARLixKOl+k V9YQTg4QS7b+ll5deXaGt/mqSV2Tb1PLjcJkpxxw7BJ7Md1ZxYhttiprhhMKhtEUId DBKpdSpSELI1Q== Date: Thu, 9 Feb 2023 15:10:07 +0200 From: Mike Rapoport To: Jonathan Corbet Cc: Kuan-Ying Lee , Matthias Brugger , chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru Message-ID: References: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> <87a61wvtcs.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a61wvtcs.fsf@meer.lwn.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_051024_147058_EB81C1CB X-CRM114-Status: GOOD ( 30.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 02, 2023 at 11:02:11AM -0700, Jonathan Corbet wrote: > Kuan-Ying Lee writes: > > > Since we introduce folio, replace isolate_lru_page() with > > folio_isolate_lru(). > > > > Signed-off-by: Kuan-Ying Lee > > --- > > Documentation/mm/page_migration.rst | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > This seems like a good patch to copy to linux-mm - done now. > > The patch perhaps is a closer match to what's in linux-next, but it > seems that, if we're going to update this document, we should reflect > the use folios throughout? Most of the current users of migrate_pages() still use isolate_lru_page() so I think that updating page_migration.rst to folios is premature. But when we do the update it also should include the translations. > Thanks, > > jon > > > diff --git a/Documentation/mm/page_migration.rst b/Documentation/mm/page_migration.rst > > index 11493bad7112..1f8cc175d770 100644 > > --- a/Documentation/mm/page_migration.rst > > +++ b/Documentation/mm/page_migration.rst > > @@ -69,8 +69,8 @@ In kernel use of migrate_pages() > > > > Lists of pages to be migrated are generated by scanning over > > pages and moving them into lists. This is done by > > - calling isolate_lru_page(). > > - Calling isolate_lru_page() increases the references to the page > > + calling folio_isolate_lru(). > > + Calling folio_isolate_lru() increases the references to the page > > so that it cannot vanish while the page migration occurs. > > It also prevents the swapper or other scans from encountering > > the page. > > @@ -89,7 +89,7 @@ How migrate_pages() works > > > > migrate_pages() does several passes over its list of pages. A page is moved > > if all references to a page are removable at the time. The page has > > -already been removed from the LRU via isolate_lru_page() and the refcount > > +already been removed from the LRU via folio_isolate_lru() and the refcount > > is increased so that the page cannot be freed while page migration occurs. > > > > Steps: > > -- > > 2.18.0 > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel