From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 126F5C636D6 for ; Thu, 9 Feb 2023 16:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SxFWnvVoG1Pe3ourW7tpBzgIfdjQX2hIO7sp3BctMKg=; b=z+4AFokpY+c5vV i5kY7sm6vTFOCpTgXbZHd+p1JS8L9wYZl8Vk8GA4px5rTYVcZaQ2mqsbfu+KEd7mvM9u9P8yve65g oDpRcR5YsAsliFleQyj2VDRGSS1nkj1lA8aHL3RLsAF34ieRa7JYYlz0qpBg3IiNUW+Jl2NCzYkcQ q1tWzEyxMJDx/zJCZJlhVLl/egWqW8ndsqjK7dm5Am8ZFUF6VZKZ0v6UDl+Gx1vazjwE+DZL7PpuL ISBZSRiFpHjigZTxEYi1+GB35Uy9Ca7JJ+1xsuy6ziMG9EZkiXDQe+5ZIOet0qlm5hNdlKDscHUCz 18bOCev1rLMQ8jTWTW8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQAFA-002UoB-Nd; Thu, 09 Feb 2023 16:57:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQAF7-002UnH-I1 for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 16:57:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fa/1qusEzE09K3FBJWdI+gcUoNQkNsyNDFJ4M5uwCu8=; b=Gly0qg4M2rlT6xOGDNEegpA8+J 91TImRIsmqOgvCwT82k5vh1TUtqa9AB+MixFphLnLa8Op6OjcE9G0HDRt7ySCeEu4oJxt3Xml+kK4 nSBhEjXpu47Fv83yd1+XXxEsr5CFau31oGXsVqHNW7/bsi+YE45uSNSlhkTL4bLsTMaC3J5E4Es6I dzNoDMcUffyzOkowkh8BB0s/ViyBF2jBADzt2tagVdK/j+ksn6ODUTSiMd0t1TsIOZg4tauBQ4SoO WExO1wud1oDwRy9dqcFkcR8GBBmpYPAvaQF6mW+DyoraYwgE2r7RKM5EJ55D/sAjsMdty56PEeaBN THMzcJww==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36486) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pQAEv-0008AW-LC; Thu, 09 Feb 2023 16:57:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pQAEs-0004kk-RU; Thu, 09 Feb 2023 16:57:38 +0000 Date: Thu, 9 Feb 2023 16:57:38 +0000 From: "Russell King (Oracle)" To: Clark Wang Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH V3 1/2] net: phylink: add a function to resume phy alone to fix resume issue with WoL enabled Message-ID: References: <20230202081559.3553637-1-xiaoning.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230202081559.3553637-1-xiaoning.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_085753_617749_4D79F7AB X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Clark, Please address Jakub's points and resend with patch 2, thanks. Also, the subject line should indicate which tree this patch series is targetting - e.g. [PATCH net-next v4 1/2] net: phylink: ... > +/** > + * phylink_phy_resume() - resume phy alone > + * @pl: a pointer to a &struct phylink returned from phylink_create() > + * > + * In the MAC driver using phylink, if the MAC needs the clock of the phy > + * when it resumes, can call this function to resume the phy separately. > + * Then proceed to MAC resume operations. Please also state that it must only be called prior to calling phylink_start() in the driver's resume function. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel