From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187FDC636D3 for ; Thu, 9 Feb 2023 20:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YpCquDFBMrQWrEbX1dIYOYjI3qfMnxqb4/7DCdEm64I=; b=yuiA2B6C9SweuX LTwfYrIROPY1w6GJjUD1RYJ0ylJh25bGI+kaAq1mOznQT+LWbVbgD7Up3wpvVLsvY3qcGTH2dMpBb MqxgNI2bzFe2E2pETLtLm8AXzW8Yd7iH+kuRI5lwyr0cISRkJgRO9wcPJkfkCotq+PcP3vdfh03+v e3rZRtsfQLFWWr83+oOtZT0ap8Fj6ZTBlUigFwSOssQvU/2LgYDAlaaGgq697oy0Gq6DJWRw6GV3i azgg/2V29laQoItgz2Abx2ehduiHiuYnm/0ZroBxD5jdffC5zKH841Vc7FOfSeqMbIsT+FyTDEUxu uIwxOoRWZDJILm+QFQhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQDEq-0037EC-TM; Thu, 09 Feb 2023 20:09:49 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQDEo-0037Cz-Cv for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 20:09:47 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 319K1lMe014350; Thu, 9 Feb 2023 20:09:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=XGHbI4ra0FtneGPyfx5jeTG6NSLPIotF9rRhO6tyTiE=; b=ZS90CnmKHcX2Szr2iyBq4vLBLxdSyovUrw65rrkcypmr3G8AfUE/iw2rCkxfMVuklwr8 x1RloEGV6ukvMY7h19dRqhwdOC6KkYKhl0ECGJhYIH1b/nTG0zOab+3KNxko47MxSqIf WELougxeGm2IDoMWQZRm7FdKbEn8156vW360HoUbkc5v+haxMHPFylW7Uh3dtDcwHypK GLD/Xa3khQvrXRmC5p3QaMw1Yrx0OqaZfkM0zMEAFRFlOkqGLNpMVAnIVxIDfpAjZqrh 8Jx4UrVItaT4Bu6VBbObJgL4MgcD/o4ndrJvpgfyFJ1UxULrhlFY7BDwwVTj8DEQGJcN Ew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nn7gr8c0j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:09:32 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 319K28xC016343; Thu, 9 Feb 2023 20:09:31 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nn7gr8bxw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:09:31 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 319CkNfE023807; Thu, 9 Feb 2023 20:04:28 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3nhf06xmub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:04:28 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 319K4Qke51380530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Feb 2023 20:04:26 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 283A420043; Thu, 9 Feb 2023 20:04:26 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2E0620040; Thu, 9 Feb 2023 20:04:25 +0000 (GMT) Received: from osiris (unknown [9.179.10.102]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 9 Feb 2023 20:04:25 +0000 (GMT) Date: Thu, 9 Feb 2023 21:04:24 +0100 From: Heiko Carstens To: Matthew Wilcox Cc: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Message-ID: References: <20230205231704.909536-1-peterx@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SN3n-Sj8UyAs9EywqmZbAifHCHDfdB2o X-Proofpoint-ORIG-GUID: UKCCI8etZ5fGapHAmtaqPfeeaV5GiOYm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-09_15,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1011 adultscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 mlxlogscore=364 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302090186 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_120946_450747_5BC3DDF0 X-CRM114-Status: GOOD ( 31.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 05:09:57AM +0000, Matthew Wilcox wrote: > On Sun, Feb 05, 2023 at 10:18:30PM -0500, Peter Xu wrote: > > On Mon, Feb 06, 2023 at 02:51:18AM +0000, Matthew Wilcox wrote: > > > That wasn't what I meant. I meant putting VM_FAULT_BADMAP and > > > VM_FAULT_SIGSEGV in mm_types.h. Not having "Here is a range of reserved > > > arch private ones". > > > > VM_FAULT_SIGSEGV is there already; I assume you meant adding them all > > directly into vm_fault_reason. > > > > Then I don't think it's a good idea.. > > > > Currently vm_fault_reason is a clear interface for handle_mm_fault() for > > not only arch pffault handlers but also soft faults like GUP. > > > > If handle_mm_fault() doesn't return VM_FAULT_BADMAP at all, I don't think > > we should have it as public API at all. When arch1 people reading the > > VM_FAULT_ documents, it shouldn't care about some fault reason that only > > happens with arch2. Gup shouldn't care about it either. > > > > Logically a new page fault handler should handle all the retval of > > vm_fault_reason afaiu. That shouldn't include e.g. VM_FAULT_BADMAP either. > > Hmm, right. Looking specifically at how s390 uses VM_FAULT_BADMAP, > it just seems to be a badly structured fault.c. Seems to me that > do_fault_error() should take an extra si_code argument, and > instead of returning VM_FAULT_BADACCESS / VM_FAULT_BADMAP from > various functions, those functions should call do_fault_error() > directly, passing it VM_FAULT_SIGSEGV and the appropriate si_code. > > But this is all on the s390 people to fix; I don't want to break their > arch by trying it myself. Yes, will take a look at it. For now I will apply Peter's patch in order to get rid of the collision. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel