From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E65F5C05027 for ; Fri, 10 Feb 2023 11:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E99fC8lQamyNN7cJkHFUX9npVi+JKOY/LdtPLyvAcV4=; b=tqQQEvZFTNeEQV 1S5NN3k28yvsFXr+9wrudbxgoGQzxLFgWLmWyIvjcr5c5eOuw1VuzPOOSAD+V6NNgC8UcctJG/ca0 PTGni+lv3J/FnFRh9RBfDXnb1uf2PzetBJZrnBdTma7hACSMtsj93X4ZHaj3jcASSh8rTk+SrubJ8 0xiLoyptSgh1o9ZZ8mG25ceHu/hrVqn3yqkXfvwZGHp+nkPra9NE2INbirI9QKl4S4ZK687Bnc12Y ICU4tBRBWnOAdMsCI+MgE3uslLvagi8cRBlghJv9b+qeF/qVyLcJtXjmCMwIqoHsHmg1BclhqUS3B hMNKT8h4MvJ2zhqQWVbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQRI8-005QdW-9D; Fri, 10 Feb 2023 11:10:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQRI4-005Qc8-Po for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 11:10:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AXxKWPiVWJU1ugGjgpin75Nz5rvbBLIVFJ34R7UAKY4=; b=WRGrmvm4i7DY8WBKznriUmhH27 HfSP+oNS0Q8XKdW3xMV7kb6qm5JR8qHzlHdfAr/9lB41CWLwO8HnMqM40mtotygauRM1XQ2/F0TVA 3vV5Txv0zXOEk0Ds4/M6RZoyHDyjPCrMKR7MJx6sQdueTeqW6qmBZS/jLPuwNQaflyMC8vBQjK+gZ vcBHwoqcgEc5/pDOTlXMtPD7ZJeupFKiI7NPGbGv3XhCJbddfUeBReMofYDKeNG8HbckSFCm94Qph C2Cu8ywsYkf58Y3iQP2I9rmBqqecVNQZS3ciesqhtbDZ1YaeWxOFvaCGrIPfEET16Zf3fyjqRH7sn 5xaoyalQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36516) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pQRHk-0001No-OQ; Fri, 10 Feb 2023 11:09:44 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pQRHg-0005XJ-T1; Fri, 10 Feb 2023 11:09:40 +0000 Date: Fri, 10 Feb 2023 11:09:40 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Wong Vee Khee , Kurt Kanzenbach , Revanth Kumar Uppala , Tan Tee Min , Thomas Petazzoni , Herve Codina , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Mohammad Athari Bin Ismail , Jon Hunter , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 5/6] net: stmmac: add support for RZ/N1 GMAC Message-ID: References: <20230209151632.275883-1-clement.leger@bootlin.com> <20230209151632.275883-6-clement.leger@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230209151632.275883-6-clement.leger@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_031004_858510_E79BA7B0 X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 09, 2023 at 04:16:31PM +0100, Cl=E9ment L=E9ger wrote: > +struct rzn1_dwmac { > + struct phylink_pcs *pcs; > +}; Please see my comments on your previous patch series as to why I don't think you need this structure nor its associated memory allocations. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel