From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF7B0C05027 for ; Fri, 10 Feb 2023 21:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qBpRyuWc7aq7nwO6VG54aUQcHNksuy4nwyEiuWJ+1uA=; b=FENLCVdAMHwTYq 2iMGN7rSHHkdKwnPXi40t3Hb4BiGfg7SX4V3TzTydbZL4rwJAz/as3fpVBoAjo9OtYNtdDz6EjrD7 HkOtbXv2wTm/B5yX5Y73dBHHkKOgN0T0bCclzu2T/yEIKbq/UouCAbEXGvEg4sP3vWQSfzjXvAmTh UhFEJINacUSFB1hv8ZUyJx1swXUO3a5kGQ8/XgXaTXX75xanrkiTR9K3MOivwKGiAItN86uO1JoJA NFBwkdtgVVoz/WFVTToVYZaTTEIYa4yhxrSGE6ab5vmQon/xq6YHXr3X9rRsdbUr3aJetYPdZ2KIH mmzh/oTDFVfA00Zh/zfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQbEE-007h6y-96; Fri, 10 Feb 2023 21:46:46 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQbEA-007grh-HG; Fri, 10 Feb 2023 21:46:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q4ycTM6wjBzQxnmAN1l0VrC0z1bUlOmEH9rHmaSCS7Y=; b=SbS8AXmj9RhgHzGEoljuzMLM5d QkbKoM9XzPbnNltx4q3Ehcod7YTDuGAoNbylMlU33dHqjXtYBNGJbov6Vd7vlvkXzgikcAAqdrbAu /PxBsPCk8r+AZPx6Aw77YmK0q9WxYCpoLf7bx99XPjz26YitrhpdopmVU94xuDCqoOqvA0A2cVVEP DtV28WyswTdHzn7F99dlJlnQYxfsGfGDaGSTH4e+A7KV0SvSGO1Ud14r8bnXOkc3qNJFGEhkiHuJZ Id5KnjJSe6fNwaOoU++CS7O/7Mgwngon9xYtrcWqOJ2WCkbs8OdzaDJ8ykiWnLjisTRDt2cPbo7Zp ADDCaD4w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60080) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pQbBy-0000hg-Ew; Fri, 10 Feb 2023 21:44:26 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pQbBr-0000V9-W4; Fri, 10 Feb 2023 21:44:20 +0000 Date: Fri, 10 Feb 2023 21:44:19 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v3 07/12] net: ethernet: mtk_eth_soc: only write values if needed Message-ID: References: <655926d824fac09cf188d746ae18cfb823135525.1675984550.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <655926d824fac09cf188d746ae18cfb823135525.1675984550.git.daniel@makrotopia.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_134642_595012_52E9CA5A X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 09, 2023 at 11:31:51PM +0000, Daniel Golle wrote: > + /* Setup the link timer and QPHY power up inside SGMIISYS */ > + link_timer = phylink_get_link_timer_ns(interface); > + if (link_timer < 0) > + return link_timer; My comment on the previous iteration of this series applies here. (this comment for net-next review tracking purposes.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel