From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE637C636D4 for ; Mon, 13 Feb 2023 11:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZD9uRwfwAG5pQfhcyHDmfvYmBhaKKYWQuGRh8RjwT8I=; b=RCcu9yudcakRnz efLzI33EKUmS1sQQHEbKR23Y7xLvEFcbaf1AADF1Ta3si4Hi/Rpl/GMJ/LAzzNTrAlzD0NvicjHUX AkBE/AsiD71lJH5WDcOBDVJ104snwyOJZSgJkrPZRCAZ8uP1K6YyYvwXFrq4OpMqZMPSogKo8Ljdx CMPV+HzYdG+Z4XEMsij3UkgOMt9LVD0ed5Ce5B6Sv9RSWNrzkBlVJeLTU9Ad/NmxlL6AZLXS97SeP 9kpEFER7wQWaS5tJW5JgowgY/WR35rR2faPqWp8NL8r3ZZkMvEO/ksf9lk6ho3El0WSPWysc5OJbV A0MEI6Dg6rolVegPGfAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWd0-00EJB0-Uo; Mon, 13 Feb 2023 11:04:11 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWcv-00EJ6v-0v for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 11:04:08 +0000 Received: by mail-wm1-x32e.google.com with SMTP id n13so8408830wmr.4 for ; Mon, 13 Feb 2023 03:04:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kir9kI70OwVh4537TiH5wl8iuSbkpWMjHOA2BO/ND5k=; b=b7IPcyYuYihUv3j2jJk9iFsuIZcvMW9nCCzI+rgUsDMrWTM8jgRydKNB0qLWsHcqI2 bWAVVoSWAyM+n7AT91/odFePzvKFkkm2t0PccwIZ/8nYisVhhBUcsniTIkkJScc+o3w5 qO9FfQF+sgkj6wrZfJkGxekqC+e1L695nyJPv/sk2+RWXa5196g+DlNTR/UJSBAbSf2Z n3q3i3n69bnqXLxdWbyzTr/3EE15BA0crpA5GMqKZsA16wsppMsFE4RtxSh30TSF04Ys UEE8TZuPlQukpqD7o0sgAysQ65mXCet2HwxzyRF7RPmmtZzXoF6zC2vWaf11Lo3Ya8bJ Fs2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kir9kI70OwVh4537TiH5wl8iuSbkpWMjHOA2BO/ND5k=; b=0xcoNaEEaVQeWNVI1Y94ljt5xT/N58fnlci5F4HixRseaEi8sgCgAal6nKtUXqdA2O 96MUDpG3qWL8rh8qt91rprd4qjVJzMVrmeVHqDBtz9fwIN1aig+NqDz55BlULMv5sZxN zMXgeI7SLBV1cECuY+ZHwXzwD4dhHNy+aqo8uGZ6qVwIWp/v16jr+ZXWOaykdtpJQb7V B2RaA7YBA5DczgOf9pvBPuxcMBmJG8MUAc1P+mllD39k6ywiQDb8wd3mx8TKf2PhgMHh 4KejC4UlYJRtmP1rhQbgEzcleCQ6juLCpSp8GVtNMcWEvuLglbCOuEQ8bgqc7ri6DO/4 niSA== X-Gm-Message-State: AO0yUKVBNyPfuB7aVRG5QmAQCWAN3QVekM4R9RQ9bxLoSaZL9qc5lKhP 0m/pq04A9EFwtAh9XT1Kfbg= X-Google-Smtp-Source: AK7set+XpckXC5WQLDxtS4BgGrLb+Xs0kyQsFLAQqOt3QndF8NQLy5QwJTjIZvnxmTae4uUBm4Lf5w== X-Received: by 2002:a05:600c:16d4:b0:3e0:fad:675a with SMTP id l20-20020a05600c16d400b003e00fad675amr17847944wmn.38.1676286242856; Mon, 13 Feb 2023 03:04:02 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i20-20020a1c5414000000b003dc53217e07sm13895822wmb.16.2023.02.13.03.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 03:04:02 -0800 (PST) Date: Mon, 13 Feb 2023 14:03:58 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 10/10] net: microchip: sparx5: Add TC vlan action support for the ES0 VCAP Message-ID: References: <20230213092426.1331379-1-steen.hegelund@microchip.com> <20230213092426.1331379-11-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230213092426.1331379-11-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_030405_132482_7F8AB16F X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 13, 2023 at 10:24:26AM +0100, Steen Hegelund wrote: > +static int sparx5_tc_action_vlan_modify(struct vcap_admin *admin, > + struct vcap_rule *vrule, > + struct flow_cls_offload *fco, > + struct flow_action_entry *act, > + u16 tpid) > +{ > + int err = 0; > + > + switch (admin->vtype) { > + case VCAP_TYPE_ES0: > + err = vcap_rule_add_action_u32(vrule, > + VCAP_AF_PUSH_OUTER_TAG, > + SPX5_OTAG_TAG_A); This err assignment is never used. > + break; > + default: > + NL_SET_ERR_MSG_MOD(fco->common.extack, > + "VLAN modify action not supported in this VCAP"); > + return -EOPNOTSUPP; > + } > + > + switch (tpid) { > + case ETH_P_8021Q: > + err = vcap_rule_add_action_u32(vrule, > + VCAP_AF_TAG_A_TPID_SEL, > + SPX5_TPID_A_8100); > + break; > + case ETH_P_8021AD: > + err = vcap_rule_add_action_u32(vrule, > + VCAP_AF_TAG_A_TPID_SEL, > + SPX5_TPID_A_88A8); > + break; > + default: > + NL_SET_ERR_MSG_MOD(fco->common.extack, > + "Invalid vlan proto"); > + err = -EINVAL; > + } > + if (err) > + return err; > + > + err = vcap_rule_add_action_u32(vrule, > + VCAP_AF_TAG_A_VID_SEL, > + SPX5_VID_A_VAL); > + if (err) > + return err; regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel