From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C247C636D4 for ; Mon, 13 Feb 2023 11:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WH4BxIRjWiMMHK7B2yMGtl8wv0pW1HEv09obdasOJ1s=; b=svBYI8w9QcgLEA vnHjdGshFeu2Y/iyk0U07hYZs4HU7r9Ju8SFrldu3ryjswxBsWh+DVanftJ57hcuK1ZPxmF6nlUHe 3mxUICN9i8pUzbJHsxKriLnygXujH4RpBk8MoHddmoE+6tTaRnokzlXRhTydz8ygI+Rp3cPVcqXYy kDiWDs7DoNiu5XesXpuEncF/T1cYDYZTnBbtEoUJcdFRRQZf3qXbGuKe/t5Pst2FAb5KzeE9aroDb vP/nAWgwGFbLt+hrhADopSQ1za3uLLuNECSJzESppVyINn1LunrGgsglGeQq2iF9/kDer8rfJWE0O VkGo/jTva0CkVnUlFhbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWeo-00EK4i-Ec; Mon, 13 Feb 2023 11:06:03 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWeh-00EK0s-IF for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 11:05:58 +0000 Received: by mail-wm1-x32e.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso11002403wms.0 for ; Mon, 13 Feb 2023 03:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UGKpDQnjHC7Urptl7Q3KiUrKg/ahx4TWIAXabQRXRA8=; b=gDCGZbYrSRwaTQ0tkvk/gx5CDElNYeN35kU8CMo20AXmrG//Tvo2WZFZtDybu9RGjt aBsK6vXWLmNXgs/PicSByCFZy0u2Rgnmotva6Yl8M1fjkejB6w5Z4uvmB8+WA7UVgC5w TB8M2HBh8mrK3tGI+5IQ4S6zR9bbBXzFtr+ko5akmvJosPe5hxtd8u2QJaply/y3a9Ev yoUi5fG4dE36eXg8ao8m2Le7lXGW7IN4HTy0YJPhDNGsdh9fL8hgY0xbP93Gn7Q6XAF8 QPytSsHF0EYPKf75rHY8Jt/1dsxofLI8LbtuReGsszO4podoPOLSdVMxEiNBa2jpJ4Fj r86A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UGKpDQnjHC7Urptl7Q3KiUrKg/ahx4TWIAXabQRXRA8=; b=rGuhVsPlfAVz5CtXGk7F0Znx4FW4ihyXdBYOoJBB13xyirUG6LasCwYXtZbIe1Vj0R LH1b2HrjPFwJF32RgPLceoNQH3mS4oaR2/Mopp6xzMHxGmf/FXgwLu2d8jap9hzArMjZ UsFgmlVkr626zJdjRx2NSpITOy+2QPYJ4KmSvarIdpgZzWyLgNeVJzPnTWj0YJoXfpEn Gu1BGe2W1qsy/bv93YqpvprejN6qgqcHr4wINnJgM8ehnuoaX6RJxttZn7lunjy+hAu4 lIWTBA4YV43pcOb19JOfI0DZJDCCEI+hZZjew60Gg6bnTjxbr2WUdrVGwisuZwbYceMA XuiA== X-Gm-Message-State: AO0yUKXjrP5n5eFhEZ3Nss0yx1jllK2XDlwV68q78ciGOmQcDMpX8KWE qmbjCm+rlvjuepNG/aS2cBc= X-Google-Smtp-Source: AK7set+mRMhuJpCUO0ku4xxTn19DfYzI5lVjsJUoBa+NlKp1todK3lAAx3VX25Mvg0A+KKaZ8V7uWg== X-Received: by 2002:a05:600c:491d:b0:3da:2a78:d7a4 with SMTP id f29-20020a05600c491d00b003da2a78d7a4mr18556218wmp.21.1676286354240; Mon, 13 Feb 2023 03:05:54 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id c2-20020a05600c0a4200b003de664d4c14sm15033481wmq.36.2023.02.13.03.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 03:05:53 -0800 (PST) Date: Mon, 13 Feb 2023 14:05:50 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules Message-ID: References: <20230213092426.1331379-1-steen.hegelund@microchip.com> <20230213092426.1331379-5-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230213092426.1331379-5-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_030555_636324_3C0FD74C X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 13, 2023 at 10:24:20AM +0100, Steen Hegelund wrote: > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c > index 68e04d47f6fd..9ca0cb855c3c 100644 > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c > @@ -1568,6 +1568,18 @@ static int vcap_write_counter(struct vcap_rule_internal *ri, > return 0; > } > > +/* Return the chain id rounded down to nearest lookup */ > +static int vcap_round_down_chain(int cid) > +{ > + return cid - (cid % VCAP_CID_LOOKUP_SIZE); > +} > + > +/* Return the chain id rounded up to nearest lookup */ > +static int vcap_round_up_chain(int cid) > +{ > + return vcap_round_down_chain(cid + VCAP_CID_LOOKUP_SIZE); Just use the round_up/down() macros. > +} > + regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel