From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99769C636D4 for ; Mon, 13 Feb 2023 12:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MqsyxK2p0yQ2I3Uv8B9Y55Oe3C5psM3l9Tuas1q507I=; b=njMLfeUUa/JtAD QOPbZcbWk4KUXDmXrG1aXYgWIQl78dSkbYI/lholh6ntsVENULJS6aTUgaK7wqBRTwYmgB8jLXSLP +7aGYzQgEWgW56oPx/MunkORNpErBn+K5fkwEbTT8PbWx9GbrcnSazoTd9QmkCCt1BT3SQzRDDf7J /kQk41TOZ2WfR81Yag8r7BbOCtKjG/OLbFnXnPZRGxXTGuR7iotMDD/qNgtQemHnEZn3Obj58snNg vQmL3U/iGRWDP0mPfBIgXQWk4k86j/4wATgQxnDrgXI2IAzv9WDsLpWPl4OSVzoH0YC5xixM8nqvT Wm3eS7AdhoGzLoOix04A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRXw4-00EdQr-8A; Mon, 13 Feb 2023 12:27:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRXw0-00EdPt-G6; Mon, 13 Feb 2023 12:27:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2Kt/ROz9GCT+psVlOSyjKfrnfI3lyNaAQ9FWHqO+GUY=; b=HdLK7ImOrfYSnVEnuS1Zbhl/tx 4kKSVabjF3tnKWtjOYv8tqBImy0Lh1rqP/nXivw3hMngCPhDJwsV4OojcLJZ1gIh3kVcth9XCidsK 7fCNtC77k2+Q05lCOkiLv/fL9RtCeZmO6rVgY6W76NBI2T0pcyeyt6yrMVbskGS788Ca8SAMCNqeN ifm6/h/8/qE7hLdaVrKdX4tmuM6IT6J9iRCyza/hPBtSu2TzsWfNmVbRP8ZcLUfj9Izfp8AkTzq7G apjcxu/L2Zn0bj4pUfQhWFjCMgx78cfDI3Lsulh5rjFzPcsj0X30wa977LA71bmpextg6Fs21Jpzu xJlJMnIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33454) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pRXvx-000428-P2; Mon, 13 Feb 2023 12:27:49 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pRXvw-0002xh-2E; Mon, 13 Feb 2023 12:27:48 +0000 Date: Mon, 13 Feb 2023 12:27:48 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v5 11/12] net: ethernet: mtk_eth_soc: switch to external PCS driver Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_042752_556974_C72294DD X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 11, 2023 at 04:05:18PM +0000, Daniel Golle wrote: > @@ -4582,6 +4583,7 @@ static int mtk_probe(struct platform_device *pdev) > if (!eth->sgmii) > return -ENOMEM; > > + eth->sgmii->dev = eth->dev; My comment on this appears unaddressed (and not responded to either). > int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3) > { ... > + ss->pcs[i] = mtk_pcs_lynxi_create(ss->dev, regmap, ana_rgc3, > + flags); This appears to be the only place that sgmii->dev is used, and this function is only called immediately after the above assignment. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel