From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E69FC636D4 for ; Mon, 13 Feb 2023 15:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CRYtVBsRs1h5j0yf1gh7NyQ9Zhm9wicDDRWvwmXeRfs=; b=gMOHtDXqsXorlX ddBP6l989NlsmrQafxo4FfmYyHQsi4HRJVVziwyJjl+Ogoy8/CVsS1svPPpbgtkNsGi/heDl/GfcD dZmrf0GRw0TwhSOZXy0gg36EKTYYJ2EW2XD2kSu55Ur2cZr9QAk6SULQwWj6k/egWRq6mO3jmLZlU BJKCPCleg3GKYo7PBFbshbxr2Lvq2E1L14knGDjAGKuc1L13pDw7HVYznS/LpkUa3gUCe1Z2kRNIE hsCfkMYMfmJlABrPBm03PxpQvr41ertuTfO6VpuamC52EWKF2EjsboZ2MWIWBZHQEuhxP3tSpYb4r IT+suTDbkyX+6Y3Y1cSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRaQX-00F7ig-Fw; Mon, 13 Feb 2023 15:07:33 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRaQT-00F7fx-04 for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 15:07:30 +0000 Received: by mail-wr1-x432.google.com with SMTP id k3so4940705wrv.5 for ; Mon, 13 Feb 2023 07:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=haFLIaedXT6lSzQN/BFfWC+Qgcnkz7HtZEKxAyIGp8k=; b=XlWFLkOjCu08JC1QX/FNmIngUGQgB/HPIysH9yuMradqS9IkNpqvLrnl8ISbLbWQJc o8EkyKdR15LDcoef2nbpm5/gRpVBzNM9qDzwMi8dZ3pSrZ5909oUaPGHIvJ1WZs9rENO 6nqD1Lp7/MCxA5eblkTdFcOiCYCR+SZDxXXhpnGFcHtcfo13iVxMt6kkO1zRkN16i5Si YNanLgnw/wTiFI1YAhdB1OjouIFcbXY2AaHXsF7vtHtdKyGMMXEz+pqywq4bHn7gFnRf RRbJn0bB5u5+iPRgHwA/1t7bD+r0a+zR/4aNaUc2zb47Qo7cfzPVd169ujd4sbgjrFf9 teIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=haFLIaedXT6lSzQN/BFfWC+Qgcnkz7HtZEKxAyIGp8k=; b=hfFPc/G3dvTSpRNZAb9GYTwMfB82goGIQVIQ+EB93N10EnvFgbbO+KmmQz39fRInGe SFfzDvyZ1OEdPx/wE+MKX5pvw1dsyIu+kbelbCmkuUKcMmhDkmLCEzKCXF+VVJxN7TGA Q88hwSS4wc1zUz4CYs6sz2Q1p+DmdaiDHBZc+P/NZn4en+lW1xX4jcdFDz54ouLv3zAE k9g28WHv5WrSAikATcTvyjT0gCO4oIYOG0z9ucGLdLlBh1MV+ZI+25Txa/e341YwIK72 riyh6s1TmrCuE1XrNL4ku5dHHYosKLZyOI+JEEofVD0a7QjfdRGOkTjvc5FKTCi7rOs6 SWSw== X-Gm-Message-State: AO0yUKVx0feXuu4BQC/BQRd0ZCtMyoDlcdP7B5OVq6IchxpmMTBsIzo+ lk+LJae7t2ck2RnuE6fgbK/h8sfnK08z4k/Q X-Google-Smtp-Source: AK7set+GIguYmobmwx3+S2MT+Q9stky3DoNFwgoGxedt3sX/HAnAJTDBVDrKyp52mZ7CQP3xPMfrHA== X-Received: by 2002:adf:fdc7:0:b0:2c5:5836:4e1b with SMTP id i7-20020adffdc7000000b002c558364e1bmr3759794wrs.60.1676300845751; Mon, 13 Feb 2023 07:07:25 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id j16-20020adfff90000000b002c55efa9cbesm1239308wrr.39.2023.02.13.07.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:07:25 -0800 (PST) Date: Mon, 13 Feb 2023 18:07:21 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules Message-ID: References: <20230213092426.1331379-1-steen.hegelund@microchip.com> <20230213092426.1331379-5-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_070729_057325_704DFE11 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 13, 2023 at 01:48:50PM +0100, Steen Hegelund wrote: > Hi Dan, > = > On Mon, 2023-02-13 at 14:05 +0300, Dan Carpenter wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know = the > > content is safe > > = > > On Mon, Feb 13, 2023 at 10:24:20AM +0100, Steen Hegelund wrote: > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > b/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > index 68e04d47f6fd..9ca0cb855c3c 100644 > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > @@ -1568,6 +1568,18 @@ static int vcap_write_counter(struct > > > vcap_rule_internal *ri, > > > =A0=A0=A0=A0=A0 return 0; > > > =A0} > > > = > > > +/* Return the chain id rounded down to nearest lookup */ > > > +static int vcap_round_down_chain(int cid) > > > +{ > > > +=A0=A0=A0=A0 return cid - (cid % VCAP_CID_LOOKUP_SIZE); > > > +} > > > + > > > +/* Return the chain id rounded up to nearest lookup */ > > > +static int vcap_round_up_chain(int cid) > > > +{ > > > +=A0=A0=A0=A0 return vcap_round_down_chain(cid + VCAP_CID_LOOKUP_SIZE= ); > > = > > Just use the round_up/down() macros. > = > The only round up/down macros that I am aware of are: > = > * round_up - round up to next specified power of 2 > * round_down - round down to next specified power of 2 > = > And I cannot use these as the VCAP_CID_LOOKUP_SIZE is not a power of 2. > = > Did I miss something here? > = Oh wow. I didn't realize they needed to be a power of 2. Sorry! regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel