From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87EAFC636D4 for ; Mon, 13 Feb 2023 15:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pA1FLLljDLV56gksXb+n8409NyDK7tgbop/janHvJvE=; b=1La+sn4jZW5nT3 st0IEjelx6++KFevY68Qp906PJYHV7VL5KkRyBMUQirsVaEG7fF7h5QACBuS+1s9c4nY9TP3Utwpa UY5h72fZ9XQ1xOAulYU5n3FA9ilUVmg9eYG9aoMzN58m8RP+6Ui9jpJTr8YpDN/PNdkRg/nanFzkR U5TZPeMWw69Dp9SLozkN6XKaveUJ+aViS8yZt88/9OsUWrDjGykSTOPZBmxJZRDZ7UaeCUn7HrD3P vE4ik4yB8ahLhs0Y59EBFvcKk7mqDVzQApMIiXQmkjPiS6DRYS/C7x3UYyWRH03UTD+LJchOOb418 EZIo5KJwEvJ8TzRDH/jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRavf-00FFaX-Kt; Mon, 13 Feb 2023 15:39:44 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRaur-00FF8t-9R for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 15:38:54 +0000 Received: by mail-wr1-x430.google.com with SMTP id j23so12724241wra.0 for ; Mon, 13 Feb 2023 07:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ER9L7/5f6uhjVfYElKZx3OXqKvldiL4xUMIV23nwQNc=; b=iv00oCWzVD1NDSXIFt8NcEMQr4yBbt/juRAurfKe7FMe/Bj1q4d+POBDxUGm/fVwr9 gflQuE2ZVeYGZ2Sv9+9coeUC+WguejAz/ZcEsMLtNU/NJ5IG2KfcgW6LL3vW3Cw5Co39 hwEWxWQ/O07WTYcuy8SBNziZe+QGNTGsifZzrGwbe28Mbr85fl/4uKSBjJ5FonYhLReA IZ6YEKqeZo2u5PuB/GcRxTs+ElMDsK5jJUzt7uyWaQz0kzGN8HTeHs5Hr8iy9PASFJuJ KWoh9IDhUx/gBieAL+c9oL2mC2Rm4zMwK3iYI7vnIj6fSq2XifiroqpkoMPcIKO2Du4j P8mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ER9L7/5f6uhjVfYElKZx3OXqKvldiL4xUMIV23nwQNc=; b=x0DcY8PvTzwqVHKQ6VAWVCBGvCk6JrL5GvM+8KXfD4qSQE+knsGj/7lTq28r/JJJHc IB+m7OROxH9hjYVVlhfk4UU9Tzmjw/MFdVIWIdj5zuKCAGGG9HQvvIrqE6STXx5IHQZg fCIjh7HdbwS3dzCIoY+HIP2bSHeMjXQoPcLlpQxsgUt+930+uGj5qEduUsPFE7XIpkkV Pq7gUVK7KwiRVSwGLNyjJ5n5xQA9/uEY8wqW0lPbeWTWBpjowelnTAzufdyErBLJw0iO yFCEclGLdCeFaOn53oTAnb8dtZy3jgGRqoP5wtRTce7Lo3GMnfix76tnaCn6FGj6Nr21 d9Ng== X-Gm-Message-State: AO0yUKUxr/50fpRfg2kKJqgj3DsBRcxBI/3v4njS2plTEfhGyfMPBX6V 77mc6OzHstGNvDLWS2KuQXY= X-Google-Smtp-Source: AK7set++2HAyahiB/cBZCB/rt2m3nNZCnWeeg5Ei9l17cqJPnCaJa82xRIoIFlQErcTIy50N93pOJA== X-Received: by 2002:a5d:5904:0:b0:2c5:4c32:92cb with SMTP id v4-20020a5d5904000000b002c54c3292cbmr7720483wrd.54.1676302729330; Mon, 13 Feb 2023 07:38:49 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id x1-20020adfffc1000000b002425be3c9e2sm10894869wrs.60.2023.02.13.07.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:38:49 -0800 (PST) Date: Mon, 13 Feb 2023 18:13:25 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules Message-ID: References: <20230213092426.1331379-1-steen.hegelund@microchip.com> <20230213092426.1331379-5-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_073853_396944_42FD0023 X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 13, 2023 at 06:07:21PM +0300, Dan Carpenter wrote: > On Mon, Feb 13, 2023 at 01:48:50PM +0100, Steen Hegelund wrote: > > Hi Dan, > > = > > On Mon, 2023-02-13 at 14:05 +0300, Dan Carpenter wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you kno= w the > > > content is safe > > > = > > > On Mon, Feb 13, 2023 at 10:24:20AM +0100, Steen Hegelund wrote: > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > > b/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > > index 68e04d47f6fd..9ca0cb855c3c 100644 > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c > > > > @@ -1568,6 +1568,18 @@ static int vcap_write_counter(struct > > > > vcap_rule_internal *ri, > > > > =A0=A0=A0=A0=A0 return 0; > > > > =A0} > > > > = > > > > +/* Return the chain id rounded down to nearest lookup */ > > > > +static int vcap_round_down_chain(int cid) > > > > +{ > > > > +=A0=A0=A0=A0 return cid - (cid % VCAP_CID_LOOKUP_SIZE); > > > > +} > > > > + > > > > +/* Return the chain id rounded up to nearest lookup */ > > > > +static int vcap_round_up_chain(int cid) > > > > +{ > > > > +=A0=A0=A0=A0 return vcap_round_down_chain(cid + VCAP_CID_LOOKUP_SI= ZE); > > > = > > > Just use the round_up/down() macros. > > = > > The only round up/down macros that I am aware of are: > > = > > * round_up - round up to next specified power of 2 > > * round_down - round down to next specified power of 2 > > = > > And I cannot use these as the VCAP_CID_LOOKUP_SIZE is not a power of 2. > > = > > Did I miss something here? > > = > = > Oh wow. I didn't realize they needed to be a power of 2. Sorry! The correct macros are roundup/down(). Those don't have the power of two requirement. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel