From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F6E1C636CC for ; Mon, 13 Feb 2023 15:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G3oIMEbvHFQX1cBhkr1VYgN4o5dodNZ3HXX466f/z6Y=; b=5Bw8PEq1l2O+7O XMm0G6Z1XZ1vN/HLYvAXwveFyDp4qqD9oaXhamBel/g9FAedLdb3eH6sQcAPvlyVplAlbbEyBmvqc NucCZMB8/e7H0g0tKrrDIU4INLm3HmWBijdbZpjxDOL9CyYR7CmcIe/GuYuW19mTjWbfCGa9Q/NDR X9g3uDpJViPahJ+CcxCD7eQn6rzI235ymIeeUBSnA9xUjjM8kyVXRM9wePb+6V8P9D3cuVKpYL0s1 zLKKyXfWqrdKSfSjd9vqlMRC+Wln7S6E82XC19ZUhFH/4j9W0h5mX4Fb1KlqIN02dq2jBSwmyvRCB oCq/qf2i9kWBdfj2Ppxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRatA-00FEit-Er; Mon, 13 Feb 2023 15:37:17 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRat8-00FEgw-2z for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 15:37:07 +0000 Received: by mail-pl1-x62a.google.com with SMTP id ja21so6277626plb.13 for ; Mon, 13 Feb 2023 07:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b6CbHZgVu581b1kpbiWv3nRa+aQ1/ZXT+MQVUlqtRFg=; b=pEH4a2cNcp+iU0rZP+xPv6deo4b/2AIkO0DLOBo0ZLFyrYsyMt4C3A1kCYsiwS+YQE 62VVo10wQW9iH02plX08czAlafCzRsNyRdBI+2kZSoa9AxYrWF9tURFi019LNtyBNByw 0orb8j6cueSHwxygMEDtVZVnzh91IEdRKbv22kmtywCxuJ83EdUV7ghG2gA8QFgQ7gDs tcLnKRAA5Cq5cZ11IcmhZ04iEw5Vqp6Y3mJQSRc1zEt62CbLAdNzT09W0VapHLBwtIE6 SFcVuFmm0JoLrifqo/tuwbRawC9RbRg2HIGIOz7iMLZ4RUEG/gz/qLdoMZpH+Mbm1YEN bgAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b6CbHZgVu581b1kpbiWv3nRa+aQ1/ZXT+MQVUlqtRFg=; b=hBPfO9M8HVdO66U4f+i4YNgJ1zdmFt0OeTZ5Nud6X5LgF7Iw/Nxrb14TfMuTt1TbiX N8P2MXIPUF/yG0xGqKCUtTbN6ZrEy2XWzkbT1y70g1Z6U+QZBLZuiFaUMYQvt/7E/tgS wBXOXWFfZjteCRKwGLsfunu0fZtr0VzpLc6eTuM77K/GzjOU/RabgzA3r+fLkgpjQiua 3pStkP7YB982YgMFnYUDr3KXA8L1LYOGiIsVTAoZsokF6eMM1YkJG0USJnMBZR5xUW96 koN1PDeDfvS43txiuZ3BDErRznMCDah5PPleGmZEnLUZ662w2MU7S5kSBN3IMO+tjQEn fEGA== X-Gm-Message-State: AO0yUKUM0JP2tbocSHGe7mEn6i8k74apeQ6yM4zWcswRtkL1THr/Pmo7 kBl/r/UslY6ti160KfWw/9vAxQ== X-Google-Smtp-Source: AK7set8dKx5P9Hgy5FMcBhM5YT9HLmTmVXFXC6zApAbnhBc+IHN95yI1sjydVL/fWr6sZFUiQqTBGQ== X-Received: by 2002:a17:903:4094:b0:198:af50:e4e3 with SMTP id z20-20020a170903409400b00198af50e4e3mr421077plc.9.1676302616875; Mon, 13 Feb 2023 07:36:56 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id e9-20020a170902784900b00198f9fa23a3sm8301318pln.287.2023.02.13.07.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:36:56 -0800 (PST) Date: Mon, 13 Feb 2023 15:36:52 +0000 From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , James Morse , Suzuki K Poulose , kvmarm@lists.linux.dev, Akihiko Odaki , Zenghui Yu , Raghavendra Rao Ananta , linux-arm-kernel@lists.infradead.org, Salil Mehta Subject: Re: [RFC PATCH v2 1/6] KVM: arm64: Add a helper to check if a VM has ran once Message-ID: References: <20230211013759.3556016-1-oliver.upton@linux.dev> <20230211013759.3556016-2-oliver.upton@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230211013759.3556016-2-oliver.upton@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_073706_156160_697E6AF8 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 11, 2023, Oliver Upton wrote: > The test_bit(...) pattern is quite a lot of keystrokes. Replace > existing callsites with a helper. > > No functional change intended. > > Signed-off-by: Oliver Upton > --- > arch/arm64/include/asm/kvm_host.h | 3 +++ > arch/arm64/kvm/pmu-emul.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 35a159d131b5..012e94bc9e4a 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -1019,6 +1019,9 @@ bool kvm_arm_vcpu_is_finalized(struct kvm_vcpu *vcpu); > (system_supports_32bit_el0() && \ > !static_branch_unlikely(&arm64_mismatched_32bit_el0)) > > +#define kvm_vm_has_ran_once(kvm) \ >From the peanut gallery... The ONCE part of the flag+API is unnecessary and flawed from a pendatic point of view, e.g. if a VM has ran twice... What about kvm_vm_has_run() to align with a similar proposed x86 API for individual vCPUs[*], if either one ever gets moved to common code? [*] https://lore.kernel.org/all/20230210003148.2646712-3-seanjc@google.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel