From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF657C61DA4 for ; Tue, 14 Feb 2023 11:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e7/KI/RrpZpcnzRQvFI226fB9jHaFjwjBUuOzAmQj5Y=; b=oM+xVpIooZr3ps bbwA4GdguTZSlTV+oRvd+PGe5X3w89kzF15YmGkGohjJgRLfsF2IkQyZOsCPshjcOwcA3i/ff1P9p +LeyD6ubNdhDp6mcRqQsuORYa+W4e+6F0fwXybzgL+df/F/JqElBvU0ZFUXzZS6jNmYyd8PPEV7au cyDQ0d7afFSFe/30FeJHGF2PAB80etEWhi3qdC+KBMnChSu8Tn9SEmv0xv6OvVfA2TijSFZrjCf2r BrERXPvFDKObqtfY/EftMREDiew9qaql5yFV6SkxAaszZnWQT2YVojwtuPtShZife6WaXtGmIigYX 9ae8fqRb5rWyQMSwCcUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRtvD-001TuQ-W9; Tue, 14 Feb 2023 11:56:32 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRtvA-001Ttj-Ba for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 11:56:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676375788; x=1707911788; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NnoMqJ3mzErGTLdKzrq/8ekrEyt2dHs+nTMsB9dzFOs=; b=nI6P2cKOqY234v9fY+XmYRgiPBXMRkLc94jRh7zCDfuqvH4jze3VQBIO nIpGJ3cyGXEAitcKGDNKEmEVZ/MLqMUdyxG4+lv0J/gRGhdSCy2KwEJPm 63JPjRUc+mPqdm2QNe1u5KsSFDbjNwU0sIbk5AKKLEkqxA10DcpsNeuBc tC3RPZHYN6RpCNQv7y2tBUr6SJ3H3mEk6WccD0zTD8NMiNA1ScJWwMwtN rBSw6uTsHs8CAyGdNujVfBerYhOc5IGWERitb4ZVaoW2qUTwkw2TFnZxn jiHX/IhpCS+DoMM8sTi+vgP42ZBtPcLkWftecpImdWs86Bv/s6UCLLpfp Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="333279525" X-IronPort-AV: E=Sophos;i="5.97,296,1669104000"; d="scan'208";a="333279525" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 03:56:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="811996408" X-IronPort-AV: E=Sophos;i="5.97,296,1669104000"; d="scan'208";a="811996408" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 14 Feb 2023 03:56:05 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 14 Feb 2023 13:56:04 +0200 Date: Tue, 14 Feb 2023 13:56:04 +0200 From: Heikki Krogerus To: Neil Armstrong Cc: Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/11] usb: typec: ucsi: add PMIC Glink UCSI driver Message-ID: References: <20230130-topic-sm8450-upstream-pmic-glink-v2-0-71fea256474f@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v2-1-71fea256474f@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v2-1-71fea256474f@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_035628_527228_208E507E X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, I'm waiting for that other series that this depends on, but in the meantime, there is one thing that has been bugging me... On Fri, Feb 10, 2023 at 04:02:04PM +0100, Neil Armstrong wrote: > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c > new file mode 100644 > index 000000000000..9123f8a571e7 > --- /dev/null > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c > @@ -0,0 +1,320 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022-2023, Linaro Ltd > + */ Is that correct? Shouldn't it just be: Copyright (c) 2023, Linaro Ltd and that's it? Otherwise this look OK to me. thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel