From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 173A1C4332F for ; Wed, 19 Oct 2022 13:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SDy1AMWCpFdrxJgyElDKMYXnQEGXFXXB0ill70yGQdQ=; b=YRPbf1CIPkzu68 uK5zClHhcDFkmQGmvK49z04FUZOC1GTu4q3XEFionXTplPP9Y6bdVJbyyK9cS0WpwiFTUuqBP2CxN oJat8qCx739BOU4Bs5WnvT6J0+y91zZD6rqQQX5bhF9k8V1siukbW1HtIbBEXBkeq5VS/SydpX6po xtgSp6nYW3loHCFP1Himzx/iLIi6OGlzn7g2hlAIdKR26lUuw64FdoNV9T3tQ64+S5W22bQHoiZXY XMeVsjLxhq0FVQ+zTpyepw+y2DZHRwQN1mVaDih9EBXARstPCSTwid+5scgOXwRyM6+YlUow1qlby 4hOZErW8ZqpY1zlekSFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol9E5-002ADV-3B; Wed, 19 Oct 2022 13:35:17 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol9E1-002AAl-Fi for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 13:35:14 +0000 Received: by mail-ed1-x534.google.com with SMTP id a13so25344136edj.0 for ; Wed, 19 Oct 2022 06:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jGDuBvVBWtQQhTh15f+xlFUiPdaWSbx11jMCTBh0luA=; b=PxTuqiFHKGLs6Q04zg2G4eSd00jK6zzgrt4HdFyWkirB8aCwSWFmJDbb4XEBPbs84b XjeLDlepBSGLM9yuvsYFtIMpaA2nrkP9RseT+JMyFrkJmTtNG6S7IBl+ZFb+Z7EU964K 51qHIrDOsh043I6Y6V8E1g4XMUP9UGgmtMVCorWtgXXr8Ez+6KCd5ZzkSfC1vBvU0cH1 djCo4kPBwtzeKGV/O9N2hFeEJoYjXLSvmvYEL25wdP7p2Tf7hgW6O1nT+5fEjsm/qMk2 LLG+qdTEOncIhwY/g1cG4Fb+GhzkkvlzTi4NT6ZkssFxxTJuSnyH4YRDTPFp3De08sQ/ Humg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jGDuBvVBWtQQhTh15f+xlFUiPdaWSbx11jMCTBh0luA=; b=ojeo9ySo6+n9axGjGgNW2aE1tdlUVUt6PCBro4DxIVkexJkWG87cZQqYbJ4kr2l7lw 0Iql6GBCgLJESezZsigo9Nx5AwLhXFs6rcqD0PUeYrGgqVezzzlEB865aprN4tJq0JGf RWs2oAJosAW7JWsBCFdEAKB+tX8mM5N4Gymv8ZokHiY50eE9DaNUrs9HmMRpFmWKVfQT hM9ZPKi0PVVnwu9aZxVFFYUO3dnWPdorhB0lioWILNoPBpj9cTNJXtKbUjGqeCSjesWh 5ruCh8ivuImPiXdNksclKGXwmjvGkIWmSUuNzRK4onU0tHNRoisiNGJg/GQmPICYgRu3 4Gig== X-Gm-Message-State: ACrzQf1McEAIGBXuYrioNFdntrWYl6W5lM45jCKT2Wdl9vQZkbiXVBrS NaAPczO4Od6waw+KoO0RBaz1hQ== X-Google-Smtp-Source: AMsMyM5/lmcijk1PTC/MIbN3EcbOaf5vqEsarZQ2QfOuX/8iQ6m+Bp7SwPos1MPS6rC1Qfj/aMnvQg== X-Received: by 2002:a05:6402:5ca:b0:445:c80a:3c2 with SMTP id n10-20020a05640205ca00b00445c80a03c2mr7515578edx.247.1666186508675; Wed, 19 Oct 2022 06:35:08 -0700 (PDT) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id d7-20020aa7d687000000b004580296bb0bsm10538281edr.83.2022.10.19.06.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 06:35:08 -0700 (PDT) Date: Wed, 19 Oct 2022 13:35:05 +0000 From: Quentin Perret To: Will Deacon Cc: kvmarm@lists.linux.dev, Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , James Morse , Chao Peng , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 12/25] KVM: arm64: Add infrastructure to create and track pKVM instances at EL2 Message-ID: References: <20221017115209.2099-1-will@kernel.org> <20221017115209.2099-13-will@kernel.org> <20221019115723.GA4067@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221019115723.GA4067@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_063513_565092_8FE59E6D X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 19 Oct 2022 at 12:57:24 (+0100), Will Deacon wrote: > On Tue, Oct 18, 2022 at 04:33:45PM +0000, Quentin Perret wrote: > > On Monday 17 Oct 2022 at 12:51:56 (+0100), Will Deacon wrote: > > > +void pkvm_hyp_vm_table_init(void *tbl) > > > +{ > > > + WARN_ON(vm_table); > > > + vm_table = tbl; > > > +} > > > > Uh, why does this one need to be exposed outside pkvm.c ? > > We need to initialise the table using the memory donated by the host > on the __pkvm_init path. That's all private to nvhe/setup.c, so rather > than expose the raw pointers (of either the table or the donated memory), > we've got this initialisation function instead which is invoked by > __pkvm_init_finalise() on the deprivilege path. > > Happy to repaint it if you have a patch? I don't, I just got confused, maybe because in an older version of this (possibly quite old) the table was statically allocated? Anyways, it's all fine as-is, thanks for the reply. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel