From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79F09C433FE for ; Tue, 18 Oct 2022 11:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZyTISxL8roGttLuTLHN3VnZYiXLfp11UALXjWQHEltg=; b=xO71SZUbiboo3iVIi6Zm+e0b50 i3s7YHfzxw7ay9nIL4coQ7F9zkdCHlS/RhEv7z9EiiseOcAQLR2VbH7rkBqWmuZYtq1ml9dgeQx8H 0aWasgBwwvaIHCsuhE+KXGk1PeDm0oCU7+cM5m9uwob7HxLhn8afcTa5Dp22X2jlQMkZTDgqv2H0j MpcYI9LO2+pBR3fjIq1tnpgfeHfrBW6EJYEQ4EuFSJCHdow36q27ad/NpfvnufghKJY7EIc1mksWJ R0jtSySK5xtf0DYW7ETLh3uLCgN3Q7CEmm8uLIBuVWMv/wR45n6V0B+UI2yV2hNXLgO5dy9VuXSNW WROaxubA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oklAZ-006MAg-Vx; Tue, 18 Oct 2022 11:54:04 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oklAW-006M9u-Ju for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 11:54:01 +0000 Received: by mail-qt1-x82c.google.com with SMTP id a24so9414708qto.10 for ; Tue, 18 Oct 2022 04:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Jk0jo8h+bFKZZlklplQl3c4m7akalQuwqDchYrGv+m0=; b=vizGrCCqg9RquslozbYx0axYr5kAXiYgqZalRmhoLNFRoinFMu2jkK7AqdvVoC+/fU Mq6x1snsy2T6ky0crXRLuFzSGKtvI6D6FhEU4WN2XjcIwNPPtJaQzr+J630meY9QxpNN NV68HQ7ofumTeJnP5Vvw9IMFM2ODAX1hCARtGUYvu73QQgf181+oOTrE3wBkkFNMUTNV Q8vd+WO+DIoLgDKsWw0e3oYbNDrjdc6NV8EbGw1IaQAN7ebt5MovBDIlrNu3/w3MzTIs YNnmIDfL15Jjphg1ToAIRcYR9LarivoIeqRfumpdAxrGvh60HgcMBsR1FoTHCPBQjzYj m2Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jk0jo8h+bFKZZlklplQl3c4m7akalQuwqDchYrGv+m0=; b=btjzpHYyM67gwwfksKAbUOVfb7RjF2pw+kZ5xp/EPe8iJFE9HFQl03yTNi8P5eCksu 02nVmwHSvTxTG3Dz05qoRXyHgc68U3sZ9W6q1YOQZIFCRPWKSw7P4gsS900rQiuW3d9N BXLEYFZLq9MFEs0cZymvaFEMDH9sSCS2dxu3tResO/eKUF2Z+GbUaFLTxi5NljMZzfsf /ov16rCQ7o8y87V0Owfoz+gvjZsUh9jaCrWFWInt4T5TDrK/q+1Pktk0JBJd+ckaCKBI WXViMx1HDu7GIPbCIkqe1pPvgG5K93WeEjK8RBxBxZ9u+17gNhlRUa59SyKkTo5TUY2c EAnA== X-Gm-Message-State: ACrzQf3HyBjDycMJzHVl5VfS+2PMP66gq4Defaxcw68CtKXxDCD69EBQ 4+7H6Zhu4XjNdjjexICtzVB/lw== X-Google-Smtp-Source: AMsMyM7TOGVWHULqQc1ZHTl5rnpC3Bf7tYz+BXWszc6yjpvbv81WnehjVeT5hwgn0edgY4jq8Tsw+A== X-Received: by 2002:ac8:5814:0:b0:399:39ca:fd63 with SMTP id g20-20020ac85814000000b0039939cafd63mr1719677qtg.0.1666094039028; Tue, 18 Oct 2022 04:53:59 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id s7-20020a05620a254700b006ec59941acasm2306305qko.11.2022.10.18.04.53.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 04:53:58 -0700 (PDT) Date: Tue, 18 Oct 2022 07:53:56 -0400 From: William Breathitt Gray To: Kamel Bouhara Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] counter: microchip-tcb-capture: Handle Signal1 read and Synapse Message-ID: References: <20221017225404.67127-1-william.gray@linaro.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_045400_684349_979F8D78 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9081431776288767687==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9081431776288767687== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v/w0JJUH87vcSvz3" Content-Disposition: inline --v/w0JJUH87vcSvz3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 18, 2022 at 10:13:51AM +0200, Kamel Bouhara wrote: > On Mon, Oct 17, 2022 at 06:54:04PM -0400, William Breathitt Gray wrote: > > The signal_read(), action_read(), and action_write() callbacks have been > > assuming Signal0 is requested without checking. This results in requests > > for Signal1 returning data for Signal0. This patch fixes these > > oversights by properly checking for the Signal's id in the respective > > callbacks and handling accordingly based on the particular Signal > > requested. The trig_inverted member of the mchp_tc_data is removed as > > superfluous. > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > Cc: stable@kernel.org > > Cc: Kamel Bouhara > > Signed-off-by: William Breathitt Gray >=20 > Looks ok to me, thanks. >=20 > Reviewed-by: Kamel Bouhara I'm going to submit a v2 of this patch for the sake of making it a tad easier to backport and also simpler to handle if a lock is introduced at a later point for this driver. William Breathitt Gray --v/w0JJUH87vcSvz3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY06T1AAKCRC1SFbKvhIj K0QkAP0eR9cEPryA2x+IYRDR8FXE90r5QvhWhohD8jKEagih1AEAlBK3gRZN7Z+z jCnv2ybWps4ZW+XReDxJQqiXk7ydqwo= =P23b -----END PGP SIGNATURE----- --v/w0JJUH87vcSvz3-- --===============9081431776288767687== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9081431776288767687==--