From: Brian Norris <briannorris@chromium.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Faiz Abbas <faiz_abbas@ti.com>,
NXP Linux Team <linux-imx@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>, Al Cooper <alcooperx@gmail.com>,
linux-mmc@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Thierry Reding <thierry.reding@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] mmc: sdhci-of-arasan: Fix SDHCI_RESET_ALL for CQHCI
Date: Tue, 18 Oct 2022 09:59:44 -0700 [thread overview]
Message-ID: <Y07bgNd7KbLDttsq@google.com> (raw)
In-Reply-To: <e7816e4a-8558-0de0-e25f-d10abd0ef1c3@intel.com>
Hi Adrian,
On Tue, Oct 18, 2022 at 07:13:28PM +0300, Adrian Hunter wrote:
> On 18/10/22 06:57, Brian Norris wrote:
> > So like these other patches, deactivate CQHCI when resetting the
> > controller. Also, move around the DT/caps handling, because
> > sdhci_setup_host() performs resets before we've initialized CQHCI. This
> > is the pattern followed in other SDHCI/CQHCI drivers.
>
> Did you consider just checking host->mmc->cqe_private like
> sdhci_cqhci_reset() ?
I did not, although I am doing so now.
My first thought is that this feels a bit too private. Is the host
driver supposed to be memorizing the details of the CQHCI layer?
But on the plus side, that would remove some contortions needed here
(and also in sdhci-brcmstb.c).
Here's another option I previously considered: teaching
cqhci_deactivate() to check cqe_private itself. That would have the same
benefits, while keeping the private details in cqhci-core.c. How do you
like that?
(Tiny downside: cqhci-core.c got its rename in v5.12, so backporting
this to -stable would get slightly more difficult.)
Brian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-18 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 3:57 [PATCH 0/5] mmc: sdhci controllers: Fix SDHCI_RESET_ALL for CQHCI Brian Norris
2022-10-18 3:57 ` [PATCH 1/5] mmc: sdhci-of-arasan: " Brian Norris
2022-10-18 14:26 ` Guenter Roeck
2022-10-18 16:13 ` Adrian Hunter
2022-10-18 16:59 ` Brian Norris [this message]
2022-10-18 17:58 ` Adrian Hunter
2022-10-18 3:57 ` [PATCH 2/5] mmc: sdhci-brcmstb: " Brian Norris
2022-10-18 3:57 ` [PATCH 3/5] mms: sdhci-esdhc-imx: " Brian Norris
2022-10-18 7:22 ` Bough Chen
2022-10-19 21:56 ` Brian Norris
2022-10-18 3:57 ` [PATCH 4/5] mmc: sdhci-tegra: " Brian Norris
2022-10-18 3:57 ` [PATCH 5/5] mmc: sdhci_am654: " Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y07bgNd7KbLDttsq@google.com \
--to=briannorris@chromium.org \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=faiz_abbas@ti.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).