From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07CDAC4332F for ; Tue, 18 Oct 2022 17:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=364SaGdQZD8qtTJNp9nwvmzJMCRgNB30giiLRSCoqU0=; b=n7qVWH1VegrB29 h5oXukIw4xqDmbQPpIRn8XtKpsjgkG//ohQ3lPA5wKES9aoipNkVmoXhRPupaRX1BAMy6F/ysPC35 4RULCfv4s3eEC0H3+XVzHRBnyRKnSsJWqhG9wYvCqtlCgST6EV/Tc79U5KZMCWbMg16XwHJdVWXua h3MDHkzh/+nNeGyWfjdLLrX8L15w8rDUJSSeAlRLkWUh3kTrVojR5WmEXrvjcM7CU3D0tcSILHPjw ZnlRicBrsywZLV9k9Y7pUY2TYyPmBoywxE6mOqoEhPp8u6EEBDCI3Zr0DqcYi7monspCXubJlfOpp KCrHtsuF4irfYEM69Jpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okpwX-009Cmf-OD; Tue, 18 Oct 2022 16:59:53 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okpwV-009CkO-1Q for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 16:59:52 +0000 Received: by mail-pl1-x634.google.com with SMTP id l4so14405716plb.8 for ; Tue, 18 Oct 2022 09:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b0l2HZlOZuWdOYo1ROWax2muHI31wxqlPHYjTm43zec=; b=PcuH5Qmpe7v1S++KPeobFTZuJ1OT0/3Mf1vuV/rdjGtACw7E4w3+aC1KCXZssWFge0 Iu/XPMhvL7F3sJqOR9h/GULUOS/0uZqUKxnUNQDvMcW6zADq97FjU9tKTbOUREhVCPsY sjzU+3CIpByK647KAuTGK+9fz5B+ME/WdZ1E8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b0l2HZlOZuWdOYo1ROWax2muHI31wxqlPHYjTm43zec=; b=zMM0TOgkEilS0GKkb/gZ/JWdOhyUq4ZYkSNlXKWj75lNhMZkSntJQ+MOEikg5Lb80g czGOBfPl2vm2Ys3xU12BGzTPnRNC3otEkJzJlkTMFXpXwzM8KZBu+lRqZDCyMs+jpjrw T6usVMKqVzp+RIAFs3kFNqhdU73VmNbV+LlTmwswLIrjCzNhs6vZH6Xzqaq6UOYc8895 FYj7uBsO5EvNtTUl1ieu1GnkHgnhcBywTApTfWZk5hkCLLj+0V86BxcVaSwlmn8n8klO pVGOiB/cCG+XJMjGv0jXDff/NH9pFkMviN6o3tN9uJjCNfzkd8OGUm4EOa2WZGb53PHG fU8w== X-Gm-Message-State: ACrzQf2k29kd4yQTs7svECh/hGjkxy6x1CFQ6GxBUHZgp6c7iHppDCcq jXB6SL82buImN74GvcBoN+/XSg== X-Google-Smtp-Source: AMsMyM6Rlzv5RCnrpSOJBD3bV+5CLiPqwDe1Lc9YkBbLohQwy95ZHPsRszbYr/mpVmfAeOr1YrsZkQ== X-Received: by 2002:a17:90a:c90c:b0:20a:7179:b14f with SMTP id v12-20020a17090ac90c00b0020a7179b14fmr4574348pjt.58.1666112388295; Tue, 18 Oct 2022 09:59:48 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:2ac3:f4e2:e908:c393]) by smtp.gmail.com with ESMTPSA id w11-20020a170902ca0b00b001782a6fbcacsm8888930pld.101.2022.10.18.09.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 09:59:47 -0700 (PDT) Date: Tue, 18 Oct 2022 09:59:44 -0700 From: Brian Norris To: Adrian Hunter Cc: Ulf Hansson , Shawn Lin , Shawn Guo , Fabio Estevam , Faiz Abbas , NXP Linux Team , Haibo Chen , Al Cooper , linux-mmc@vger.kernel.org, Pengutronix Kernel Team , linux-kernel@vger.kernel.org, Florian Fainelli , Sascha Hauer , Thierry Reding , Michal Simek , Jonathan Hunter , Sowjanya Komatineni , linux-arm-kernel@lists.infradead.org, Broadcom internal kernel review list , stable@vger.kernel.org Subject: Re: [PATCH 1/5] mmc: sdhci-of-arasan: Fix SDHCI_RESET_ALL for CQHCI Message-ID: References: <20221018035724.2061127-1-briannorris@chromium.org> <20221017205610.1.I29f6a2189e84e35ad89c1833793dca9e36c64297@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_095951_099251_0D72BFEB X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrian, On Tue, Oct 18, 2022 at 07:13:28PM +0300, Adrian Hunter wrote: > On 18/10/22 06:57, Brian Norris wrote: > > So like these other patches, deactivate CQHCI when resetting the > > controller. Also, move around the DT/caps handling, because > > sdhci_setup_host() performs resets before we've initialized CQHCI. This > > is the pattern followed in other SDHCI/CQHCI drivers. > > Did you consider just checking host->mmc->cqe_private like > sdhci_cqhci_reset() ? I did not, although I am doing so now. My first thought is that this feels a bit too private. Is the host driver supposed to be memorizing the details of the CQHCI layer? But on the plus side, that would remove some contortions needed here (and also in sdhci-brcmstb.c). Here's another option I previously considered: teaching cqhci_deactivate() to check cqe_private itself. That would have the same benefits, while keeping the private details in cqhci-core.c. How do you like that? (Tiny downside: cqhci-core.c got its rename in v5.12, so backporting this to -stable would get slightly more difficult.) Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel