From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63FFDC433F5 for ; Mon, 10 Oct 2022 00:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wNOqayWSQ1mldx3Xw4EfUbsPvBWnZlUPbKphAyAsYaY=; b=pXfV8uG8PR594J Du4fpbZv6zXFlTWJLeXBD2I4C98a9ujFPFEzbgwJkjOr85c9+JPuEddxYy7s0fhcuzSOy5GrUDY8d AGzFHt8JzAPn+o8nPikRXkcZFQN6r8M1uYxDtjQ0uUECQtgFtIDJ7pyZuvZKDzlzD3qEFK/pcrFdB krRO8DH7pUZ0G5UjYTBKfmlPAAZRNEQGOaZOFPb5JNOT58HBZykSb24e/yvXnIZaFJEcZNYMGiMIX rR1OoasayByt31coukLt1OELgAIXOip9FkS7vFQ/c2WdPcIkSwU7/2AIu+dcHHS+KO3gathw5PSeQ vVFQFvZVFxQ/Jhke2y5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohgc7-00Ga8q-2s; Mon, 10 Oct 2022 00:25:47 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohgc2-00Ga65-8q for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 00:25:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665361533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Wlgr5678H60NOl4njbwYLitT+ttN6vPLcrFmUMxdHw=; b=IoiF9Pwm2O2E6Aw4tiZPAlh1y6RYA+qLMZS1h4qZg/dzDUtqXNPqdvLINJPwjRjGS7IXJZ S9sGelD11gcQXWQl1A1NMP+FieDL+1QiAY93UeuQt9Wa6BibIv2wDPK0cxUUmlxOfHuhzz i5oIeshid2AkLnzWoUBWjRcTneiniLk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-508-yxRvlpj5P7axHHUHhconUQ-1; Sun, 09 Oct 2022 20:25:28 -0400 X-MC-Unique: yxRvlpj5P7axHHUHhconUQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B071B29AB406; Mon, 10 Oct 2022 00:25:27 +0000 (UTC) Received: from localhost (ovpn-12-34.pek2.redhat.com [10.72.12.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70EE5145D825; Mon, 10 Oct 2022 00:25:26 +0000 (UTC) Date: Mon, 10 Oct 2022 08:25:22 +0800 From: Baoquan He To: Kefeng Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, christophe.leroy@csgroup.eu, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, Arnd Bergmann , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/11] mm/ioremap: change the return value of io[re|un]map_allowed and rename Message-ID: References: <20221009103114.149036-1-bhe@redhat.com> <20221009103114.149036-4-bhe@redhat.com> <10ada8f0-0931-b6a6-e240-fc8b500e578d@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10ada8f0-0931-b6a6-e240-fc8b500e578d@huawei.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221009_172542_398541_DF7DC7EF X-CRM114-Status: GOOD ( 24.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/09/22 at 07:13pm, Kefeng Wang wrote: > > On 2022/10/9 18:31, Baoquan He wrote: > > Currently, hooks ioremap_allowed() and iounmap_allowed() are used to > > check if it's qualified to do ioremap, and now this is done on ARM64. > > However, in oder to convert more architectures to take GENERIC_IOREMAP > > method, several more things need be done in those two hooks: > > 1) The io address mapping need be handled specifically on architectures, > > e.g arc, ia64, s390; > > 2) The original physical address passed into ioremap_prot() need be > > fixed up, e.g arc; > > 3) The 'prot' passed into ioremap_prot() need be adjusted, e.g on arc > > and xtensa. > > > > To handle these three issues, > > > > 1) Rename ioremap_allowed() and iounmap_allowed() to arch_ioremap() > > and arch_iounmap() since the old name can't reflect their > > functionality after change; > > 2) Change the return value of arch_ioremap() so that arch can add > > specifical io address mapping handling inside and return the maped > > address. Now their returned value means: > > === > > arch_ioremap() return a bool, > pointer? Right, I forgot fixing it again. Thanks. > > - IS_ERR means return an error > > - 0 means continue to remap > > - a non-zero, non-IS_ERR pointer is returned directly > > arch_iounmap() return a bool, > > - true means continue to vunmap > > - false means skip vunmap and return directly > ... > > /* > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > > index a68f8fbf423b..2ae16906f3be 100644 > > --- a/include/asm-generic/io.h > > +++ b/include/asm-generic/io.h > > @@ -1049,25 +1049,26 @@ static inline void iounmap(volatile void __iomem *addr) > > /* > > * Arch code can implement the following two hooks when using GENERIC_IOREMAP > > - * ioremap_allowed() return a bool, > > - * - true means continue to remap > > - * - false means skip remap and return directly > > - * iounmap_allowed() return a bool, > > + * arch_ioremap() return a bool, > ditto... Will change. > > area = get_vm_area_caller(size, VM_IOREMAP, > > __builtin_return_address(0)); > > if (!area) > > @@ -52,7 +57,7 @@ void iounmap(volatile void __iomem *addr) > > { > > void *vaddr = (void *)((unsigned long)addr & PAGE_MASK); > > - if (!iounmap_allowed(vaddr)) > > + if (!arch_iounmap((void __iomem *)addr)) > vaddr? No, it's intentional. Alexander suggested this, both of you discussed this in v1, see below thread. https://lore.kernel.org/all/Yu4mYxpV0GWRTjQp@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com/T/#u > > return; > > if (is_vmalloc_addr(vaddr)) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel