From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F38FC433FE for ; Mon, 10 Oct 2022 16:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S7WQ34bnM9gZwTVHXPBStf1Ns7q2BhPYeV0BlgTt8+Q=; b=jjmTHOdAQQmz7F rD0K9InPyoa3eI6h3gODrKPITewrMa4VUhzifewgSTZUpoQgfAJ436wP+OHn46nZcM/YIeWSQSQKf lOqhEjTNDAIHLUOBpNLWo/YKEmBIjqdBCNrrmkcnmwU/I7jPxhatJ/1SrNFLEdPA8k0t9yrYo/1ZP UPReoxpVIk3Za/a0QJYyvpX5ZI78aqF81TnmQDoYfTrq9/7nVKgPOYmxXfJSiHTiPj+xIjyka33gA P5r4T3ZMydpplUfYEUkuskzavkp+sYlZlEw+zH2Cb1eptcFxHrvrHsT0Xrx6asXnZtJc5NUz0NTmb 2U3X0mNa5W5SRtFn550A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvHt-001Rqo-LK; Mon, 10 Oct 2022 16:05:53 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvHq-001Rpw-Ld for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 16:05:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t3g1v5ZZ5rh9HioeyTcJutznI+Yd/lJFzFx2I7x8Z0U=; b=1CrS8UMlauySYX1rpIBVaWrbtA PWmbQCpv3Ts79b8AbBlNhD1wb/rrs6VfyimxCtkp3DiIK7zOXDK3bhkF//GAqfgxikHlRdyX69aBT 8ALUFu25R19rJsdXoqpP8CSSRtoe2IbIfCpwdOekoPBy9kLZgx4+Cv0eJ26knZYqYv2T9f2GEdE7Q TAiG54bYT0jq+5cuv0AgqITBwS1rEpyR56aO6UK53cBsEZVU8t5i94rylQS8upOG+pQRqh/bBvpTI CY3twNnDtgDWWxhyu+WGIf7HNHp9R4le/2cFiAjh2C6Ss5SKfR4wXmT/d6M2rtCSNJPMkdVqmM6E7 0upnqoAw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34666) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ohvHn-0004rI-NR; Mon, 10 Oct 2022 17:05:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ohvHn-0001y0-3L; Mon, 10 Oct 2022 17:05:47 +0100 Date: Mon, 10 Oct 2022 17:05:47 +0100 From: "Russell King (Oracle)" To: Zhen Lei Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ARM: Fix some check warnings of tool sparse Message-ID: References: <20221010095346.1957-1-thunder.leizhen@huawei.com> <20221010095346.1957-2-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221010095346.1957-2-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_090550_727415_DD089C22 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 10, 2022 at 05:53:45PM +0800, Zhen Lei wrote: > Fix the following warnings: > warning: incorrect type in initializer (different address spaces) > expected unsigned short [noderef] __user *register __p > got unsigned short [usertype] * > warning: cast removes address space '__user' of expression I have a general principle that not all warnings should be fixed, especially when it comes to sparse. The aim is not to get to zero warnings - it's to get to a point where the code is correct, and plastering the code with __force casts means it isn't correct - you're just masking the warning. So no, I really don't like this. And I really don't like seeing __force being used in open code in casts. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel